* [PATCH] media: rkisp1: rkisp1-params.c: Fix typos
@ 2021-04-19 6:02 Sebastian Fricke
2021-04-20 9:26 ` Dafna Hirschfeld
0 siblings, 1 reply; 2+ messages in thread
From: Sebastian Fricke @ 2021-04-19 6:02 UTC (permalink / raw)
To: linux-media
Cc: Sebastian Fricke, Helen Koike, Dafna Hirschfeld,
Mauro Carvalho Chehab, Heiko Stuebner, linux-rockchip,
linux-arm-kernel, linux-kernel
s/when the camera active/when the camera is active/
s/thus not isr protection/thus no ISR protection/
Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
index b6beddd988d0..ead948a2d01e 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
@@ -1258,7 +1258,7 @@ void rkisp1_params_configure(struct rkisp1_params *params,
rkisp1_params_config_parameter(params);
}
-/* Not called when the camera active, thus not isr protection. */
+/* Not called when the camera is active, thus no ISR protection. */
void rkisp1_params_disable(struct rkisp1_params *params)
{
rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DPCC_MODE,
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: rkisp1: rkisp1-params.c: Fix typos
2021-04-19 6:02 [PATCH] media: rkisp1: rkisp1-params.c: Fix typos Sebastian Fricke
@ 2021-04-20 9:26 ` Dafna Hirschfeld
0 siblings, 0 replies; 2+ messages in thread
From: Dafna Hirschfeld @ 2021-04-20 9:26 UTC (permalink / raw)
To: Sebastian Fricke, linux-media
Cc: Helen Koike, Mauro Carvalho Chehab, Heiko Stuebner,
linux-rockchip, linux-arm-kernel, linux-kernel
Hi,
On 19.04.21 08:02, Sebastian Fricke wrote:
> s/when the camera active/when the camera is active/
> s/thus not isr protection/thus no ISR protection/
>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@posteo.net>
> ---
> drivers/media/platform/rockchip/rkisp1/rkisp1-params.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> index b6beddd988d0..ead948a2d01e 100644
> --- a/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> +++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-params.c
> @@ -1258,7 +1258,7 @@ void rkisp1_params_configure(struct rkisp1_params *params,
> rkisp1_params_config_parameter(params);
> }
>
> -/* Not called when the camera active, thus not isr protection. */
> +/* Not called when the camera is active, thus no ISR protection. */
I think it would better to write
/* Not called when the camera is active, therefore there is no need to acquire a lock */
Thanks,
Dafna
> void rkisp1_params_disable(struct rkisp1_params *params)
> {
> rkisp1_param_clear_bits(params, RKISP1_CIF_ISP_DPCC_MODE,
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-20 9:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-19 6:02 [PATCH] media: rkisp1: rkisp1-params.c: Fix typos Sebastian Fricke
2021-04-20 9:26 ` Dafna Hirschfeld
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).