From: Rosen Penev <rosenp@gmail.com>
To: linux-media@vger.kernel.org
Subject: [PATCH 7/8] v4l2-utils: turn mbus_names into const vector
Date: Wed, 21 Apr 2021 00:20:34 -0700 [thread overview]
Message-ID: <20210421072035.4188497-7-rosenp@gmail.com> (raw)
In-Reply-To: <20210421072035.4188497-1-rosenp@gmail.com>
Allows usage of a more standard for loop.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
utils/v4l2-ctl/v4l2-ctl-subdev.cpp | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl-subdev.cpp b/utils/v4l2-ctl/v4l2-ctl-subdev.cpp
index d0f391bba..f2be9442c 100644
--- a/utils/v4l2-ctl/v4l2-ctl-subdev.cpp
+++ b/utils/v4l2-ctl/v4l2-ctl-subdev.cpp
@@ -1,3 +1,5 @@
+#include <vector>
+
#include "v4l2-ctl.h"
struct mbus_name {
@@ -5,10 +7,9 @@ struct mbus_name {
__u32 code;
};
-static struct mbus_name mbus_names[] = {
+static const std::vector<mbus_name> mbus_names{
{ "Fixed", MEDIA_BUS_FMT_FIXED },
#include "media-bus-format-names.h"
- { nullptr, 0 }
};
/* selection specified */
@@ -343,9 +344,9 @@ static void print_framefmt(const struct v4l2_mbus_framefmt &fmt)
{
__u32 colsp = fmt.colorspace;
__u32 ycbcr_enc = fmt.ycbcr_enc;
- unsigned int i;
+ size_t i;
- for (i = 0; mbus_names[i].name; i++)
+ for (i = 0; i < mbus_names.size(); i++)
if (mbus_names[i].code == fmt.code)
break;
printf("\tWidth/Height : %u/%u\n", fmt.width, fmt.height);
@@ -554,9 +555,9 @@ void subdev_get(cv4l_fd &_fd)
static void print_mbus_code(__u32 code)
{
- unsigned int i;
+ size_t i;
- for (i = 0; mbus_names[i].name; i++)
+ for (i = 0; i < mbus_names.size(); i++)
if (mbus_names[i].code == code)
break;
if (mbus_names[i].name)
@@ -568,9 +569,8 @@ static void print_mbus_code(__u32 code)
static void print_mbus_codes(int fd, __u32 pad)
{
- struct v4l2_subdev_mbus_code_enum mbus_code;
+ struct v4l2_subdev_mbus_code_enum mbus_code = {};
- memset(&mbus_code, 0, sizeof(mbus_code));
mbus_code.pad = pad;
mbus_code.which = V4L2_SUBDEV_FORMAT_TRY;
--
2.30.2
next prev parent reply other threads:[~2021-04-21 7:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 7:20 [PATCH 1/8] clang-tidy: use auto Rosen Penev
2021-04-21 7:20 ` [PATCH 2/8] clang-tidy: use nullptr Rosen Penev
2021-04-21 7:20 ` [PATCH 3/8] remove unused ARRAY_SIZE Rosen Penev
2021-04-21 7:20 ` [PATCH 4/8] cec-tuner: std::array conversions Rosen Penev
2021-04-21 7:20 ` [PATCH 5/8] v4l2-info: remove a strange sizeof usage Rosen Penev
2021-04-21 8:23 ` Hans Verkuil
2021-04-21 9:19 ` Rosen Penev
2021-04-21 9:33 ` Hans Verkuil
2021-04-21 9:39 ` Rosen Penev
2021-04-21 16:01 ` Nicolas Dufresne
2021-04-21 7:20 ` [PATCH 6/8] v4l2-utils: turn fb_formats to constexpr array Rosen Penev
2021-04-21 7:20 ` Rosen Penev [this message]
2021-04-21 8:02 ` [PATCH 7/8] v4l2-utils: turn mbus_names into const vector Hans Verkuil
2021-04-21 9:25 ` Rosen Penev
2021-04-21 7:20 ` [PATCH 8/8] v4l2-utils: turn prefixes to a constexpr array Rosen Penev
2021-04-21 8:06 ` Hans Verkuil
2021-04-21 9:23 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421072035.4188497-7-rosenp@gmail.com \
--to=rosenp@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).