From: Dan Carpenter <dan.carpenter@oracle.com>
To: Deepak R Varma <drv@mailo.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, mh12gx2825@gmail.com
Subject: Re: [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks
Date: Thu, 29 Apr 2021 15:54:56 +0300 [thread overview]
Message-ID: <20210429125456.GD21598@kadam> (raw)
In-Reply-To: <YIqesrvl3lFwWDhV@192.168.1.8>
On Thu, Apr 29, 2021 at 05:25:30PM +0530, Deepak R Varma wrote:
> On Thu, Apr 29, 2021 at 02:43:04PM +0300, Dan Carpenter wrote:
> > On Thu, Apr 29, 2021 at 05:01:41PM +0530, Deepak R Varma wrote:
> > > On Thu, Apr 29, 2021 at 01:08:09PM +0300, Dan Carpenter wrote:
> > > > On Wed, Apr 21, 2021 at 10:26:09PM +0530, Deepak R Varma wrote:
> > > > > @@ -1044,7 +1048,7 @@ static long mt9m114_s_exposure(struct v4l2_subdev *sd,
> > > > > }
> > > > >
> > > > > /*
> > > > > - // set analog/digital gain
> > > > > + * set analog/digital gain
> > > > > switch(AnalogGain)
> > > > > {
> > > > > case 0:
> > > >
> > > > How on earth does this compile?
> > >
> > > There is a closing */ down under after the entire switch block. The
> > > change I made is within the comment block. I have compiled the built the
> > > driver successfully.
> >
> > Oh... Duh. I thought you converted the // to /*. This patch doesn't
> > make any sense though because originally it was commented out code, but
> > now it's a commented out ball of code and notes.
>
> No problem. It looks wrong with the limited lines in diff. Appreciate
> you looking at it though.
>
Yeah. That's fine by me.
> Is it okay if I send in a separate patch with comment clean up? There
> are several #if 0 code block directives for this driver that I believe can
> be taken off as well. Should I clean those up as well?
Yep. Delete those as well.
regards,
dan carpenter
next prev parent reply other threads:[~2021-04-29 12:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 16:48 [PATCH v1 0/6] staging: media: atomisp: code cleanup fixes Deepak R Varma
2021-04-21 16:50 ` [PATCH v1 1/6] staging: media: atomisp: improve function argument alignment Deepak R Varma
2021-04-21 18:12 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:52 ` [PATCH v1 2/6] staging: media: atomisp: balance braces around if...else block Deepak R Varma
2021-04-21 17:06 ` Fabio Aiuto
2021-04-21 18:13 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:53 ` [PATCH v1 3/6] staging: media: atomisp: use __func__ over function names Deepak R Varma
2021-04-21 18:14 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:56 ` [PATCH v1 4/6] staging: media: atomisp: reformat code comment blocks Deepak R Varma
2021-04-21 17:10 ` Fabio Aiuto
2021-04-21 17:51 ` Deepak R Varma
2021-04-21 17:54 ` Fabio Aiuto
2021-04-21 18:17 ` [PATCH v3 " Deepak R Varma
2021-04-29 10:08 ` [PATCH v1 " Dan Carpenter
2021-04-29 11:31 ` Deepak R Varma
2021-04-29 11:43 ` Dan Carpenter
2021-04-29 11:55 ` Deepak R Varma
2021-04-29 12:54 ` Dan Carpenter [this message]
2021-04-21 16:57 ` [PATCH v1 5/6] staging: media: atomisp: fix CamelCase variable naming Deepak R Varma
2021-04-21 18:18 ` [PATCH v3 " Deepak R Varma
2021-04-21 16:59 ` [PATCH v1 6/6] staging: media: atomisp: replace raw printk() by dev_info() Deepak R Varma
2021-04-21 18:20 ` [PATCH v3 " Deepak R Varma
2021-04-21 18:11 ` [PATCH v3 0/6] staging: media: atomisp: code cleanup fixes Deepak R Varma
2021-04-23 9:09 ` Hans Verkuil
2021-04-23 16:50 ` Deepak R Varma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210429125456.GD21598@kadam \
--to=dan.carpenter@oracle.com \
--cc=drv@mailo.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=mh12gx2825@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).