From: Dan Carpenter <dan.carpenter@oracle.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: Pavel Skripkin <paskripkin@gmail.com>,
mchehab@kernel.org, sakari.ailus@linux.intel.com,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] staging: media: atomisp: remove useless returns
Date: Sat, 8 May 2021 15:48:41 +0300 [thread overview]
Message-ID: <20210508124841.GM1955@kadam> (raw)
In-Reply-To: <20210508124334.GA1403@agape.jhs>
On Sat, May 08, 2021 at 02:43:35PM +0200, Fabio Aiuto wrote:
> Hi Pavel,
>
> On Sat, May 08, 2021 at 03:21:52PM +0300, Pavel Skripkin wrote:
> > Breaks are not useful at the end of void function,
> > they can simply be removed.
>
> this commit description is not really describing the changes that
> have been made
>
Pavel clearly intended to say "Returns" instead of "Breaks". But when
you're complaining about commit messages please write a better one so
the people can cut and paste it.
regards,
dan carpenter
next prev parent reply other threads:[~2021-05-08 12:49 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 20:09 [PATCH] staging: media: atomisp: remove useless breaks Pavel Skripkin
2021-05-07 7:54 ` Sakari Ailus
2021-05-07 13:25 ` Pavel Skripkin
2021-05-08 10:51 ` [PATCH v2] staging: media: atomisp: code cleanup Pavel Skripkin
2021-05-08 10:58 ` Greg KH
2021-05-08 11:32 ` Pavel Skripkin
2021-05-08 12:21 ` [PATCH v3 0/3] staging: media: atomisp: code clean up Pavel Skripkin
2021-05-08 12:21 ` [PATCH v3 1/3] staging: media: atomisp: remove useless breaks Pavel Skripkin
2021-05-08 12:21 ` [PATCH v3 2/3] staging: media: atomisp: remove dublicate code Pavel Skripkin
2021-05-08 12:21 ` [PATCH v3 3/3] staging: media: atomisp: remove useless returns Pavel Skripkin
2021-05-08 12:43 ` Fabio Aiuto
2021-05-08 12:48 ` Dan Carpenter [this message]
2021-05-08 12:59 ` Fabio Aiuto
2021-05-08 13:05 ` Pavel Skripkin
2021-05-08 13:16 ` [PATCH v4 0/3] staging: media: atomisp: code clean up Pavel Skripkin
2021-05-08 13:17 ` [PATCH v4 1/3] staging: media: atomisp: remove useless breaks Pavel Skripkin
2021-05-08 13:17 ` [PATCH v4 2/3] staging: media: atomisp: remove dublicate code Pavel Skripkin
2021-05-08 13:17 ` [PATCH v4 3/3] staging: media: atomisp: remove useless returns Pavel Skripkin
2021-05-25 16:18 ` [PATCH v4 0/3] staging: media: atomisp: code clean up Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210508124841.GM1955@kadam \
--to=dan.carpenter@oracle.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=paskripkin@gmail.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).