linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Yang Yanchao <yangyanchao6@huawei.com>
Cc: linux-distros@vs.openwall.org, linux-media@vger.kernel.org,
	linux1394-devel@lists.sourceforge.net, mchehab@kernel.org,
	security@kernel.org
Subject: Re: [PATCH] media firewire firedtv-avc fix a buffer overflow in avc_ca_pmt()
Date: Mon, 7 Jun 2021 17:28:25 +0300	[thread overview]
Message-ID: <20210607142825.GH10983@kadam> (raw)
In-Reply-To: <20210607073900.1298-1-yangyanchao6@huawei.com>

Thanks for resending this patch, but you need to preserve the author
and Reported-by tags.

https://lore.kernel.org/linux-media/YHaulytonFcW+lyZ@mwanda/

You changed the check in fdtv_ca_pmt() but I don't understand why you
did that...  But looking at it again, I think neither of us was correct,
instead of "sizeof(msg->msg) - 4" it should be "- data_pos":

	if (data_length > sizeof(msg->msg) - data_pos)
		return -EINVAL;

I will resend a v2.

regards,
dan carpenter


  parent reply	other threads:[~2021-06-07 14:29 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-07  7:39 [PATCH] media firewire firedtv-avc fix a buffer overflow in avc_ca_pmt() Yang Yanchao
2021-06-07  9:26 ` Greg KH
2021-06-07 14:28 ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-06-07  7:38 Yang Yanchao
     [not found] <000001d73031$d5304480$7f90cd80$@nsfocus.com>
2021-04-14  8:57 ` [PATCH] media: firewire: firedtv-avc: " Dan Carpenter
2021-04-19 21:42   ` Kees Cook
2021-07-19 10:25   ` Dan Carpenter
2021-07-29 10:32   ` Greg KH
2021-08-16  7:01     ` Salvatore Bonaccorso
2021-08-16  7:27       ` [PATCH v2 RESEND] " Dan Carpenter
2021-09-01 10:40         ` Dan Carpenter
2021-09-12 13:14           ` Salvatore Bonaccorso
2021-09-12 18:26             ` Linus Torvalds
2021-09-13 13:23               ` Mauro Carvalho Chehab
2021-09-19 18:45                 ` Salvatore Bonaccorso
2021-10-11  7:04                   ` Salvatore Bonaccorso
2021-10-11  9:42                     ` [PATCH] " Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210607142825.GH10983@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=linux-distros@vs.openwall.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux1394-devel@lists.sourceforge.net \
    --cc=mchehab@kernel.org \
    --cc=security@kernel.org \
    --cc=yangyanchao6@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).