From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Martina Krasteva <martinax.krasteva@linux.intel.com>
Cc: linux-media@vger.kernel.org, mchehab@kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org,
daniele.alessandrelli@linux.intel.com,
paul.j.murphy@linux.intel.com,
gjorgjix.rosikopulos@linux.intel.com
Subject: Re: [PATCH v2 0/6] Camera Sensor Drivers
Date: Fri, 11 Jun 2021 00:27:51 +0300 [thread overview]
Message-ID: <20210610212751.GJ3@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20210527142145.173-1-martinax.krasteva@linux.intel.com>
Hi Martina,
On Thu, May 27, 2021 at 03:21:39PM +0100, Martina Krasteva wrote:
> From: Martina Krasteva <martinax.krasteva@intel.com>
>
> Patch series contains Sony IMX335, Sony IMX412 and OmniVision OV9282
> camera sensor drivers and respective binding documentation.
>
> v1->v2:
> - define maxItems for reset-gpios in dt binding document
> - make sure the device is powered off on remove
> - use pm_runtime_resume_and_get() instead of pm_runtime_get_sync()
>
> v1: https://patchwork.kernel.org/project/linux-media/list/?series=458115
Thanks for the update.
The patches seem fine, but I noticed one problem: the analogue gain is only
updated when exposure is set. This is a bug.
Most drivers do not try to synchronise setting analogue gain and exposure
to the same frame. Do you need that? Alternatively the control framework
would probably need to be amended a little --- something that would have
other benefits, too.
I don't think that blocks merging the drivers though. But this needs to be
addressed.
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2021-06-10 21:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-27 14:21 [PATCH v2 0/6] Camera Sensor Drivers Martina Krasteva
2021-05-27 14:21 ` [PATCH v2 1/6] dt-bindings: media: Add bindings for imx335 Martina Krasteva
2021-06-04 20:22 ` Rob Herring
2021-05-27 14:21 ` [PATCH v2 2/6] media: i2c: Add imx335 camera sensor driver Martina Krasteva
2021-05-27 14:21 ` [PATCH v2 3/6] dt-bindings: media: Add bindings for imx412 Martina Krasteva
2021-06-04 20:23 ` Rob Herring
2021-05-27 14:21 ` [PATCH v2 4/6] media: i2c: Add imx412 camera sensor driver Martina Krasteva
2021-05-27 14:21 ` [PATCH v2 5/6] dt-bindings: media: Add bindings for ov9282 Martina Krasteva
2021-06-04 20:23 ` Rob Herring
2021-05-27 14:21 ` [PATCH v2 6/6] media: i2c: Add ov9282 camera sensor driver Martina Krasteva
2021-06-10 21:27 ` Sakari Ailus [this message]
2021-06-11 9:06 ` [PATCH v2 0/6] Camera Sensor Drivers Krasteva, Martina
2021-06-11 9:25 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210610212751.GJ3@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=daniele.alessandrelli@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=gjorgjix.rosikopulos@linux.intel.com \
--cc=linux-media@vger.kernel.org \
--cc=martinax.krasteva@linux.intel.com \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@linux.intel.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).