From: Heiko Stuebner <heiko@sntech.de>
To: mchehab@kernel.org, hverkuil-cisco@xs4all.nl
Cc: ezequiel@collabora.com, dafna.hirschfeld@collabora.com,
helen.koike@collabora.com, Laurent.pinchart@ideasonboard.com,
linux-rockchip@lists.infradead.org, linux-media@vger.kernel.org,
heiko@sntech.de, robh+dt@kernel.org, devicetree@vger.kernel.org,
Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Subject: [PATCH v6 01/10] media: rockchip: rkisp1: remove unused irq variable
Date: Fri, 18 Jun 2021 15:02:29 +0200 [thread overview]
Message-ID: <20210618130238.4171196-2-heiko@sntech.de> (raw)
In-Reply-To: <20210618130238.4171196-1-heiko@sntech.de>
From: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
The irq variable in struct rkisp1 is unused as it is only used
to request the irq during probe, so remove it.
Signed-off-by: Heiko Stuebner <heiko.stuebner@theobroma-systems.com>
Reviewed-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
---
drivers/media/platform/rockchip/rkisp1/rkisp1-common.h | 1 -
drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 2 --
2 files changed, 3 deletions(-)
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
index 038c303a8aed..be8a350c7527 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-common.h
@@ -352,7 +352,6 @@ struct rkisp1_debug {
*/
struct rkisp1_device {
void __iomem *base_addr;
- int irq;
struct device *dev;
unsigned int clk_size;
struct clk_bulk_data clks[RKISP1_MAX_BUS_CLK];
diff --git a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
index 7474150b94ed..7afa4c123834 100644
--- a/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
+++ b/drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c
@@ -489,8 +489,6 @@ static int rkisp1_probe(struct platform_device *pdev)
return ret;
}
- rkisp1->irq = irq;
-
for (i = 0; i < match_data->size; i++)
rkisp1->clks[i].id = match_data->clks[i];
ret = devm_clk_bulk_get(dev, match_data->size, rkisp1->clks);
--
2.29.2
next prev parent reply other threads:[~2021-06-18 13:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-18 13:02 [PATCH v6 0/7] rkisp1 support for px30 Heiko Stuebner
2021-06-18 13:02 ` Heiko Stuebner [this message]
2021-06-18 13:02 ` [PATCH v6 02/10] dt-bindings: media: rkisp1: fix pclk clock-name Heiko Stuebner
2021-07-12 20:04 ` Rob Herring
2021-06-18 13:02 ` [PATCH v6 03/10] dt-bindings: media: rkisp1: document different irq possibilities Heiko Stuebner
2021-07-12 20:05 ` Rob Herring
2021-06-18 13:02 ` [PATCH v6 04/10] media: rockchip: rkisp1: allow separate interrupts Heiko Stuebner
2021-06-18 13:02 ` [PATCH v6 05/10] media: rockchip: rkisp1: make some isp-param functions variable Heiko Stuebner
2021-06-20 7:21 ` Dafna Hirschfeld
2021-07-12 20:43 ` Laurent Pinchart
2021-06-18 13:02 ` [PATCH v6 06/10] media: rockchip: rkisp1: make some isp-stats " Heiko Stuebner
2021-06-20 7:22 ` Dafna Hirschfeld
2021-07-12 20:44 ` Laurent Pinchart
2021-06-18 13:02 ` [PATCH v6 07/10] media: rockchip: rkisp1: add prefixes for v10 specific parts Heiko Stuebner
2021-06-18 13:02 ` [PATCH v6 08/10] media: rockchip: rkisp1: add support for v12 isp variants Heiko Stuebner
2021-06-20 7:26 ` Dafna Hirschfeld
2021-07-12 20:47 ` Laurent Pinchart
2021-06-18 13:02 ` [PATCH v6 09/10] dt-bindings: media: rkisp1: document px30 isp compatible Heiko Stuebner
2021-07-12 20:06 ` Rob Herring
2021-06-18 13:02 ` [PATCH v6 10/10] media: rockchip: rkisp1: add support for px30 isp version Heiko Stuebner
2021-07-12 20:40 ` [PATCH v6 0/7] rkisp1 support for px30 Laurent Pinchart
2021-07-12 20:46 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210618130238.4171196-2-heiko@sntech.de \
--to=heiko@sntech.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko.stuebner@theobroma-systems.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).