Re: [PATCH v6 3/5] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera

From: Sakari Ailus <sakari.ailus@iki.fi>
To: Martin Kepplinger <martin.kepplinger@puri.sm>
Cc: krzysztof.kozlowski@canonical.com,
	laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
	kernel@puri.sm, linux-kernel@vger.kernel.org,
	linux-media@vger.kernel.org, mchehab@kernel.org,
	paul.kocialkowski@bootlin.com, pavel@ucw.cz,
	phone-devel@vger.kernel.org, robh@kernel.org,
	shawnx.tu@intel.com
Subject: Re: [PATCH v6 3/5] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera
Date: Thu, 8 Jul 2021 15:57:29 +0300	[thread overview]
Message-ID: <20210708125729.GZ3@valkosipuli.retiisi.eu> (raw)
In-Reply-To: <20210628101054.828579-4-martin.kepplinger@puri.sm>

Hi Martin,

On Mon, Jun 28, 2021 at 12:10:52PM +0200, Martin Kepplinger wrote:
...
> +	hi846->clock = devm_clk_get(&client->dev, NULL);
> +	if (IS_ERR(hi846->clock)) {
> +		dev_err(&client->dev, "failed to get clock: %pe\n", hi846->clock);
> +		return PTR_ERR(hi846->clock);
> +	}
> +
> +	mclk_freq = clk_get_rate(hi846->clock);
> +	dev_dbg(&client->dev, "clk rate: %u\n", mclk_freq);

You'll need to check this is the value you expect it to be. The register
lists are specific to that value.

Could you also check Documentation/driver-api/media/camera-sensor.rst
regarding the assigned-clocks etc. properties, and align the bindings with
that?

-- 
Sakari Ailus