From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26842C4320A for ; Wed, 11 Aug 2021 13:31:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 08F7C60FDA for ; Wed, 11 Aug 2021 13:31:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231477AbhHKNcR (ORCPT ); Wed, 11 Aug 2021 09:32:17 -0400 Received: from mail.ispras.ru ([83.149.199.84]:38170 "EHLO mail.ispras.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229737AbhHKNcR (ORCPT ); Wed, 11 Aug 2021 09:32:17 -0400 Received: from kleverstation.intra.ispras.ru (unknown [10.10.2.220]) by mail.ispras.ru (Postfix) with ESMTPS id 5A612407625E; Wed, 11 Aug 2021 13:31:52 +0000 (UTC) From: Nadezda Lutovinova To: =?UTF-8?q?Niklas=20S=C3=B6derlund?= Cc: Nadezda Lutovinova , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org Subject: [PATCH] media: rcar-csi2: Add checking to rcsi2_start_receiver(). Date: Wed, 11 Aug 2021 16:31:42 +0300 Message-Id: <20210811133142.13363-1-lutovinova@ispras.ru> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org If rcsi2_code_to_fmt() return NULL, then null pointer dereference occurs in the next cycle. The patch adds checking if format is NULL. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Nadezda Lutovinova --- drivers/media/platform/rcar-vin/rcar-csi2.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c index e28eff039688..55bb584d2a13 100644 --- a/drivers/media/platform/rcar-vin/rcar-csi2.c +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c @@ -553,6 +553,12 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv) /* Code is validated in set_fmt. */ format = rcsi2_code_to_fmt(priv->mf.code); + if (!format) { + dev_err(priv->dev, + "Incorrect mbus frame format code %u\n", + priv->mf.code); + return -EINVAL; + } /* * Enable all supported CSI-2 channels with virtual channel and -- 2.17.1