linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] media: rcar-csi2: Add checking to rcsi2_start_receiver().
@ 2021-08-11 13:31 Nadezda Lutovinova
  2021-08-11 13:45 ` Niklas Söderlund
  0 siblings, 1 reply; 5+ messages in thread
From: Nadezda Lutovinova @ 2021-08-11 13:31 UTC (permalink / raw)
  To: Niklas Söderlund
  Cc: Nadezda Lutovinova, Mauro Carvalho Chehab, linux-media,
	linux-renesas-soc, linux-kernel, ldv-project

If rcsi2_code_to_fmt() return NULL,
then null pointer dereference occurs in the next cycle.
The patch adds checking if format is NULL.

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Nadezda Lutovinova <lutovinova@ispras.ru>
---
 drivers/media/platform/rcar-vin/rcar-csi2.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c b/drivers/media/platform/rcar-vin/rcar-csi2.c
index e28eff039688..55bb584d2a13 100644
--- a/drivers/media/platform/rcar-vin/rcar-csi2.c
+++ b/drivers/media/platform/rcar-vin/rcar-csi2.c
@@ -553,6 +553,12 @@ static int rcsi2_start_receiver(struct rcar_csi2 *priv)
 
 	/* Code is validated in set_fmt. */
 	format = rcsi2_code_to_fmt(priv->mf.code);
+	if (!format) {
+		dev_err(priv->dev,
+			"Incorrect mbus frame format code %u\n",
+			priv->mf.code);
+		return -EINVAL;
+	}
 
 	/*
 	 * Enable all supported CSI-2 channels with virtual channel and
-- 
2.17.1


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2021-08-12  9:30 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11 13:31 [PATCH] media: rcar-csi2: Add checking to rcsi2_start_receiver() Nadezda Lutovinova
2021-08-11 13:45 ` Niklas Söderlund
2021-08-11 17:18   ` [PATCH v2] " Nadezda Lutovinova
2021-08-12  9:16     ` Jacopo Mondi
2021-08-12  9:30     ` Niklas Söderlund

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).