Hi Ming, Thank you for the patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on robh/for-next v5.14-rc5] [cannot apply to shawnguo/for-next next-20210811] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Ming-Qian/imx8q-video-decoder-encoder-driver/20210811-164741 base: git://linuxtv.org/media_tree.git master config: i386-randconfig-m021-20210810 (attached as .config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/2fa6f8ecd73870259a9a985a8b214d5eb58a5314 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Ming-Qian/imx8q-video-decoder-encoder-driver/20210811-164741 git checkout 2fa6f8ecd73870259a9a985a8b214d5eb58a5314 # save the attached .config to linux build tree mkdir build_dir make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All error/warnings (new ones prefixed by >>): In file included from ./usr/include/linux/imx_vpu.h:9, from :32: >> ./usr/include/linux/videodev2.h:2403:20: error: field 'timestamp' has incomplete type 2403 | struct timespec timestamp; | ^~~~~~~~~ In file included from :32: >> ./usr/include/linux/imx_vpu.h:12:1: error: C++ style comments are not allowed in ISO C90 12 | //error happened in dec/enc | ^ ./usr/include/linux/imx_vpu.h:12:1: note: (this will be reported only once per input file) >> ./usr/include/linux/imx_vpu.h:17:8: warning: extra tokens at end of #endif directive [-Wendif-labels] 17 | #endif //#ifndef __LINUX_IMX_VPU_H | ^ --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org