From: Sean Young <sean@mess.org>
To: Pavel Skripkin <paskripkin@gmail.com>
Cc: mkrufky@linuxtv.org, mchehab@kernel.org, crope@iki.fi,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
syzbot+5ca0bf339f13c4243001@syzkaller.appspotmail.com
Subject: Re: [PATCH] media: mxl111sf: change mutex_init() location
Date: Sun, 15 Aug 2021 09:37:55 +0100 [thread overview]
Message-ID: <20210815083755.GA1827@gofer.mess.org> (raw)
In-Reply-To: <20210730213829.2909-1-paskripkin@gmail.com>
On Sat, Jul 31, 2021 at 12:38:29AM +0300, Pavel Skripkin wrote:
> Syzbot reported, that mxl111sf_ctrl_msg() uses uninitialized
> mutex. The problem was in wrong mutex_init() location.
>
> Previous mutex_init(&state->msg_lock) call was in ->init() function, but
> dvb_usbv2_init() has this order of calls:
>
> dvb_usbv2_init()
> dvb_usbv2_adapter_init()
> dvb_usbv2_adapter_frontend_init()
> props->frontend_attach()
>
> props->init()
>
> Since mxl111sf_frontend_attach_atsc_mh() calls mxl111sf_ctrl_msg()
> internally we need to initialize state->msg_lock in it to make lockdep
> happy.
What about the other frontends like mxl111sf_frontend_attach_dvbt? They
no longer initialize the mutex.
Thanks
Sean
>
> Reported-and-tested-by: syzbot+5ca0bf339f13c4243001@syzkaller.appspotmail.com
> Fixes: 8572211842af ("[media] mxl111sf: convert to new DVB USB")
> Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
> ---
> drivers/media/usb/dvb-usb-v2/mxl111sf.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/mxl111sf.c b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> index 7865fa0a8295..2e5663ffa7ce 100644
> --- a/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> +++ b/drivers/media/usb/dvb-usb-v2/mxl111sf.c
> @@ -931,8 +931,6 @@ static int mxl111sf_init(struct dvb_usb_device *d)
> .len = sizeof(eeprom), .buf = eeprom },
> };
>
> - mutex_init(&state->msg_lock);
> -
> ret = get_chip_info(state);
> if (mxl_fail(ret))
> pr_err("failed to get chip info during probe");
> @@ -979,8 +977,12 @@ static int mxl111sf_frontend_attach_mh(struct dvb_usb_adapter *adap)
> static int mxl111sf_frontend_attach_atsc_mh(struct dvb_usb_adapter *adap)
> {
> int ret;
> + struct mxl111sf_state *state = d_to_priv(adap_to_d(adap));
> +
> pr_debug("%s\n", __func__);
>
> + mutex_init(&state->msg_lock);
> +
> ret = mxl111sf_lgdt3305_frontend_attach(adap, 0);
> if (ret < 0)
> return ret;
> --
> 2.32.0
next prev parent reply other threads:[~2021-08-15 8:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 21:38 [PATCH] media: mxl111sf: change mutex_init() location Pavel Skripkin
2021-08-15 8:37 ` Sean Young [this message]
2021-08-15 8:49 ` Pavel Skripkin
2021-08-15 9:06 ` Pavel Skripkin
2021-08-19 9:29 ` Sean Young
2021-08-19 9:31 ` Pavel Skripkin
2021-08-19 10:38 ` [PATCH v2] " Pavel Skripkin
2021-08-19 10:42 ` [PATCH v3] " Pavel Skripkin
2021-09-12 15:49 ` Pavel Skripkin
2021-09-15 16:40 ` Sean Young
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210815083755.GA1827@gofer.mess.org \
--to=sean@mess.org \
--cc=crope@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=paskripkin@gmail.com \
--cc=syzbot+5ca0bf339f13c4243001@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).