From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF28FC4338F for ; Mon, 16 Aug 2021 06:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFEEA61A54 for ; Mon, 16 Aug 2021 06:28:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233387AbhHPG2n (ORCPT ); Mon, 16 Aug 2021 02:28:43 -0400 Received: from mga11.intel.com ([192.55.52.93]:13360 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233399AbhHPG2m (ORCPT ); Mon, 16 Aug 2021 02:28:42 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="212685268" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="212685268" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2021 23:28:11 -0700 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="530242264" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Aug 2021 23:28:09 -0700 Received: from paasikivi.fi.intel.com (localhost [127.0.0.1]) by paasikivi.fi.intel.com (Postfix) with SMTP id 07926203D0; Mon, 16 Aug 2021 09:28:07 +0300 (EEST) Date: Mon, 16 Aug 2021 09:28:06 +0300 From: Sakari Ailus To: Andy Shevchenko Cc: Daniel Scally , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Yong Zhi , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Jens Axboe Subject: Re: [PATCH v1 1/1] media: ipu3-cio2: Drop reference on error path in cio2_bridge_connect_sensor() Message-ID: <20210816062806.GT3@paasikivi.fi.intel.com> References: <20210726084055.54887-1-andriy.shevchenko@linux.intel.com> <20210726114433.GB3@paasikivi.fi.intel.com> <20210726120335.GE3@paasikivi.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Tue, Jul 27, 2021 at 02:35:10PM +0300, Andy Shevchenko wrote: > On Mon, Jul 26, 2021 at 03:03:35PM +0300, Sakari Ailus wrote: > > On Mon, Jul 26, 2021 at 02:55:51PM +0300, Andy Shevchenko wrote: > > > On Mon, Jul 26, 2021 at 2:47 PM Sakari Ailus > > > wrote: > > > > On Mon, Jul 26, 2021 at 11:40:55AM +0300, Andy Shevchenko wrote: > > > > > > ... > > > > > > > > err_free_swnodes: > > > > > software_node_unregister_nodes(sensor->swnodes); > > > > > err_put_adev: > > > > > - acpi_dev_put(sensor->adev); > > > > > + acpi_dev_put(adev); > > > > > > > > adev is assigned to sensor->adev before goto so the two have the same > > > > value. I have no problem with the patch though. > > > > > > Are we reading the same version? Or am I missing something? > > > > Ah. I noticed the adev assignment was removed (and added later) by the > > other patch. Yeah, agreed; this one's needed. > > Thanks! Can we have your tag? Apologies for the delay. Acked-by: Sakari Ailus -- Sakari Ailus