linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: sidraya.bj@pathpartnertech.com, gregkh@linuxfoundation.org,
	linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: kbuild-all@lists.01.org, prashanth.ka@pathpartnertech.com,
	praneeth@ti.com, mchehab@kernel.org, linux-media@vger.kernel.org,
	praveen.ap@pathpartnertech.com,
	Sidraya <sidraya.bj@pathpartnertech.com>
Subject: Re: [PATCH 27/30] media: platform: vxd: Kconfig: Add Video decoder Kconfig and Makefile
Date: Thu, 19 Aug 2021 02:24:07 +0800	[thread overview]
Message-ID: <202108190252.cuQREQUH-lkp@intel.com> (raw)
In-Reply-To: <20210818141037.19990-28-sidraya.bj@pathpartnertech.com>

[-- Attachment #1: Type: text/plain, Size: 14372 bytes --]

Hi,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on staging/staging-testing driver-core/driver-core-testing linus/master v5.14-rc6 next-20210818]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/sidraya-bj-pathpartnertech-com/TI-Video-Decoder-driver-upstreaming-to-v5-14-rc6-kernel/20210818-221811
base:   git://linuxtv.org/media_tree.git master
config: m68k-allmodconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f42ae4f45639a6214f9e775d4280061bf52fc229
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review sidraya-bj-pathpartnertech-com/TI-Video-Decoder-driver-upstreaming-to-v5-14-rc6-kernel/20210818-221811
        git checkout f42ae4f45639a6214f9e775d4280061bf52fc229
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=m68k 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:456,
                    from include/linux/kernel.h:19,
                    from include/linux/radix-tree.h:12,
                    from include/linux/idr.h:15,
                    from drivers/staging/media/vxd/decoder/../common/img_mem_man.c:15:
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c: In function '_img_mem_alloc':
>> drivers/staging/media/vxd/decoder/../common/img_mem_man.c:290:25: warning: format '%zu' expects argument of type 'size_t', but argument 9 has type 'long unsigned int' [-Wformat=]
     290 |         dev_dbg(device, "%s heap %p ctx %p created buffer %d (%p) actual_size %zu\n",
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
     166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:9: note: in expansion of macro 'dynamic_dev_dbg'
     123 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:30: note: in expansion of macro 'dev_fmt'
     123 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                              ^~~~~~~
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:290:9: note: in expansion of macro 'dev_dbg'
     290 |         dev_dbg(device, "%s heap %p ctx %p created buffer %d (%p) actual_size %zu\n",
         |         ^~~~~~~
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:290:81: note: format string is defined here
     290 |         dev_dbg(device, "%s heap %p ctx %p created buffer %d (%p) actual_size %zu\n",
         |                                                                               ~~^
         |                                                                                 |
         |                                                                                 unsigned int
         |                                                                               %lu
   In file included from include/linux/printk.h:456,
                    from include/linux/kernel.h:19,
                    from include/linux/radix-tree.h:12,
                    from include/linux/idr.h:15,
                    from drivers/staging/media/vxd/decoder/../common/img_mem_man.c:15:
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c: In function 'img_mem_alloc':
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:309:25: warning: format '%zu' expects argument of type 'size_t', but argument 7 has type 'long unsigned int' [-Wformat=]
     309 |         dev_dbg(device, "%s heap %d ctx %p size %zu\n", __func__, heap_id,
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
     166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:9: note: in expansion of macro 'dynamic_dev_dbg'
     123 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:30: note: in expansion of macro 'dev_fmt'
     123 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                              ^~~~~~~
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:309:9: note: in expansion of macro 'dev_dbg'
     309 |         dev_dbg(device, "%s heap %d ctx %p size %zu\n", __func__, heap_id,
         |         ^~~~~~~
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:309:51: note: format string is defined here
     309 |         dev_dbg(device, "%s heap %d ctx %p size %zu\n", __func__, heap_id,
         |                                                 ~~^
         |                                                   |
         |                                                   unsigned int
         |                                                 %lu
   In file included from include/linux/printk.h:456,
                    from include/linux/kernel.h:19,
                    from include/linux/radix-tree.h:12,
                    from include/linux/idr.h:15,
                    from drivers/staging/media/vxd/decoder/../common/img_mem_man.c:15:
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:333:25: warning: format '%zu' expects argument of type 'size_t', but argument 9 has type 'long unsigned int' [-Wformat=]
     333 |         dev_dbg(device, "%s heap %d ctx %p created buffer %d (%p) size %zu\n",
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
     166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:9: note: in expansion of macro 'dynamic_dev_dbg'
     123 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:30: note: in expansion of macro 'dev_fmt'
     123 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                              ^~~~~~~
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:333:9: note: in expansion of macro 'dev_dbg'
     333 |         dev_dbg(device, "%s heap %d ctx %p created buffer %d (%p) size %zu\n",
         |         ^~~~~~~
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:333:74: note: format string is defined here
     333 |         dev_dbg(device, "%s heap %d ctx %p created buffer %d (%p) size %zu\n",
         |                                                                        ~~^
         |                                                                          |
         |                                                                          unsigned int
         |                                                                        %lu
   In file included from include/linux/printk.h:456,
                    from include/linux/kernel.h:19,
                    from include/linux/radix-tree.h:12,
                    from include/linux/idr.h:15,
                    from drivers/staging/media/vxd/decoder/../common/img_mem_man.c:15:
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c: In function '_img_mem_import':
   drivers/staging/media/vxd/decoder/../common/img_mem_man.c:372:25: warning: format '%zu' expects argument of type 'size_t', but argument 8 has type 'long unsigned int' [-Wformat=]
     372 |         dev_dbg(device, "%s ctx %p created buffer %d (%p) actual_size %zu\n",
         |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dynamic_debug.h:134:29: note: in definition of macro '__dynamic_func_call'
     134 |                 func(&id, ##__VA_ARGS__);               \
         |                             ^~~~~~~~~~~
   include/linux/dynamic_debug.h:166:9: note: in expansion of macro '_dynamic_func_call'
     166 |         _dynamic_func_call(fmt,__dynamic_dev_dbg,               \
         |         ^~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:123:9: note: in expansion of macro 'dynamic_dev_dbg'
     123 |         dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~~~~~~~~~~
--
   drivers/staging/media/vxd/decoder/../common/work_queue.c: In function 'get_delayed_work_buff':
>> drivers/staging/media/vxd/decoder/../common/work_queue.c:148:22: warning: variable 'previous' set but not used [-Wunused-but-set-variable]
     148 |         struct node *previous = NULL;
         |                      ^~~~~~~~
--
>> drivers/staging/media/vxd/decoder/jpeg_secure_parser.c:596:5: warning: no previous prototype for 'bspp_jpeg_unit_parser' [-Wmissing-prototypes]
     596 | int bspp_jpeg_unit_parser(void *swsr_ctx, struct bspp_unit_data *unit_data)
         |     ^~~~~~~~~~~~~~~~~~~~~


vim +290 drivers/staging/media/vxd/decoder/../common/img_mem_man.c

76b88427fbba69 Sidraya 2021-08-18  240  
76b88427fbba69 Sidraya 2021-08-18  241  static int _img_mem_alloc(void *device, struct mem_ctx *ctx,
76b88427fbba69 Sidraya 2021-08-18  242  			  struct heap *heap, unsigned long size,
76b88427fbba69 Sidraya 2021-08-18  243  			  enum mem_attr attr, struct buffer **buffer_new)
76b88427fbba69 Sidraya 2021-08-18  244  {
76b88427fbba69 Sidraya 2021-08-18  245  	struct buffer *buffer;
76b88427fbba69 Sidraya 2021-08-18  246  	int ret;
76b88427fbba69 Sidraya 2021-08-18  247  
76b88427fbba69 Sidraya 2021-08-18  248  	if (size == 0) {
76b88427fbba69 Sidraya 2021-08-18  249  		dev_err(device, "%s: buffer size is zero\n", __func__);
76b88427fbba69 Sidraya 2021-08-18  250  		return -EINVAL;
76b88427fbba69 Sidraya 2021-08-18  251  	}
76b88427fbba69 Sidraya 2021-08-18  252  
76b88427fbba69 Sidraya 2021-08-18  253  	if (!heap->ops || !heap->ops->alloc) {
76b88427fbba69 Sidraya 2021-08-18  254  		dev_err(device, "%s: no alloc function in heap %d!\n",
76b88427fbba69 Sidraya 2021-08-18  255  			__func__, heap->id);
76b88427fbba69 Sidraya 2021-08-18  256  		return -EINVAL;
76b88427fbba69 Sidraya 2021-08-18  257  	}
76b88427fbba69 Sidraya 2021-08-18  258  
76b88427fbba69 Sidraya 2021-08-18  259  	buffer = kzalloc(sizeof(*buffer), GFP_KERNEL);
76b88427fbba69 Sidraya 2021-08-18  260  	if (!buffer)
76b88427fbba69 Sidraya 2021-08-18  261  		return -ENOMEM;
76b88427fbba69 Sidraya 2021-08-18  262  
76b88427fbba69 Sidraya 2021-08-18  263  	ret = idr_alloc(ctx->buffers, buffer,
76b88427fbba69 Sidraya 2021-08-18  264  			MEM_MAN_MIN_BUFFER, MEM_MAN_MAX_BUFFER, GFP_KERNEL);
76b88427fbba69 Sidraya 2021-08-18  265  	if (ret < 0) {
76b88427fbba69 Sidraya 2021-08-18  266  		dev_err(device, "%s: idr_alloc failed\n", __func__);
76b88427fbba69 Sidraya 2021-08-18  267  		goto idr_alloc_failed;
76b88427fbba69 Sidraya 2021-08-18  268  	}
76b88427fbba69 Sidraya 2021-08-18  269  
76b88427fbba69 Sidraya 2021-08-18  270  	buffer->id = ret;
76b88427fbba69 Sidraya 2021-08-18  271  	buffer->request_size = size;
76b88427fbba69 Sidraya 2021-08-18  272  	buffer->actual_size = ((size + PAGE_SIZE - 1) / PAGE_SIZE) * PAGE_SIZE;
76b88427fbba69 Sidraya 2021-08-18  273  	buffer->device = device;
76b88427fbba69 Sidraya 2021-08-18  274  	buffer->mem_ctx = ctx;
76b88427fbba69 Sidraya 2021-08-18  275  	buffer->heap = heap;
76b88427fbba69 Sidraya 2021-08-18  276  	INIT_LIST_HEAD(&buffer->mappings);
76b88427fbba69 Sidraya 2021-08-18  277  	buffer->kptr = NULL;
76b88427fbba69 Sidraya 2021-08-18  278  	buffer->priv = NULL;
76b88427fbba69 Sidraya 2021-08-18  279  
76b88427fbba69 Sidraya 2021-08-18  280  	ret = heap->ops->alloc(device, heap, buffer->actual_size, attr,
76b88427fbba69 Sidraya 2021-08-18  281  		buffer);
76b88427fbba69 Sidraya 2021-08-18  282  	if (ret) {
76b88427fbba69 Sidraya 2021-08-18  283  		dev_err(device, "%s: heap %d alloc failed\n", __func__,
76b88427fbba69 Sidraya 2021-08-18  284  			heap->id);
76b88427fbba69 Sidraya 2021-08-18  285  		goto heap_alloc_failed;
76b88427fbba69 Sidraya 2021-08-18  286  	}
76b88427fbba69 Sidraya 2021-08-18  287  
76b88427fbba69 Sidraya 2021-08-18  288  	*buffer_new = buffer;
76b88427fbba69 Sidraya 2021-08-18  289  
76b88427fbba69 Sidraya 2021-08-18 @290  	dev_dbg(device, "%s heap %p ctx %p created buffer %d (%p) actual_size %zu\n",
76b88427fbba69 Sidraya 2021-08-18  291  		__func__, heap, ctx, buffer->id, buffer, buffer->actual_size);
76b88427fbba69 Sidraya 2021-08-18  292  	return 0;
76b88427fbba69 Sidraya 2021-08-18  293  
76b88427fbba69 Sidraya 2021-08-18  294  heap_alloc_failed:
76b88427fbba69 Sidraya 2021-08-18  295  	idr_remove(ctx->buffers, buffer->id);
76b88427fbba69 Sidraya 2021-08-18  296  idr_alloc_failed:
76b88427fbba69 Sidraya 2021-08-18  297  	kfree(buffer);
76b88427fbba69 Sidraya 2021-08-18  298  	return ret;
76b88427fbba69 Sidraya 2021-08-18  299  }
76b88427fbba69 Sidraya 2021-08-18  300  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 60717 bytes --]

  reply	other threads:[~2021-08-18 18:24 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-18 14:10 [PATCH 00/30] TI Video Decoder driver upstreaming to v5.14-rc6 kernel sidraya.bj
2021-08-18 14:10 ` [PATCH 01/30] dt-bindings: Add binding for img,d5500-vxd for DRA8x sidraya.bj
2021-08-18 14:10 ` [PATCH 02/30] v4l: vxd-dec: Create mmu programming helper library sidraya.bj
2021-08-18 14:37   ` Greg KH
2021-08-18 14:10 ` [PATCH 03/30] v4l: vxd-dec: Create vxd_dec Mem Manager " sidraya.bj
2021-08-24 13:34   ` Dan Carpenter
2021-09-14  3:40     ` Sidraya Jayagond
2021-09-14  4:35       ` Greg KH
2021-09-20 18:07         ` Sidraya Jayagond
2021-08-18 14:10 ` [PATCH 04/30] v4l: vxd-dec: Add vxd " sidraya.bj
2021-08-18 14:10 ` [PATCH 05/30] v4l: vxd-dec: Add IMG VXD Video Decoder mem to mem drive sidraya.bj
2021-08-18 14:10 ` [PATCH 06/30] v4l: vxd-dec: Add hardware control modules sidraya.bj
2021-08-18 14:10 ` [PATCH 07/30] v4l: vxd-dec: Add vxd core module sidraya.bj
2021-08-18 14:10 ` [PATCH 08/30] v4l: vxd-dec: Add translation control modules sidraya.bj
2021-08-18 14:10 ` [PATCH 09/30] v4l: vxd-dec: Add idgen api modules sidraya.bj
2021-08-24 14:00   ` Dan Carpenter
2021-09-14  4:24     ` Sidraya Jayagond
2021-08-18 14:10 ` [PATCH 10/30] v4l: vxd-dec: Add utility modules sidraya.bj
2021-08-18 14:10 ` [PATCH 11/30] v4l: vxd-dec: Add TALMMU module sidraya.bj
2021-08-18 14:10 ` [PATCH 12/30] v4l: vxd-dec: Add VDEC MMU wrapper sidraya.bj
2021-08-18 14:10 ` [PATCH 14/30] v4l: vxd-dec: Add common headers sidraya.bj
2021-08-18 14:10 ` [PATCH 15/30] v4l: vxd-dec: Add firmware interface headers sidraya.bj
2021-08-18 14:10 ` [PATCH 16/30] v4l: vxd-dec: Add pool api modules sidraya.bj
2021-08-18 14:10 ` [PATCH 17/30] v4l: vxd-dec: This patch implements resource manage component sidraya.bj
2021-08-18 14:10 ` [PATCH 18/30] v4l: vxd-dec: This patch implements pixel processing library sidraya.bj
2021-08-18 14:10 ` [PATCH 19/30] v4l:vxd-dec:vdecdd utility library sidraya.bj
2021-08-18 14:10 ` [PATCH 20/30] v4l:vxd-dec:Decoder resource component sidraya.bj
2021-08-18 14:10 ` [PATCH 21/30] v4l:vxd-dec:Decoder Core Component sidraya.bj
2021-08-18 14:10 ` [PATCH 22/30] v4l:vxd-dec:vdecdd headers added sidraya.bj
2021-08-18 14:10 ` [PATCH 23/30] v4l:vxd-dec:Decoder Component sidraya.bj
2021-08-18 14:10 ` [PATCH 24/30] v4l:vxd-dec: Add resource manager sidraya.bj
2021-08-18 14:38   ` Greg KH
2021-08-18 14:10 ` [PATCH 25/30] v4l: videodev2: Add 10bit definitions for NV12 and NV16 color formats sidraya.bj
2021-08-24 16:14   ` Nicolas Dufresne
2021-08-18 14:10 ` [PATCH 26/30] media: Kconfig: Add Video decoder kconfig and Makefile entries sidraya.bj
2021-08-18 14:10 ` [PATCH 27/30] media: platform: vxd: Kconfig: Add Video decoder Kconfig and Makefile sidraya.bj
2021-08-18 18:24   ` kernel test robot [this message]
2021-08-19  5:59   ` kernel test robot
2021-08-18 14:10 ` [PATCH 28/30] IMG DEC V4L2 Interface function implementations sidraya.bj
2021-08-18 19:22   ` kernel test robot
2021-08-18 14:10 ` [PATCH 29/30] arm64: dts: dra82: Add v4l2 vxd_dec device node sidraya.bj
2021-08-18 16:44   ` Nishanth Menon
2021-08-18 14:10 ` [PATCH 30/30] ARM64: ti_sdk_arm64_release_defconfig: Enable d5520 video decoder driver sidraya.bj
2021-08-18 14:25   ` Bajjuri, Praneeth
2021-08-18 16:35   ` Nishanth Menon
2021-08-24 13:06 ` [PATCH 00/30] TI Video Decoder driver upstreaming to v5.14-rc6 kernel Hans Verkuil
2021-08-24 13:36 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202108190252.cuQREQUH-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mchehab@kernel.org \
    --cc=praneeth@ti.com \
    --cc=prashanth.ka@pathpartnertech.com \
    --cc=praveen.ap@pathpartnertech.com \
    --cc=sidraya.bj@pathpartnertech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).