From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B3FDC43217 for ; Mon, 13 Sep 2021 08:33:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4115D6108C for ; Mon, 13 Sep 2021 08:33:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238488AbhIMIex (ORCPT ); Mon, 13 Sep 2021 04:34:53 -0400 Received: from new2-smtp.messagingengine.com ([66.111.4.224]:49317 "EHLO new2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238370AbhIMIeI (ORCPT ); Mon, 13 Sep 2021 04:34:08 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id F34C6580B05; Mon, 13 Sep 2021 04:32:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 13 Sep 2021 04:32:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=75DIi7N4mlFsZ7koSe8DWsv99XW KUQRl2cLcYOj+eRw=; b=AnOlF00X96M/zW0xSLaelxCdp+K18+ZvmQsW1G5Jmc1 oElqXlG6JCdmczd/vKPwL3qL4BDsX6dkA2fN6QRoJ8grHu2Thc25WjizjZg9Avzc RaYn7G8tooHV1u49uwMxyOxP30LxlMkM6+rtPQOjoVzsYMx9PyXe3O4Hnv/egiTw NyZet3CUtGVfyhSbCqE/wgND+4cU/EVakaCS6mEzJvl0dptFN5cXvZc4+UylhV8/ aL8qVF/Ul/4o34hylws0sak95LsbZcJkg/JVlqgWvdOBfXQNDvZrK8rb30ljmMNm pHD53eqmmRrzSQbAhzT6rPX5eSzlc5E4LO/IrfEHvjQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=75DIi7 N4mlFsZ7koSe8DWsv99XWKUQRl2cLcYOj+eRw=; b=SN9b9to4Bd4dhSPZrvD5Ip v6TQojxM8KFWFJbSgojmFZqVxzmpkrCCS7Bi0ctSCWNTpLP0C+Ltb2smFmZ9t5dN 8H0cWcfdxawGXxZmZOxKv5iZZrdrRSh5ENXelBLtB+8O1cjQ4VNJBWzGOfDPgiYO 0E8/MSmhw0cFXxAdjKqDebZ3qX1Y0mmgcxORhkBvByyHCQoQ23m1iSdgFSaKQdZF xDmDbMMKcZGxSF8R8V2NXQoLNCIL1jvVHqG/fH+Pkc2CGK/lTI8JGEfY3DWKHnBm OnmJUZLUdv+BwoWPMWiK4Ikr+HL7emzRoNrMO/poMgcCqISHnFes1IhfajTEwufg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrudegjedgtdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 13 Sep 2021 04:32:50 -0400 (EDT) Date: Mon, 13 Sep 2021 10:32:48 +0200 From: Maxime Ripard To: Paul Kocialkowski Cc: Samuel Holland , Yong Deng , Mauro Carvalho Chehab , Rob Herring , Sakari Ailus , Hans Verkuil , Chen-Yu Tsai , Jernej Skrabec , Greg Kroah-Hartman , Helen Koike , Laurent Pinchart , Thomas Petazzoni , linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-clk@vger.kernel.org, linux-staging@lists.linux.dev Subject: Re: [PATCH 19/22] soc: sunxi: mbus: Add A31 ISP compatibles to the list Message-ID: <20210913083248.h3m775cbmwsvhg6g@gilmour> References: <20210910184147.336618-1-paul.kocialkowski@bootlin.com> <20210910184147.336618-20-paul.kocialkowski@bootlin.com> <208239ba-01b1-451e-6030-894bd25770c3@sholland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="f2zlbewwwotbr242" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org --f2zlbewwwotbr242 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 13, 2021 at 09:45:22AM +0200, Paul Kocialkowski wrote: > Hi Samuel, >=20 > On Fri 10 Sep 21, 21:36, Samuel Holland wrote: > > On 9/10/21 1:41 PM, Paul Kocialkowski wrote: > > > The A31 ISP sits on the mbus and requires the usual bus address > > > adaptation. Add its compatibles to the list. > >=20 > > My understanding is that this driver only exists to work around old DT > > bindings where the interconnects/interconnect-names =3D "dma-mem" > > properties are not required (and so they are historically missing from > > the device trees). > >=20 > > For new bindings, it would be better to use those properties and not add > > to this list. >=20 > Oh okay, I didn't really look into it and just did the same thing that was > done for the CSI controller. Thanks for the heads up! This code was done to maintain backward compatibility. New DT should indeed use the interconnects property. Maxime --f2zlbewwwotbr242 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYT8MsAAKCRDj7w1vZxhR xZy/AP9rOXpdGd4BspcymmvG0qIIWP3Pq7kC/1bc4wAklO4KHgD9Ha2JWbrzpEPh UGlrPhGtVhtUgMRZHOwB90O+gdiFLgI= =Gzk+ -----END PGP SIGNATURE----- --f2zlbewwwotbr242--