Re: [PATCH v9 3/3] media: i2c: isl7998x: Add driver for Intersil ISL7998x

[Mauro Carvalho Chehab <mchehab@kernel.org>]

Em Thu, 16 Dec 2021 12:41:05 +0100
Michael Tretter <m.tretter@pengutronix.de> escreveu:

> On Tue, 14 Dec 2021 11:14:58 +0100, Mauro Carvalho Chehab wrote:
> > Em Mon, 29 Nov 2021 12:27:08 +0100
> > Michael Tretter <m.tretter@pengutronix.de> escreveu:
> >   
> > > From: Marek Vasut <marex@denx.de>
> > > 
> > > Add driver for the Intersil ISL7998x Analog to MIPI CSI-2/BT656 decoder.
> > > This chip supports 1/2/4 analog video inputs and converts them into
> > > 1/2/4 VCs in MIPI CSI2 stream.
> > > 
> > > This driver currently supports ISL79987 and both 720x480 and 720x576
> > > resolutions, however as per specification, all inputs must use the
> > > same resolution and standard. The only supported pixel format is now
> > > YUYV/YUV422. The chip should support RGB565 on the CSI2 as well, but
> > > this is currently unsupported.  
> > 
> > There are *lots* of checkpatch warnings (on strict mode) due to the
> > usage of CamelCase macros. Please fix. Just doing that should be enough
> > to solve them:
> > 
> >   sed s,ISL7998x_REG_Px_ACA_FLEX_WIN_Y_BL_H,ISL7998X_REG_PX_ACA_FLEX_WIN_Y_BL_H,g -i drivers/media/i2c/isl7998x.c
> >   sed s,ISL7998x,ISL7998X,g -i drivers/media/i2c/isl7998x.c
> >   sed s,ISL7998X_REG_Pn,ISL7998X_REG_PN, -i drivers/media/i2c/isl7998x.c
> >   sed s,ISL7998X_REG_Pn,ISL7998X_REG_PN,g -i drivers/media/i2c/isl7998x.c
> >   sed s,ISL7998X_REG_PX,ISL7998X_REG_PX,g -i drivers/media/i2c/isl7998x.c
> >   sed s,ISL7998X_REG_Px,ISL7998X_REG_PX,g -i drivers/media/i2c/isl7998x.c  
> 
> These are easy to fix.
> 
> Talking about checkpatch warnings: I am wondering about the checkpatch errors
> for the macro definitions of the regmap ranges:
> 
> 	ERROR: Macros with complex values should be enclosed in parentheses
> 	#1210: FILE: drivers/media/i2c/isl7998x.c:1210:
> 	+#define ISL7998X_REG_DECODER_ACA_VOLATILE_RANGE(page)                  \
> 	+       /* Decoder range */                                             \
> 	+       regmap_reg_range(ISL7998X_REG_PX_DEC_STATUS_1(page),            \
> 	+                        ISL7998X_REG_PX_DEC_STATUS_1(page)),           \
> 	+       regmap_reg_range(ISL7998X_REG_PX_DEC_SDT(page),                 \
> 	+                        ISL7998X_REG_PX_DEC_SDT(page)),                \
> 	+       regmap_reg_range(ISL7998X_REG_PX_DEC_MVSN(page),                \
> 	+                        ISL7998X_REG_PX_DEC_HFREF(page)),              \
> 	+       /* ACA range */                                                 \
> 	+       regmap_reg_range(ISL7998X_REG_PX_ACA_Y_AVG(page),               \
> 	+                        ISL7998X_REG_PX_ACA_Y_HIGH(page)),             \
> 	+       regmap_reg_range(ISL7998X_REG_PX_ACA_HIST_DATA_LO(page),        \
> 	+                        ISL7998X_REG_PX_ACA_FLEX_WIN_CR_CLR(page))
> 
> Are these errors acceptable? The macro is used in a structure definition and
> the error cannot be resolved by adding parentheses. Do I have to or can I do
> anything about these errors?

Yeah, those are acceptable. The defines check for checkpatch don't consider
them to be used inside a struct.

> > 
> > There's also one mis-aligned function checkpatch warning that should 
> > be easy to fix.  
> 
> Ack. This change breaks the 80 character limit (but not 100 characters).
> There are a few other instances that break the limit already and I guess it is
> fine.
> 
> > 
> > Besides that, see below.
> >   
> > > 
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > Cc: Sakari Ailus <sakari.ailus@linux.intel.com>
> > > Cc: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > To: linux-media@vger.kernel.org
> > > Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
> > > ---
> > > Changelog:
> > > 
> > > v9: none
> > > 
> > > v8:
> > > 
> > > - fix warning "type qualifiers ignored on function return type"
> > > 
> > > v7:
> > > 
> > > - reserve driver specific controls
> > > - add documentation for driver specific controls
> > > - implement g_input_status
> > > - track device enabled state in driver
> > > - store norm instead of mode in driver
> > > - select test pattern based on video norm
> > > - improve debug message for enabled test pattern
> > > - fix off by one with 4 inputs
> > > - implement querystd and friends
> > > - fix polling condition for standard detection
> > > - use v4l2_norm_to_name instead of custom implementation
> > > 
> > > v6:
> > > 
> > > - remove unused log2.h
> > > - add select MEDIA_CONTROLLER
> > > - use poll_read_timeout to wait for power on
> > > - add timeout to polling for video standard
> > > - use fwnode_graph_get_endpoint_by_id
> > > - fix invalid bus type error message
> > > 
> > > v5: none
> > > 
> > > v4:
> > > 
> > > - fix lines over 80 chars where applicable
> > > - fix possible NULL pointer access in link_freq
> > > - initialize bus type with CSI2_DPHY
> > > - iterate over pads instead of hard coded 4
> > > - merge power_{on,off} functions into resume,suspend
> > > - switch to v4l2_subdev_state
> > > - report field order based on video standard
> > > - add error message for timeout
> > > - simplify dev_dbg statement in update_std
> > > - call v4l2_ctrl_handler_setup
> > > - don't set control if pm_runtime is not enabled
> > > - fix YUV422 byte order
> > > - switch to pre_streamon callback for LP11 mode
> > > 
> > > v3:
> > > 
> > > - follow dt binding change: pd-gpios -> powerdown-gpios
> > > 
> > > v2:
> > > 
> > > - general cleanup
> > > - remove isl7998x_g_mbus_config function
> > > - implement enum_frame_size function
> > > - replace msleep with usleep_range
> > > - rework set_fmt/get_fmt functions
> > > - calculate number of inputs using number of input ports
> > > - switch to runtime_pm
> > > - add reset gpio
> > > - add adv_debug support
> > > - add MAINTAINERS entry
> > > 
> > > fixup! media: i2c: isl7998x: Add driver for Intersil ISL7998x
> > > ---
> > >  MAINTAINERS                        |    8 +
> > >  drivers/media/i2c/Kconfig          |   10 +
> > >  drivers/media/i2c/Makefile         |    1 +
> > >  drivers/media/i2c/isl7998x.c       | 1543 ++++++++++++++++++++++++++++
> > >  include/uapi/linux/v4l2-controls.h |    6 +
> > >  5 files changed, 1568 insertions(+)
> > >  create mode 100644 drivers/media/i2c/isl7998x.c
> > > 
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 8eea24d54624..2b609a57b7ac 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -9902,6 +9902,14 @@ L:	linux-iio@vger.kernel.org
> > >  F:	Documentation/devicetree/bindings/counter/interrupt-counter.yaml
> > >  F:	drivers/counter/interrupt-cnt.c
> > >  
> > > +INTERSIL ISL7998X VIDEO DECODER DRIVER
> > > +M:	Michael Tretter <m.tretter@pengutronix.de>
> > > +R:	Pengutronix Kernel Team <kernel@pengutronix.de>
> > > +L:	linux-media@vger.kernel.org
> > > +S:	Maintained
> > > +F:	Documentation/devicetree/bindings/media/i2c/isil,isl79987.yaml
> > > +F:	drivers/media/i2c/isl7998x.c
> > > +
> > >  INVENSENSE ICM-426xx IMU DRIVER
> > >  M:	Jean-Baptiste Maneyrol <jmaneyrol@invensense.com>
> > >  L:	linux-iio@vger.kernel.org
> > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig
> > > index d6a5d4ca439a..b34d25961d3f 100644
> > > --- a/drivers/media/i2c/Kconfig
> > > +++ b/drivers/media/i2c/Kconfig
> > > @@ -325,6 +325,16 @@ config VIDEO_BT866
> > >  	  To compile this driver as a module, choose M here: the
> > >  	  module will be called bt866.
> > >  
> > > +config VIDEO_ISL7998X
> > > +	tristate "Intersil ISL7998x video decoder"
> > > +	depends on VIDEO_V4L2 && I2C
> > > +	depends on OF_GPIO
> > > +	select MEDIA_CONTROLLER
> > > +	select VIDEO_V4L2_SUBDEV_API
> > > +	help
> > > +	  Support for Intersil ISL7998x analog to MIPI-CSI2 or
> > > +	  BT.656 decoder.
> > > +
> > >  config VIDEO_KS0127
> > >  	tristate "KS0127 video decoder"
> > >  	depends on VIDEO_V4L2 && I2C
> > > diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile
> > > index 4d4fe08d7a6a..249720c25b5e 100644
> > > --- a/drivers/media/i2c/Makefile
> > > +++ b/drivers/media/i2c/Makefile
> > > @@ -130,6 +130,7 @@ obj-$(CONFIG_VIDEO_IMX334)	+= imx334.o
> > >  obj-$(CONFIG_VIDEO_IMX335)	+= imx335.o
> > >  obj-$(CONFIG_VIDEO_IMX355)	+= imx355.o
> > >  obj-$(CONFIG_VIDEO_IMX412)	+= imx412.o
> > > +obj-$(CONFIG_VIDEO_ISL7998X)	+= isl7998x.o
> > >  obj-$(CONFIG_VIDEO_MAX9286)	+= max9286.o
> > >  obj-$(CONFIG_VIDEO_MAX9271_LIB)	+= max9271.o
> > >  obj-$(CONFIG_VIDEO_RDACM20)	+= rdacm20.o
> > > diff --git a/drivers/media/i2c/isl7998x.c b/drivers/media/i2c/isl7998x.c
> > > new file mode 100644
> > > index 000000000000..2e35b85885e1
> > > --- /dev/null
> > > +++ b/drivers/media/i2c/isl7998x.c
> > > @@ -0,0 +1,1543 @@
> > > +// SPDX-License-Identifier: GPL-2.0
> > > +/*
> > > + * Intersil ISL7998x analog to MIPI CSI-2 or BT.656 decoder driver.
> > > + *
> > > + * Copyright (C) 2018-2019 Marek Vasut <marex@denx.de>
> > > + * Copyright (C) 2021 Michael Tretter <kernel@pengutronix.de>
> > > + */
> > > +
> > > +#include <linux/bitfield.h>
> > > +#include <linux/delay.h>
> > > +#include <linux/gpio.h>
> > > +#include <linux/i2c.h>
> > > +#include <linux/module.h>
> > > +#include <linux/of_graph.h>
> > > +#include <linux/pm_runtime.h>
> > > +#include <linux/regmap.h>
> > > +#include <linux/slab.h>
> > > +#include <linux/v4l2-mediabus.h>
> > > +#include <linux/videodev2.h>
> > > +
> > > +#include <media/v4l2-async.h>
> > > +#include <media/v4l2-common.h>
> > > +#include <media/v4l2-ctrls.h>
> > > +#include <media/v4l2-device.h>
> > > +#include <media/v4l2-fwnode.h>
> > > +#include <media/v4l2-ioctl.h>
> > > +
> > > +/*
> > > + * This control allows to activate and deactivate the test pattern on
> > > + * selected output channels.
> > > + * This value is ISL7998x specific.
> > > + */
> > > +#define V4L2_CID_TEST_PATTERN_CHANNELS	(V4L2_CID_USER_ISL7998X_BASE + 0)
> > > +
> > > +/*
> > > + * This control allows to specify the color of the test pattern.
> > > + * This value is ISL7998x specific.
> > > + */
> > > +#define V4L2_CID_TEST_PATTERN_COLOR	(V4L2_CID_USER_ISL7998X_BASE + 1)
> > > +
> > > +/*
> > > + * This control allows to specify the bar pattern in the test pattern.
> > > + * This value is ISL7998x specific.
> > > + */
> > > +#define V4L2_CID_TEST_PATTERN_BARS	(V4L2_CID_USER_ISL7998X_BASE + 2)
> > > +
> > > +#define ISL7998x_INPUTS			4
> > > +
> > > +#define ISL7998x_REG(page, reg)		(((page) << 8) | (reg))
> > > +
> > > +#define ISL7998x_REG_Pn_SIZE			256
> > > +#define ISL7998x_REG_Pn_BASE(n)			((n) * ISL7998x_REG_Pn_SIZE)
> > > +
> > > +#define ISL7998x_REG_Px_DEC_PAGE(page)		ISL7998x_REG((page), 0xff)
> > > +#define ISL7998x_REG_Px_DEC_PAGE_MASK		0xf
> > > +#define ISL7998x_REG_P0_PRODUCT_ID_CODE		ISL7998x_REG(0, 0x00)
> > > +#define ISL7998x_REG_P0_PRODUCT_REV_CODE	ISL7998x_REG(0, 0x01)
> > > +#define ISL7998x_REG_P0_SW_RESET_CTL		ISL7998x_REG(0, 0x02)
> > > +#define ISL7998x_REG_P0_IO_BUFFER_CTL		ISL7998x_REG(0, 0x03)
> > > +#define ISL7998x_REG_P0_IO_BUFFER_CTL_1_1	ISL7998x_REG(0, 0x04)
> > > +#define ISL7998x_REG_P0_IO_PAD_PULL_EN_CTL	ISL7998x_REG(0, 0x05)
> > > +#define ISL7998x_REG_P0_IO_BUFFER_CTL_1_2	ISL7998x_REG(0, 0x06)
> > > +#define ISL7998x_REG_P0_VIDEO_IN_CHAN_CTL	ISL7998x_REG(0, 0x07)
> > > +#define ISL7998x_REG_P0_CLK_CTL_1		ISL7998x_REG(0, 0x08)
> > > +#define ISL7998x_REG_P0_CLK_CTL_2		ISL7998x_REG(0, 0x09)
> > > +#define ISL7998x_REG_P0_CLK_CTL_3		ISL7998x_REG(0, 0x0a)
> > > +#define ISL7998x_REG_P0_CLK_CTL_4		ISL7998x_REG(0, 0x0b)
> > > +#define ISL7998x_REG_P0_MPP1_SYNC_CTL		ISL7998x_REG(0, 0x0c)
> > > +#define ISL7998x_REG_P0_MPP2_SYNC_CTL		ISL7998x_REG(0, 0x0d)
> > > +#define ISL7998x_REG_P0_IRQ_SYNC_CTL		ISL7998x_REG(0, 0x0e)
> > > +#define ISL7998x_REG_P0_INTERRUPT_STATUS	ISL7998x_REG(0, 0x10)
> > > +#define ISL7998x_REG_P0_CHAN_1_IRQ		ISL7998x_REG(0, 0x11)
> > > +#define ISL7998x_REG_P0_CHAN_2_IRQ		ISL7998x_REG(0, 0x12)
> > > +#define ISL7998x_REG_P0_CHAN_3_IRQ		ISL7998x_REG(0, 0x13)
> > > +#define ISL7998x_REG_P0_CHAN_4_IRQ		ISL7998x_REG(0, 0x14)
> > > +#define ISL7998x_REG_P0_SHORT_DIAG_IRQ		ISL7998x_REG(0, 0x15)
> > > +#define ISL7998x_REG_P0_CHAN_1_IRQ_EN		ISL7998x_REG(0, 0x16)
> > > +#define ISL7998x_REG_P0_CHAN_2_IRQ_EN		ISL7998x_REG(0, 0x17)
> > > +#define ISL7998x_REG_P0_CHAN_3_IRQ_EN		ISL7998x_REG(0, 0x18)
> > > +#define ISL7998x_REG_P0_CHAN_4_IRQ_EN		ISL7998x_REG(0, 0x19)
> > > +#define ISL7998x_REG_P0_SHORT_DIAG_IRQ_EN	ISL7998x_REG(0, 0x1a)
> > > +#define ISL7998x_REG_P0_CHAN_1_STATUS		ISL7998x_REG(0, 0x1b)
> > > +#define ISL7998x_REG_P0_CHAN_2_STATUS		ISL7998x_REG(0, 0x1c)
> > > +#define ISL7998x_REG_P0_CHAN_3_STATUS		ISL7998x_REG(0, 0x1d)
> > > +#define ISL7998x_REG_P0_CHAN_4_STATUS		ISL7998x_REG(0, 0x1e)
> > > +#define ISL7998x_REG_P0_SHORT_DIAG_STATUS	ISL7998x_REG(0, 0x1f)
> > > +#define ISL7998x_REG_P0_CLOCK_DELAY		ISL7998x_REG(0, 0x20)
> > > +
> > > +#define ISL7998x_REG_Px_DEC_INPUT_FMT(pg)	ISL7998x_REG((pg), 0x02)
> > > +#define ISL7998x_REG_Px_DEC_STATUS_1(pg)	ISL7998x_REG((pg), 0x03)
> > > +#define ISL7998x_REG_Px_DEC_STATUS_1_VDLOSS	BIT(7)
> > > +#define ISL7998x_REG_Px_DEC_STATUS_1_HLOCK	BIT(6)
> > > +#define ISL7998x_REG_Px_DEC_STATUS_1_VLOCK	BIT(3)
> > > +#define ISL7998x_REG_Px_DEC_HS_DELAY_CTL(pg)	ISL7998x_REG((pg), 0x04)
> > > +#define ISL7998x_REG_Px_DEC_ANCTL(pg)		ISL7998x_REG((pg), 0x06)
> > > +#define ISL7998x_REG_Px_DEC_CROP_HI(pg)		ISL7998x_REG((pg), 0x07)
> > > +#define ISL7998x_REG_Px_DEC_VDELAY_LO(pg)	ISL7998x_REG((pg), 0x08)
> > > +#define ISL7998x_REG_Px_DEC_VACTIVE_LO(pg)	ISL7998x_REG((pg), 0x09)
> > > +#define ISL7998x_REG_Px_DEC_HDELAY_LO(pg)	ISL7998x_REG((pg), 0x0a)
> > > +#define ISL7998x_REG_Px_DEC_HACTIVE_LO(pg)	ISL7998x_REG((pg), 0x0b)
> > > +#define ISL7998x_REG_Px_DEC_CNTRL1(pg)		ISL7998x_REG((pg), 0x0c)
> > > +#define ISL7998x_REG_Px_DEC_CSC_CTL(pg)		ISL7998x_REG((pg), 0x0d)
> > > +#define ISL7998x_REG_Px_DEC_BRIGHT(pg)		ISL7998x_REG((pg), 0x10)
> > > +#define ISL7998x_REG_Px_DEC_CONTRAST(pg)	ISL7998x_REG((pg), 0x11)
> > > +#define ISL7998x_REG_Px_DEC_SHARPNESS(pg)	ISL7998x_REG((pg), 0x12)
> > > +#define ISL7998x_REG_Px_DEC_SAT_U(pg)		ISL7998x_REG((pg), 0x13)
> > > +#define ISL7998x_REG_Px_DEC_SAT_V(pg)		ISL7998x_REG((pg), 0x14)
> > > +#define ISL7998x_REG_Px_DEC_HUE(pg)		ISL7998x_REG((pg), 0x15)
> > > +#define ISL7998x_REG_Px_DEC_VERT_PEAK(pg)	ISL7998x_REG((pg), 0x17)
> > > +#define ISL7998x_REG_Px_DEC_CORING(pg)		ISL7998x_REG((pg), 0x18)
> > > +#define ISL7998x_REG_Px_DEC_SDT(pg)		ISL7998x_REG((pg), 0x1c)
> > > +#define ISL7998x_REG_Px_DEC_SDT_DET		BIT(7)
> > > +#define ISL7998x_REG_Px_DEC_SDT_NOW		GENMASK(6, 4)
> > > +#define ISL7998x_REG_Px_DEC_SDT_STANDARD	GENMASK(2, 0)
> > > +#define ISL7998x_REG_Px_DEC_SDTR(pg)		ISL7998x_REG((pg), 0x1d)
> > > +#define ISL7998x_REG_Px_DEC_SDTR_ATSTART	BIT(7)
> > > +#define ISL7998x_REG_Px_DEC_CLMPG(pg)		ISL7998x_REG((pg), 0x20)
> > > +#define ISL7998x_REG_Px_DEC_IAGC(pg)		ISL7998x_REG((pg), 0x21)
> > > +#define ISL7998x_REG_Px_DEC_AGCGAIN(pg)		ISL7998x_REG((pg), 0x22)
> > > +#define ISL7998x_REG_Px_DEC_PEAKWT(pg)		ISL7998x_REG((pg), 0x23)
> > > +#define ISL7998x_REG_Px_DEC_CLMPL(pg)		ISL7998x_REG((pg), 0x24)
> > > +#define ISL7998x_REG_Px_DEC_SYNCT(pg)		ISL7998x_REG((pg), 0x25)
> > > +#define ISL7998x_REG_Px_DEC_MISSCNT(pg)		ISL7998x_REG((pg), 0x26)
> > > +#define ISL7998x_REG_Px_DEC_PCLAMP(pg)		ISL7998x_REG((pg), 0x27)
> > > +#define ISL7998x_REG_Px_DEC_VERT_CTL_1(pg)	ISL7998x_REG((pg), 0x28)
> > > +#define ISL7998x_REG_Px_DEC_VERT_CTL_2(pg)	ISL7998x_REG((pg), 0x29)
> > > +#define ISL7998x_REG_Px_DEC_CLR_KILL_LVL(pg)	ISL7998x_REG((pg), 0x2a)
> > > +#define ISL7998x_REG_Px_DEC_COMB_FILTER_CTL(pg)	ISL7998x_REG((pg), 0x2b)
> > > +#define ISL7998x_REG_Px_DEC_LUMA_DELAY(pg)	ISL7998x_REG((pg), 0x2c)
> > > +#define ISL7998x_REG_Px_DEC_MISC1(pg)		ISL7998x_REG((pg), 0x2d)
> > > +#define ISL7998x_REG_Px_DEC_MISC2(pg)		ISL7998x_REG((pg), 0x2e)
> > > +#define ISL7998x_REG_Px_DEC_MISC3(pg)		ISL7998x_REG((pg), 0x2f)
> > > +#define ISL7998x_REG_Px_DEC_MVSN(pg)		ISL7998x_REG((pg), 0x30)
> > > +#define ISL7998x_REG_Px_DEC_CSTATUS2(pg)	ISL7998x_REG((pg), 0x31)
> > > +#define ISL7998x_REG_Px_DEC_HFREF(pg)		ISL7998x_REG((pg), 0x32)
> > > +#define ISL7998x_REG_Px_DEC_CLMD(pg)		ISL7998x_REG((pg), 0x33)
> > > +#define ISL7998x_REG_Px_DEC_ID_DET_CTL(pg)	ISL7998x_REG((pg), 0x34)
> > > +#define ISL7998x_REG_Px_DEC_CLCNTL(pg)		ISL7998x_REG((pg), 0x35)
> > > +#define ISL7998x_REG_Px_DEC_DIFF_CLMP_CTL_1(pg)	ISL7998x_REG((pg), 0x36)
> > > +#define ISL7998x_REG_Px_DEC_DIFF_CLMP_CTL_2(pg)	ISL7998x_REG((pg), 0x37)
> > > +#define ISL7998x_REG_Px_DEC_DIFF_CLMP_CTL_3(pg)	ISL7998x_REG((pg), 0x38)
> > > +#define ISL7998x_REG_Px_DEC_DIFF_CLMP_CTL_4(pg)	ISL7998x_REG((pg), 0x39)
> > > +#define ISL7998x_REG_Px_DEC_SHORT_DET_CTL(pg)	ISL7998x_REG((pg), 0x3a)
> > > +#define ISL7998x_REG_Px_DEC_SHORT_DET_CTL_1(pg)	ISL7998x_REG((pg), 0x3b)
> > > +#define ISL7998x_REG_Px_DEC_AFE_TST_MUX_CTL(pg)	ISL7998x_REG((pg), 0x3c)
> > > +#define ISL7998x_REG_Px_DEC_DATA_CONV(pg)	ISL7998x_REG((pg), 0x3d)
> > > +#define ISL7998x_REG_Px_DEC_INTERNAL_TEST(pg)	ISL7998x_REG((pg), 0x3f)
> > > +#define ISL7998x_REG_Px_DEC_H_DELAY_CTL(pg)	ISL7998x_REG((pg), 0x43)
> > > +#define ISL7998x_REG_Px_DEC_H_DELAY_II_HI(pg)	ISL7998x_REG((pg), 0x44)
> > > +#define ISL7998x_REG_Px_DEC_H_DELAY_II_LOW(pg)	ISL7998x_REG((pg), 0x45)
> > > +
> > > +#define ISL7998x_REG_Px_ACA_CTL_1(pg)		ISL7998x_REG((pg), 0x80)
> > > +#define ISL7998x_REG_Px_ACA_GAIN_CTL(pg)	ISL7998x_REG((pg), 0x81)
> > > +#define ISL7998x_REG_Px_ACA_Y_AVG_HI_LIMIT(pg)	ISL7998x_REG((pg), 0x82)
> > > +#define ISL7998x_REG_Px_ACA_Y_AVG_LO_LIMIT(pg)	ISL7998x_REG((pg), 0x83)
> > > +#define ISL7998x_REG_Px_ACA_Y_DET_THRESHOLD(pg)	ISL7998x_REG((pg), 0x84)
> > > +#define ISL7998x_REG_Px_ACA_BLACK_LVL(pg)	ISL7998x_REG((pg), 0x85)
> > > +#define ISL7998x_REG_Px_ACA_CENTER_LVL(pg)	ISL7998x_REG((pg), 0x86)
> > > +#define ISL7998x_REG_Px_ACA_WHITE_LVL(pg)	ISL7998x_REG((pg), 0x87)
> > > +#define ISL7998x_REG_Px_ACA_MEAN_OFF_LIMIT(pg)	ISL7998x_REG((pg), 0x88)
> > > +#define ISL7998x_REG_Px_ACA_MEAN_OFF_UPGAIN(pg)	ISL7998x_REG((pg), 0x89)
> > > +#define ISL7998x_REG_Px_ACA_MEAN_OFF_SLOPE(pg)	ISL7998x_REG((pg), 0x8a)
> > > +#define ISL7998x_REG_Px_ACA_MEAN_OFF_DNGAIN(pg)	ISL7998x_REG((pg), 0x8b)
> > > +#define ISL7998x_REG_Px_ACA_DELTA_CO_THRES(pg)	ISL7998x_REG((pg), 0x8c)
> > > +#define ISL7998x_REG_Px_ACA_DELTA_SLOPE(pg)	ISL7998x_REG((pg), 0x8d)
> > > +#define ISL7998x_REG_Px_ACA_LO_HI_AVG_THRES(pg)	ISL7998x_REG((pg), 0x8e)
> > > +#define ISL7998x_REG_Px_ACA_LO_MAX_LVL_CTL(pg)	ISL7998x_REG((pg), 0x8f)
> > > +#define ISL7998x_REG_Px_ACA_HI_MAX_LVL_CTL(pg)	ISL7998x_REG((pg), 0x90)
> > > +#define ISL7998x_REG_Px_ACA_LO_UPGAIN_CTL(pg)	ISL7998x_REG((pg), 0x91)
> > > +#define ISL7998x_REG_Px_ACA_LO_DNGAIN_CTL(pg)	ISL7998x_REG((pg), 0x92)
> > > +#define ISL7998x_REG_Px_ACA_HI_UPGAIN_CTL(pg)	ISL7998x_REG((pg), 0x93)
> > > +#define ISL7998x_REG_Px_ACA_HI_DNGAIN_CTL(pg)	ISL7998x_REG((pg), 0x94)
> > > +#define ISL7998x_REG_Px_ACA_LOPASS_FLT_COEF(pg)	ISL7998x_REG((pg), 0x95)
> > > +#define ISL7998x_REG_Px_ACA_PDF_INDEX(pg)	ISL7998x_REG((pg), 0x96)
> > > +#define ISL7998x_REG_Px_ACA_HIST_WIN_H_STT(pg)	ISL7998x_REG((pg), 0x97)
> > > +#define ISL7998x_REG_Px_ACA_HIST_WIN_H_SZ1(pg)	ISL7998x_REG((pg), 0x98)
> > > +#define ISL7998x_REG_Px_ACA_HIST_WIN_H_SZ2(pg)	ISL7998x_REG((pg), 0x99)
> > > +#define ISL7998x_REG_Px_ACA_HIST_WIN_V_STT(pg)	ISL7998x_REG((pg), 0x9a)
> > > +#define ISL7998x_REG_Px_ACA_HIST_WIN_V_SZ1(pg)	ISL7998x_REG((pg), 0x9b)
> > > +#define ISL7998x_REG_Px_ACA_HIST_WIN_V_SZ2(pg)	ISL7998x_REG((pg), 0x9c)
> > > +#define ISL7998x_REG_Px_ACA_Y_AVG(pg)		ISL7998x_REG((pg), 0xa0)
> > > +#define ISL7998x_REG_Px_ACA_Y_AVG_LIM(pg)	ISL7998x_REG((pg), 0xa1)
> > > +#define ISL7998x_REG_Px_ACA_LO_AVG(pg)		ISL7998x_REG((pg), 0xa2)
> > > +#define ISL7998x_REG_Px_ACA_HI_AVG(pg)		ISL7998x_REG((pg), 0xa3)
> > > +#define ISL7998x_REG_Px_ACA_Y_MAX(pg)		ISL7998x_REG((pg), 0xa4)
> > > +#define ISL7998x_REG_Px_ACA_Y_MIN(pg)		ISL7998x_REG((pg), 0xa5)
> > > +#define ISL7998x_REG_Px_ACA_MOFFSET(pg)		ISL7998x_REG((pg), 0xa6)
> > > +#define ISL7998x_REG_Px_ACA_LO_GAIN(pg)		ISL7998x_REG((pg), 0xa7)
> > > +#define ISL7998x_REG_Px_ACA_HI_GAIN(pg)		ISL7998x_REG((pg), 0xa8)
> > > +#define ISL7998x_REG_Px_ACA_LL_SLOPE(pg)	ISL7998x_REG((pg), 0xa9)
> > > +#define ISL7998x_REG_Px_ACA_LH_SLOPE(pg)	ISL7998x_REG((pg), 0xaa)
> > > +#define ISL7998x_REG_Px_ACA_HL_SLOPE(pg)	ISL7998x_REG((pg), 0xab)
> > > +#define ISL7998x_REG_Px_ACA_HH_SLOPE(pg)	ISL7998x_REG((pg), 0xac)
> > > +#define ISL7998x_REG_Px_ACA_X_LOW(pg)		ISL7998x_REG((pg), 0xad)
> > > +#define ISL7998x_REG_Px_ACA_X_MEAN(pg)		ISL7998x_REG((pg), 0xae)
> > > +#define ISL7998x_REG_Px_ACA_X_HIGH(pg)		ISL7998x_REG((pg), 0xaf)
> > > +#define ISL7998x_REG_Px_ACA_Y_LOW(pg)		ISL7998x_REG((pg), 0xb0)
> > > +#define ISL7998x_REG_Px_ACA_Y_MEAN(pg)		ISL7998x_REG((pg), 0xb1)
> > > +#define ISL7998x_REG_Px_ACA_Y_HIGH(pg)		ISL7998x_REG((pg), 0xb2)
> > > +#define ISL7998x_REG_Px_ACA_CTL_2(pg)		ISL7998x_REG((pg), 0xb3)
> > > +#define ISL7998x_REG_Px_ACA_CTL_3(pg)		ISL7998x_REG((pg), 0xb4)
> > > +#define ISL7998x_REG_Px_ACA_CTL_4(pg)		ISL7998x_REG((pg), 0xb5)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_HIST(pg)	ISL7998x_REG((pg), 0xc0)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_TL_H(pg)	ISL7998x_REG((pg), 0xc1)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_TL_L(pg)	ISL7998x_REG((pg), 0xc2)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_TL_H(pg)	ISL7998x_REG((pg), 0xc3)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_TL_L(pg)	ISL7998x_REG((pg), 0xc4)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_TR_H(pg)	ISL7998x_REG((pg), 0xc5)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_TR_L(pg)	ISL7998x_REG((pg), 0xc6)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_TR_H(pg)	ISL7998x_REG((pg), 0xc7)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_TR_L(pg)	ISL7998x_REG((pg), 0xc8)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_BL_H(pg)	ISL7998x_REG((pg), 0xc9)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_BL_L(pg)	ISL7998x_REG((pg), 0xca)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_BL_H(pg)	ISL7998x_REG((pg), 0xcb)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_BL_L(pg)	ISL7998x_REG((pg), 0xcc)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_BR_H(pg)	ISL7998x_REG((pg), 0xcd)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_BR_L(pg)	ISL7998x_REG((pg), 0xce)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_BR_H(pg)	ISL7998x_REG((pg), 0xcf)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_BR_L(pg)	ISL7998x_REG((pg), 0xd0)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_LM_H(pg)	ISL7998x_REG((pg), 0xd1)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_LM_L(pg)	ISL7998x_REG((pg), 0xd2)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_LM_H(pg)	ISL7998x_REG((pg), 0xd3)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_LM_L(pg)	ISL7998x_REG((pg), 0xd4)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_TM_H(pg)	ISL7998x_REG((pg), 0xd5)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_TM_L(pg)	ISL7998x_REG((pg), 0xd6)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_TM_H(pg)	ISL7998x_REG((pg), 0xd7)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_TM_L(pg)	ISL7998x_REG((pg), 0xd8)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_BM_H(pg)	ISL7998x_REG((pg), 0xd9)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_BM_L(pg)	ISL7998x_REG((pg), 0xda)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_BM_H(pg)	ISL7998x_REG((pg), 0xdb)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_BM_L(pg)	ISL7998x_REG((pg), 0xdc)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_RM_H(pg)	ISL7998x_REG((pg), 0xdd)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_X_RM_L(pg)	ISL7998x_REG((pg), 0xde)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_RM_H(pg)	ISL7998x_REG((pg), 0xdf)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_RM_L(pg)	ISL7998x_REG((pg), 0xe0)
> > > +#define ISL7998x_REG_Px_ACA_HIST_DATA_LO(pg)	ISL7998x_REG((pg), 0xe1)
> > > +#define ISL7998x_REG_Px_ACA_HIST_DATA_MID(pg)	ISL7998x_REG((pg), 0xe2)
> > > +#define ISL7998x_REG_Px_ACA_HIST_DATA_HI(pg)	ISL7998x_REG((pg), 0xe3)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_Y_CLR(pg)	ISL7998x_REG((pg), 0xe4)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_CB_CLR(pg)	ISL7998x_REG((pg), 0xe5)
> > > +#define ISL7998x_REG_Px_ACA_FLEX_WIN_CR_CLR(pg)	ISL7998x_REG((pg), 0xe6)
> > > +#define ISL7998x_REG_Px_ACA_XFER_HIST_HOST(pg)	ISL7998x_REG((pg), 0xe7)
> > > +
> > > +#define ISL7998x_REG_P5_LI_ENGINE_CTL		ISL7998x_REG(5, 0x00)
> > > +#define ISL7998x_REG_P5_LI_ENGINE_LINE_CTL	ISL7998x_REG(5, 0x01)
> > > +#define ISL7998x_REG_P5_LI_ENGINE_PIC_WIDTH	ISL7998x_REG(5, 0x02)
> > > +#define ISL7998x_REG_P5_LI_ENGINE_SYNC_CTL	ISL7998x_REG(5, 0x03)
> > > +#define ISL7998x_REG_P5_LI_ENGINE_VC_ASSIGNMENT	ISL7998x_REG(5, 0x04)
> > > +#define ISL7998x_REG_P5_LI_ENGINE_TYPE_CTL	ISL7998x_REG(5, 0x05)
> > > +#define ISL7998x_REG_P5_LI_ENGINE_FIFO_CTL	ISL7998x_REG(5, 0x06)
> > > +#define ISL7998x_REG_P5_MIPI_READ_START_CTL	ISL7998x_REG(5, 0x07)
> > > +#define ISL7998x_REG_P5_PSEUDO_FRM_FIELD_CTL	ISL7998x_REG(5, 0x08)
> > > +#define ISL7998x_REG_P5_ONE_FIELD_MODE_CTL	ISL7998x_REG(5, 0x09)
> > > +#define ISL7998x_REG_P5_MIPI_INT_HW_TST_CTR	ISL7998x_REG(5, 0x0a)
> > > +#define ISL7998x_REG_P5_TP_GEN_BAR_PATTERN	ISL7998x_REG(5, 0x0b)
> > > +#define ISL7998x_REG_P5_MIPI_PCNT_PSFRM		ISL7998x_REG(5, 0x0c)
> > > +#define ISL7998x_REG_P5_LI_ENGINE_TP_GEN_CTL	ISL7998x_REG(5, 0x0d)
> > > +#define ISL7998x_REG_P5_MIPI_VBLANK_PSFRM	ISL7998x_REG(5, 0x0e)
> > > +#define ISL7998x_REG_P5_LI_ENGINE_CTL_2		ISL7998x_REG(5, 0x0f)
> > > +#define ISL7998x_REG_P5_MIPI_WCNT_1		ISL7998x_REG(5, 0x10)
> > > +#define ISL7998x_REG_P5_MIPI_WCNT_2		ISL7998x_REG(5, 0x11)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_1	ISL7998x_REG(5, 0x12)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_2	ISL7998x_REG(5, 0x13)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_3	ISL7998x_REG(5, 0x14)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_4	ISL7998x_REG(5, 0x15)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_5	ISL7998x_REG(5, 0x16)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_6	ISL7998x_REG(5, 0x17)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_PARAMS_1	ISL7998x_REG(5, 0x18)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_SOT_PERIOD	ISL7998x_REG(5, 0x19)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_EOT_PERIOD	ISL7998x_REG(5, 0x1a)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_PARAMS_2	ISL7998x_REG(5, 0x1b)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_7	ISL7998x_REG(5, 0x1c)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_8	ISL7998x_REG(5, 0x1d)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_9	ISL7998x_REG(5, 0x1e)
> > > +#define ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_10	ISL7998x_REG(5, 0x1f)
> > > +#define ISL7998x_REG_P5_TP_GEN_MIPI		ISL7998x_REG(5, 0x20)
> > > +#define ISL7998x_REG_P5_ESC_MODE_TIME_CTL	ISL7998x_REG(5, 0x21)
> > > +#define ISL7998x_REG_P5_AUTO_TEST_ERR_DET	ISL7998x_REG(5, 0x22)
> > > +#define ISL7998x_REG_P5_MIPI_TIMING		ISL7998x_REG(5, 0x23)
> > > +#define ISL7998x_REG_P5_PIC_HEIGHT_HIGH		ISL7998x_REG(5, 0x24)
> > > +#define ISL7998x_REG_P5_PIC_HEIGHT_LOW		ISL7998x_REG(5, 0x25)
> > > +#define ISL7998x_REG_P5_MIPI_SP_HS_TRL_CTL	ISL7998x_REG(5, 0x26)
> > > +#define ISL7998x_REG_P5_FIFO_THRSH_CNT_1	ISL7998x_REG(5, 0x28)
> > > +#define ISL7998x_REG_P5_FIFO_THRSH_CNT_2	ISL7998x_REG(5, 0x29)
> > > +#define ISL7998x_REG_P5_TP_GEN_RND_SYNC_CTL_1	ISL7998x_REG(5, 0x2a)
> > > +#define ISL7998x_REG_P5_TP_GEN_RND_SYNC_CTL_2	ISL7998x_REG(5, 0x2b)
> > > +#define ISL7998x_REG_P5_PSF_FIELD_END_CTL_1	ISL7998x_REG(5, 0x2c)
> > > +#define ISL7998x_REG_P5_PSF_FIELD_END_CTL_2	ISL7998x_REG(5, 0x2d)
> > > +#define ISL7998x_REG_P5_PSF_FIELD_END_CTL_3	ISL7998x_REG(5, 0x2e)
> > > +#define ISL7998x_REG_P5_PSF_FIELD_END_CTL_4	ISL7998x_REG(5, 0x2f)
> > > +#define ISL7998x_REG_P5_MIPI_ANA_DATA_CTL_1	ISL7998x_REG(5, 0x30)
> > > +#define ISL7998x_REG_P5_MIPI_ANA_DATA_CTL_2	ISL7998x_REG(5, 0x31)
> > > +#define ISL7998x_REG_P5_MIPI_ANA_CLK_CTL	ISL7998x_REG(5, 0x32)
> > > +#define ISL7998x_REG_P5_PLL_ANA_STATUS		ISL7998x_REG(5, 0x33)
> > > +#define ISL7998x_REG_P5_PLL_ANA_MISC_CTL	ISL7998x_REG(5, 0x34)
> > > +#define ISL7998x_REG_P5_MIPI_ANA		ISL7998x_REG(5, 0x35)
> > > +#define ISL7998x_REG_P5_PLL_ANA			ISL7998x_REG(5, 0x36)
> > > +#define ISL7998x_REG_P5_TOTAL_PF_LINE_CNT_1	ISL7998x_REG(5, 0x38)
> > > +#define ISL7998x_REG_P5_TOTAL_PF_LINE_CNT_2	ISL7998x_REG(5, 0x39)
> > > +#define ISL7998x_REG_P5_H_LINE_CNT_1		ISL7998x_REG(5, 0x3a)
> > > +#define ISL7998x_REG_P5_H_LINE_CNT_2		ISL7998x_REG(5, 0x3b)
> > > +#define ISL7998x_REG_P5_HIST_LINE_CNT_1		ISL7998x_REG(5, 0x3c)
> > > +#define ISL7998x_REG_P5_HIST_LINE_CNT_2		ISL7998x_REG(5, 0x3d)
> > > +
> > > +static const struct reg_sequence isl7998x_init_seq_1[] = {
> > > +	{ ISL7998x_REG_P0_SHORT_DIAG_IRQ_EN, 0xff },
> > > +	{ ISL7998x_REG_Px_DEC_SDT(0x1), 0x00 },
> > > +	{ ISL7998x_REG_Px_DEC_SHORT_DET_CTL_1(0x1), 0x03 },
> > > +	{ ISL7998x_REG_Px_DEC_SDT(0x2), 0x00 },
> > > +	{ ISL7998x_REG_Px_DEC_SHORT_DET_CTL_1(0x2), 0x03 },
> > > +	{ ISL7998x_REG_Px_DEC_SDT(0x3), 0x00 },
> > > +	{ ISL7998x_REG_Px_DEC_SHORT_DET_CTL_1(0x3), 0x03 },
> > > +	{ ISL7998x_REG_Px_DEC_SDT(0x4), 0x00 },
> > > +	{ ISL7998x_REG_Px_DEC_SHORT_DET_CTL_1(0x4), 0x03 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_CTL, 0x00 },
> > > +	{ ISL7998x_REG_P0_SW_RESET_CTL, 0x1f, 10 },
> > > +	{ ISL7998x_REG_P0_IO_BUFFER_CTL, 0x00 },
> > > +	{ ISL7998x_REG_P0_MPP2_SYNC_CTL, 0xc9 },
> > > +	{ ISL7998x_REG_P0_IRQ_SYNC_CTL, 0xc9 },
> > > +	{ ISL7998x_REG_P0_CHAN_1_IRQ, 0x03 },
> > > +	{ ISL7998x_REG_P0_CHAN_2_IRQ, 0x00 },
> > > +	{ ISL7998x_REG_P0_CHAN_3_IRQ, 0x00 },
> > > +	{ ISL7998x_REG_P0_CHAN_4_IRQ, 0x00 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_CTL, 0x02 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_LINE_CTL, 0x85 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_PIC_WIDTH, 0xa0 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_SYNC_CTL, 0x18 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_TYPE_CTL, 0x40 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_FIFO_CTL, 0x40 },
> > > +	{ ISL7998x_REG_P5_MIPI_WCNT_1, 0x05 },
> > > +	{ ISL7998x_REG_P5_MIPI_WCNT_2, 0xa0 },
> > > +	{ ISL7998x_REG_P5_TP_GEN_MIPI, 0x00 },
> > > +	{ ISL7998x_REG_P5_ESC_MODE_TIME_CTL, 0x0c },
> > > +	{ ISL7998x_REG_P5_MIPI_SP_HS_TRL_CTL, 0x00 },
> > > +	{ ISL7998x_REG_P5_TP_GEN_RND_SYNC_CTL_1, 0x00 },
> > > +	{ ISL7998x_REG_P5_TP_GEN_RND_SYNC_CTL_2, 0x19 },
> > > +	{ ISL7998x_REG_P5_PSF_FIELD_END_CTL_1, 0x18 },
> > > +	{ ISL7998x_REG_P5_PSF_FIELD_END_CTL_2, 0xf1 },
> > > +	{ ISL7998x_REG_P5_PSF_FIELD_END_CTL_3, 0x00 },
> > > +	{ ISL7998x_REG_P5_PSF_FIELD_END_CTL_4, 0xf1 },
> > > +	{ ISL7998x_REG_P5_MIPI_ANA_DATA_CTL_1, 0x00 },
> > > +	{ ISL7998x_REG_P5_MIPI_ANA_DATA_CTL_2, 0x00 },
> > > +	{ ISL7998x_REG_P5_MIPI_ANA_CLK_CTL, 0x00 },
> > > +	{ ISL7998x_REG_P5_PLL_ANA_STATUS, 0xc0 },
> > > +	{ ISL7998x_REG_P5_PLL_ANA_MISC_CTL, 0x18 },
> > > +	{ ISL7998x_REG_P5_PLL_ANA, 0x00 },
> > > +	{ ISL7998x_REG_P0_SW_RESET_CTL, 0x10, 10 },
> > > +	/* Page 0xf means write to all of pages 1,2,3,4 */
> > > +	{ ISL7998x_REG_Px_DEC_VDELAY_LO(0xf), 0x14 },
> > > +	{ ISL7998x_REG_Px_DEC_MISC3(0xf), 0xe6 },
> > > +	{ ISL7998x_REG_Px_DEC_CLMD(0xf), 0x85 },
> > > +	{ ISL7998x_REG_Px_DEC_H_DELAY_II_LOW(0xf), 0x11 },
> > > +	{ ISL7998x_REG_Px_ACA_XFER_HIST_HOST(0xf), 0x00 },
> > > +	{ ISL7998x_REG_P0_CLK_CTL_1, 0x1f },
> > > +	{ ISL7998x_REG_P0_CLK_CTL_2, 0x43 },
> > > +	{ ISL7998x_REG_P0_CLK_CTL_3, 0x4f },
> > > +};
> > > +
> > > +static const struct reg_sequence isl7998x_init_seq_2[] = {
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_SYNC_CTL, 0x10 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_VC_ASSIGNMENT, 0xe4 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_TYPE_CTL, 0x00 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_FIFO_CTL, 0x60 },
> > > +	{ ISL7998x_REG_P5_MIPI_READ_START_CTL, 0x2b },
> > > +	{ ISL7998x_REG_P5_PSEUDO_FRM_FIELD_CTL, 0x02 },
> > > +	{ ISL7998x_REG_P5_ONE_FIELD_MODE_CTL, 0x00 },
> > > +	{ ISL7998x_REG_P5_MIPI_INT_HW_TST_CTR, 0x62 },
> > > +	{ ISL7998x_REG_P5_TP_GEN_BAR_PATTERN, 0x02 },
> > > +	{ ISL7998x_REG_P5_MIPI_PCNT_PSFRM, 0x36 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_TP_GEN_CTL, 0x00 },
> > > +	{ ISL7998x_REG_P5_MIPI_VBLANK_PSFRM, 0x6c },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_CTL_2, 0x00 },
> > > +	{ ISL7998x_REG_P5_MIPI_WCNT_1, 0x05 },
> > > +	{ ISL7998x_REG_P5_MIPI_WCNT_2, 0xa0 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_1, 0x77 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_2, 0x17 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_3, 0x08 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_4, 0x38 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_5, 0x14 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_6, 0xf6 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_PARAMS_1, 0x00 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_SOT_PERIOD, 0x17 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_EOT_PERIOD, 0x0a },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_PARAMS_2, 0x71 },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_7, 0x7a },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_8, 0x0f },
> > > +	{ ISL7998x_REG_P5_MIPI_DPHY_TIMING_CTL_9, 0x8c },
> > > +	{ ISL7998x_REG_P5_MIPI_SP_HS_TRL_CTL, 0x08 },
> > > +	{ ISL7998x_REG_P5_FIFO_THRSH_CNT_1, 0x01 },
> > > +	{ ISL7998x_REG_P5_FIFO_THRSH_CNT_2, 0x0e },
> > > +	{ ISL7998x_REG_P5_TP_GEN_RND_SYNC_CTL_1, 0x00 },
> > > +	{ ISL7998x_REG_P5_TP_GEN_RND_SYNC_CTL_2, 0x00 },
> > > +	{ ISL7998x_REG_P5_TOTAL_PF_LINE_CNT_1, 0x03 },
> > > +	{ ISL7998x_REG_P5_TOTAL_PF_LINE_CNT_2, 0xc0 },
> > > +	{ ISL7998x_REG_P5_H_LINE_CNT_1, 0x06 },
> > > +	{ ISL7998x_REG_P5_H_LINE_CNT_2, 0xb3 },
> > > +	{ ISL7998x_REG_P5_HIST_LINE_CNT_1, 0x00 },
> > > +	{ ISL7998x_REG_P5_HIST_LINE_CNT_2, 0xf1 },
> > > +	{ ISL7998x_REG_P5_LI_ENGINE_FIFO_CTL, 0x00 },
> > > +	{ ISL7998x_REG_P5_MIPI_ANA, 0x00 },
> > > +	/*
> > > +	 * Wait a bit after reset so that the chip can capture a frame
> > > +	 * and update internal line counters.
> > > +	 */
> > > +	{ ISL7998x_REG_P0_SW_RESET_CTL, 0x00, 50 },
> > > +};
> > > +
> > > +enum isl7998x_pads {
> > > +	ISL7998x_PAD_OUT,
> > > +	ISL7998x_PAD_VIN1,
> > > +	ISL7998x_PAD_VIN2,
> > > +	ISL7998x_PAD_VIN3,
> > > +	ISL7998x_PAD_VIN4,
> > > +	ISL7998x_NUM_PADS
> > > +};
> > > +
> > > +struct isl7998x_datafmt {
> > > +	u32			code;
> > > +	enum v4l2_colorspace	colorspace;
> > > +};
> > > +
> > > +static const struct isl7998x_datafmt isl7998x_colour_fmts[] = {
> > > +	{ MEDIA_BUS_FMT_UYVY8_2X8, V4L2_COLORSPACE_SRGB },
> > > +};
> > > +
> > > +/* Menu items for LINK_FREQ V4L2 control */
> > > +static const s64 link_freq_menu_items[] = {
> > > +	/* 1 channel, 1 lane or 2 channels, 2 lanes */
> > > +	108000000,
> > > +	/* 2 channels, 1 lane or 4 channels, 2 lanes */
> > > +	216000000,
> > > +	/* 4 channels, 1 lane */
> > > +	432000000,
> > > +};
> > > +
> > > +/* Menu items for TEST_PATTERN V4L2 control */
> > > +static const char * const isl7998x_test_pattern_menu[] = {
> > > +	"Disabled",
> > > +	"Enabled",
> > > +};
> > > +
> > > +static const char * const isl7998x_test_pattern_bars[] = {
> > > +	"bbbbwb", "bbbwwb", "bbwbwb", "bbwwwb",
> > > +};
> > > +
> > > +static const char * const isl7998x_test_pattern_colors[] = {
> > > +	"Yellow", "Blue", "Green", "Pink",
> > > +};
> > > +
> > > +struct isl7998x_mode {
> > > +	unsigned int width;
> > > +	unsigned int height;
> > > +	enum v4l2_field field;
> > > +};
> > > +
> > > +static const struct isl7998x_mode supported_modes[] = {
> > > +	{
> > > +		.width = 720,
> > > +		.height = 576,
> > > +		.field = V4L2_FIELD_SEQ_TB,
> > > +	},
> > > +	{
> > > +		.width = 720,
> > > +		.height = 480,
> > > +		.field = V4L2_FIELD_SEQ_BT,
> > > +	},
> > > +};
> > > +
> > > +static const struct isl7998x_video_std {
> > > +	unsigned int id;
> > > +	const struct isl7998x_mode *mode;
> > > +	const v4l2_std_id norm;
> > > +} isl7998x_std_res[] = {
> > > +	{ 0, &supported_modes[1], V4L2_STD_NTSC},
> > > +	{ 1, &supported_modes[0], V4L2_STD_PAL},
> > > +	{ 2, &supported_modes[0], V4L2_STD_SECAM},
> > > +	{ 3, &supported_modes[1], V4L2_STD_NTSC_443},
> > > +	{ 4, &supported_modes[1], V4L2_STD_PAL_M},
> > > +	{ 5, &supported_modes[0], V4L2_STD_PAL_N},
> > > +	{ 6, &supported_modes[1], V4L2_STD_PAL_60},  
> > 
> > Please reorder it, placing the generic ones (NTSC, PAL, SECAM)
> > at the end, as those are bitmasks, where PAL M/N/60 and NTSC/443
> > has just one bit set, and the other ones cover several different
> > standards.  
> 
> Ack.
> 
> >   
> > > +	{ 7, NULL, V4L2_STD_UNKNOWN},
> > > +};
> > > +
> > > +struct isl7998x {
> > > +	struct v4l2_subdev		subdev;
> > > +	struct regmap			*regmap;
> > > +	struct gpio_desc		*pd_gpio;
> > > +	struct gpio_desc		*rstb_gpio;
> > > +	unsigned int			nr_mipi_lanes;
> > > +	u32				nr_inputs;
> > > +
> > > +	const struct isl7998x_datafmt	*fmt;
> > > +	v4l2_std_id			norm;
> > > +	struct media_pad		pads[ISL7998x_NUM_PADS];
> > > +
> > > +	int				enabled;
> > > +
> > > +	struct v4l2_ctrl_handler	ctrl_handler;
> > > +	/* protect ctrl_handler */
> > > +	struct mutex			ctrl_mutex;
> > > +
> > > +	/* V4L2 Controls */
> > > +	struct v4l2_ctrl		*link_freq;
> > > +	u8				test_pattern;
> > > +	u8				test_pattern_bars;
> > > +	u8				test_pattern_chans;
> > > +	u8				test_pattern_color;
> > > +};
> > > +
> > > +static struct isl7998x *sd_to_isl7998x(struct v4l2_subdev *sd)
> > > +{
> > > +	return container_of(sd, struct isl7998x, subdev);
> > > +}
> > > +
> > > +static struct isl7998x *i2c_to_isl7998x(const struct i2c_client *client)
> > > +{
> > > +	return sd_to_isl7998x(i2c_get_clientdata(client));
> > > +}
> > > +
> > > +static unsigned int isl7998x_norm_to_val(v4l2_std_id norm)
> > > +{
> > > +	unsigned int i;
> > > +
> > > +	for (i = 0; i < ARRAY_SIZE(isl7998x_std_res); i++)
> > > +		if (isl7998x_std_res[i].norm & norm)
> > > +			return isl7998x_std_res[i].id;
> > > +
> > > +	return 7;  
> > 
> > No! don't return a random number here. It is just too risky to maintain,
> > if someone ever add/remove something at std struct. Instead, I would
> > change the loop to:
> > 
> > 	for (i = 0; i < ARRAY_SIZE(isl7998x_std_res) - 1; i++)
> > 		if (isl7998x_std_res[i].norm & norm)
> > 			break;
> > 
> > 	return isl7998x_std_res[i].id;
> > 
> > Which would produce the same effect without having a magic number
> > on it.  
> 
> OK. The 7 is the same magic number as id 7 for V4L2_STD_UNKNOWN. I will
> rewrite the function and also add macros for the ids to make obvious, where
> the numbers come from.

Ok.

> 
> >   
> > > +}
> > > +
> > > +static const struct isl7998x_mode *isl7998x_get_mode(struct isl7998x *isl7998x)
> > > +{
> > > +	unsigned int i;
> > > +
> > > +	for (i = 0; i < ARRAY_SIZE(isl7998x_std_res); i++)
> > > +		if (isl7998x_std_res[i].norm & isl7998x->norm)
> > > +			return isl7998x_std_res[i].mode;
> > > +
> > > +	return NULL;
> > > +}
> > > +
> > > +static int isl7998x_get_nr_inputs(struct device_node *of_node)
> > > +{
> > > +	struct device_node *port;
> > > +	unsigned int inputs = 0;
> > > +	unsigned int i;
> > > +
> > > +	if (of_graph_get_endpoint_count(of_node) > ISL7998x_NUM_PADS)
> > > +		return -EINVAL;
> > > +
> > > +	/*
> > > +	 * The driver does not provide means to remap the input ports. It
> > > +	 * always configures input ports to start from VID1. Ensure that the
> > > +	 * device tree is correct.
> > > +	 */
> > > +	for (i = ISL7998x_PAD_VIN1; i <= ISL7998x_PAD_VIN4; i++) {
> > > +		port = of_graph_get_port_by_id(of_node, i);
> > > +		if (!port)
> > > +			continue;
> > > +
> > > +		inputs |= BIT(i);
> > > +		of_node_put(port);
> > > +	}
> > > +
> > > +	switch (inputs) {
> > > +	case BIT(ISL7998x_PAD_VIN1):
> > > +		return 1;
> > > +	case BIT(ISL7998x_PAD_VIN1) | BIT(ISL7998x_PAD_VIN2):
> > > +		return 2;
> > > +	case BIT(ISL7998x_PAD_VIN1) | BIT(ISL7998x_PAD_VIN2) |
> > > +	     BIT(ISL7998x_PAD_VIN3) | BIT(ISL7998x_PAD_VIN4):
> > > +		return 4;
> > > +	default:
> > > +		return -EINVAL;
> > > +	}
> > > +}
> > > +
> > > +static int isl7998x_wait_power_on(struct isl7998x *isl7998x)
> > > +{
> > > +	struct device *dev = isl7998x->subdev.dev;
> > > +	u32 chip_id;
> > > +	int ret;
> > > +	int err;
> > > +
> > > +	ret = read_poll_timeout(regmap_read, err, !err, 2000, 20000, false,
> > > +				isl7998x->regmap,
> > > +				ISL7998x_REG_P0_PRODUCT_ID_CODE, &chip_id);
> > > +	if (ret) {
> > > +		dev_err(dev, "timeout while waiting for ISL7998x\n");
> > > +		return ret;
> > > +	}
> > > +
> > > +	dev_dbg(dev, "Found ISL799%x\n", chip_id);
> > > +
> > > +	return ret;
> > > +}
> > > +
> > > +static int isl7998x_set_standard(struct isl7998x *isl7998x, v4l2_std_id norm)
> > > +{
> > > +	const struct isl7998x_mode *mode = isl7998x_get_mode(isl7998x);
> > > +	unsigned int val = isl7998x_norm_to_val(norm);
> > > +	unsigned int width = mode->width;
> > > +	unsigned int i;
> > > +	int ret;
> > > +
> > > +	for (i = 0; i < ISL7998x_INPUTS; i++) {
> > > +		ret = regmap_write_bits(isl7998x->regmap,
> > > +					ISL7998x_REG_Px_DEC_SDT(i + 1),
> > > +					ISL7998x_REG_Px_DEC_SDT_STANDARD,
> > > +					val);
> > > +		if (ret)
> > > +			return ret;
> > > +	}
> > > +
> > > +	ret = regmap_write(isl7998x->regmap,
> > > +			   ISL7998x_REG_P5_LI_ENGINE_LINE_CTL,
> > > +			   0x20 | ((width >> 7) & 0x1f));
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	ret = regmap_write(isl7998x->regmap,
> > > +			   ISL7998x_REG_P5_LI_ENGINE_PIC_WIDTH,
> > > +			   (width << 1) & 0xff);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +static int isl7998x_init(struct isl7998x *isl7998x)
> > > +{
> > > +	const unsigned int lanes = isl7998x->nr_mipi_lanes;
> > > +	const u32 isl7998x_video_in_chan_map[] = { 0x00, 0x11, 0x02, 0x02 };
> > > +	const struct reg_sequence isl7998x_init_seq_custom[] = {
> > > +		{ ISL7998x_REG_P0_VIDEO_IN_CHAN_CTL,
> > > +		  isl7998x_video_in_chan_map[isl7998x->nr_inputs - 1] },
> > > +		{ ISL7998x_REG_P0_CLK_CTL_4,
> > > +		  (lanes == 1) ? 0x40 : 0x41 },
> > > +		{ ISL7998x_REG_P5_LI_ENGINE_CTL,
> > > +		  (lanes == 1) ? 0x01 : 0x02 },
> > > +	};
> > > +	struct device *dev = isl7998x->subdev.dev;
> > > +	struct regmap *regmap = isl7998x->regmap;
> > > +	int ret;
> > > +
> > > +	dev_dbg(dev, "configuring %d lanes for %d inputs (norm 0x%llx)\n",
> > > +		isl7998x->nr_mipi_lanes, isl7998x->nr_inputs,
> > > +		isl7998x->norm);
> > > +
> > > +	ret = regmap_register_patch(regmap, isl7998x_init_seq_1,
> > > +				    ARRAY_SIZE(isl7998x_init_seq_1));
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	ret = isl7998x_set_standard(isl7998x, isl7998x->norm);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	ret = regmap_register_patch(regmap, isl7998x_init_seq_custom,
> > > +				    ARRAY_SIZE(isl7998x_init_seq_custom));
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	return regmap_register_patch(regmap, isl7998x_init_seq_2,
> > > +				     ARRAY_SIZE(isl7998x_init_seq_2));
> > > +}
> > > +
> > > +static int isl7998x_set_test_pattern(struct isl7998x *isl7998x)
> > > +{
> > > +	const struct reg_sequence isl7998x_init_seq_tpg_off[] = {
> > > +		{ ISL7998x_REG_P5_LI_ENGINE_TP_GEN_CTL, 0 },
> > > +		{ ISL7998x_REG_P5_LI_ENGINE_CTL_2, 0 }
> > > +	};
> > > +	const struct reg_sequence isl7998x_init_seq_tpg_on[] = {
> > > +		{ ISL7998x_REG_P5_TP_GEN_BAR_PATTERN,
> > > +		  isl7998x->test_pattern_bars << 6 },
> > > +		{ ISL7998x_REG_P5_LI_ENGINE_CTL_2,
> > > +		  isl7998x->norm & V4L2_STD_PAL ? BIT(2) : 0 },
> > > +		{ ISL7998x_REG_P5_LI_ENGINE_TP_GEN_CTL,
> > > +		  (isl7998x->test_pattern_chans << 4) |
> > > +		  (isl7998x->test_pattern_color << 2) }
> > > +	};
> > > +	struct device *dev = isl7998x->subdev.dev;
> > > +	struct regmap *regmap = isl7998x->regmap;
> > > +	int ret;
> > > +
> > > +	if (!pm_runtime_enabled(dev) || !pm_runtime_get_if_in_use(dev))
> > > +		return 0;
> > > +
> > > +	if (isl7998x->test_pattern != 0) {
> > > +		dev_dbg(dev, "enabling test pattern: channels 0x%x, %s, %s\n",
> > > +			isl7998x->test_pattern_chans,
> > > +			isl7998x_test_pattern_bars[isl7998x->test_pattern_bars],
> > > +			isl7998x_test_pattern_colors[isl7998x->test_pattern_color]);
> > > +		ret = regmap_register_patch(regmap, isl7998x_init_seq_tpg_on,
> > > +					    ARRAY_SIZE(isl7998x_init_seq_tpg_on));
> > > +	} else {
> > > +		ret = regmap_register_patch(regmap, isl7998x_init_seq_tpg_off,
> > > +					    ARRAY_SIZE(isl7998x_init_seq_tpg_off));
> > > +	}
> > > +
> > > +	pm_runtime_put(dev);
> > > +
> > > +	return ret;
> > > +}
> > > +
> > > +#ifdef CONFIG_VIDEO_ADV_DEBUG
> > > +static int isl7998x_g_register(struct v4l2_subdev *sd,
> > > +			       struct v4l2_dbg_register *reg)
> > > +{
> > > +	struct isl7998x *isl7998x = sd_to_isl7998x(sd);
> > > +	int ret;
> > > +	u32 val;
> > > +
> > > +	ret = regmap_read(isl7998x->regmap, reg->reg, &val);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	reg->size = 1;
> > > +	reg->val = val;
> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +static int isl7998x_s_register(struct v4l2_subdev *sd,
> > > +			       const struct v4l2_dbg_register *reg)
> > > +{
> > > +	struct isl7998x *isl7998x = sd_to_isl7998x(sd);
> > > +
> > > +	return regmap_write(isl7998x->regmap, reg->reg, reg->val);
> > > +}
> > > +#endif
> > > +
> > > +static int isl7998x_g_std(struct v4l2_subdev *sd, v4l2_std_id *norm)
> > > +{
> > > +	struct isl7998x *isl7998x = sd_to_isl7998x(sd);
> > > +
> > > +	*norm = isl7998x->norm;
> > > +
> > > +	return 0;
> > > +}
> > > +
> > > +static int isl7998x_s_std(struct v4l2_subdev *sd, v4l2_std_id norm)
> > > +{
> > > +	struct isl7998x *isl7998x = sd_to_isl7998x(sd);
> > > +	struct i2c_client *client = v4l2_get_subdevdata(sd);
> > > +	struct device *dev = &client->dev;
> > > +	int ret;
> > > +
> > > +	if (isl7998x->enabled)
> > > +		return -EBUSY;
> > > +
> > > +	isl7998x->norm = norm;
> > > +
> > > +	if (!pm_runtime_enabled(dev) || !pm_runtime_get_if_in_use(dev))
> > > +		return 0;
> > > +
> > > +	ret = isl7998x_set_standard(isl7998x, isl7998x->norm);
> > > +
> > > +	pm_runtime_put(dev);
> > > +
> > > +	return ret;
> > > +}
> > > +
> > > +static int isl7998x_querystd(struct v4l2_subdev *sd, v4l2_std_id *std)
> > > +{
> > > +	struct isl7998x *isl7998x = sd_to_isl7998x(sd);
> > > +	struct i2c_client *client = v4l2_get_subdevdata(sd);
> > > +	struct device *dev = &client->dev;
> > > +	unsigned int std_id[ISL7998x_INPUTS];
> > > +	unsigned int i;
> > > +	int ret;
> > > +	u32 reg;
> > > +
> > > +	if (isl7998x->enabled)
> > > +		return -EBUSY;
> > > +
> > > +	ret = pm_runtime_resume_and_get(dev);
> > > +	if (ret)
> > > +		return ret;
> > > +
> > > +	dev_dbg(dev, "starting video standard detection\n");
> > > +
> > > +	ret = isl7998x_set_standard(isl7998x, V4L2_STD_UNKNOWN);
> > > +	if (ret)
> > > +		goto out_suspend;
> > > +
> > > +	for (i = 0; i < ISL7998x_INPUTS; i++) {
> > > +		ret = regmap_read_poll_timeout(isl7998x->regmap,
> > > +				ISL7998x_REG_Px_DEC_SDT(i + 1),
> > > +				reg, !(reg & ISL7998x_REG_Px_DEC_SDT_DET),
> > > +				2000, 500 * USEC_PER_MSEC);
> > > +		if (ret)
> > > +			goto out_reset_std;
> > > +		std_id[i] = FIELD_GET(ISL7998x_REG_Px_DEC_SDT_NOW, reg);
> > > +	}
> > > +
> > > +	/*
> > > +	 * According to Renesas FAE, all input cameras must have the
> > > +	 * same standard on this chip.
> > > +	 */
> > > +	for (i = 0; i < isl7998x->nr_inputs; i++) {
> > > +		dev_dbg(dev, "input %d: detected %s\n",
> > > +			i, v4l2_norm_to_name(isl7998x_std_res[std_id[i]].norm));
> > > +		if (std_id[0] != std_id[i])
> > > +			dev_warn(dev,
> > > +				 "incompatible standards: %s on input %d (expected %s)\n",
> > > +				 v4l2_norm_to_name(isl7998x_std_res[std_id[i]].norm), i,
> > > +				 v4l2_norm_to_name(isl7998x_std_res[std_id[0]].norm));
> > > +	}
> > > +
> > > +	*std = isl7998x_std_res[std_id[0]].norm;
> > > +
> > > +out_reset_std:
> > > +	isl7998x_set_standard(isl7998x, isl7998x->norm);
> > > +out_suspend:
> > > +	pm_runtime_put(dev);
> > > +
> > > +	return ret;
> > > +}
> > > +
> > > +static int isl7998x_g_tvnorms(struct v4l2_subdev *sd, v4l2_std_id *std)
> > > +{
> > > +	*std = V4L2_STD_NTSC | V4L2_STD_PAL | V4L2_STD_SECAM;  
> > 
> > You should also add V4L2_STD_NTSC_443, V4L2_STD_PAL_M, V4L2_STD_PAL_N, in
> > order to match the supported standards from the above[1].
> > 
> > [1] You could instead use V4L2_STD_525_60 | V4L2_STD_625_50 if the device
> >     is universal, but, on such case, you would need to implement a missing 
> >     format: PAL/N' also called PAL/Nc (V4L2_STD_PAL_Nc).  
> 
> The chip seems to support PAL/N'.

Yeah, I would expect it to support PAL/N' ;-) 

> The datasheet refers to a PAL-CN video
> format with a subcarrier frequency of 3.582056 MHz, and PAL-N with a
> subcarrier frequency of 4.433619.

AFAIKT, PAL/CN, PAL/NC and PAL/N' are just different names for the same
standard, which is the analog TV standard used in Argentina.

> Thus, I should be able to implement
> V4L2_STD_PAL_Nc using the values for the PAL-CN format, correct?

Yes.

Thanks,
Mauro