From: Johan Hovold <johan@kernel.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hans.verkuil@cisco.com>,
Kevin Hilman <khilman@baylibre.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Johan Hovold <johan@kernel.org>
Subject: [PATCH 4/4] media: davinci: vpif: drop probe printk
Date: Wed, 22 Dec 2021 15:20:25 +0100 [thread overview]
Message-ID: <20211222142025.30364-5-johan@kernel.org> (raw)
In-Reply-To: <20211222142025.30364-1-johan@kernel.org>
Drivers should generally not print anything for a successful probe, and
printing "success" before probe is done makes no sense.
Drop the unnecessary and misleading dev_info() call from probe.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/media/platform/davinci/vpif.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/davinci/vpif.c b/drivers/media/platform/davinci/vpif.c
index 4a260f4ed236..03b4e51bb13a 100644
--- a/drivers/media/platform/davinci/vpif.c
+++ b/drivers/media/platform/davinci/vpif.c
@@ -456,8 +456,6 @@ static int vpif_probe(struct platform_device *pdev)
pm_runtime_enable(&pdev->dev);
pm_runtime_get(&pdev->dev);
- dev_info(&pdev->dev, "vpif probe success\n");
-
/*
* If VPIF Node has endpoints, assume "new" DT support,
* where capture and display drivers don't have DT nodes
--
2.32.0
next prev parent reply other threads:[~2021-12-22 14:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-22 14:20 [PATCH 0/4] media: davinci: vpif: fix use-after-free on driver unbind Johan Hovold
2021-12-22 14:20 ` [PATCH 1/4] media: davinci: vpif: fix unbalanced runtime PM get Johan Hovold
2022-01-04 18:05 ` Lad, Prabhakar
2021-12-22 14:20 ` [PATCH 2/4] media: davinci: vpif: fix unbalanced runtime PM enable Johan Hovold
2022-01-04 18:11 ` Lad, Prabhakar
2022-01-31 10:20 ` Johan Hovold
2021-12-22 14:20 ` [PATCH 3/4] media: davinci: vpif: fix use-after-free on driver unbind Johan Hovold
2022-01-04 18:30 ` Lad, Prabhakar
2021-12-22 14:20 ` Johan Hovold [this message]
2022-01-04 18:31 ` [PATCH 4/4] media: davinci: vpif: drop probe printk Lad, Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211222142025.30364-5-johan@kernel.org \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=prabhakar.csengg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).