From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D542CC433FE for ; Tue, 10 May 2022 14:41:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242836AbiEJOpU (ORCPT ); Tue, 10 May 2022 10:45:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241800AbiEJOoy (ORCPT ); Tue, 10 May 2022 10:44:54 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B47C42E1832 for ; Tue, 10 May 2022 07:04:21 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id kq17so33189762ejb.4 for ; Tue, 10 May 2022 07:04:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IEQJxrgCftMX87O1fp0L99tkMioW1fIbf3pjaY0cgTs=; b=c4lA06Jc8V0lkRPwljLSKeIbqVyQ7hH2D6qBtC0heXu3sQuzQDrtAwBMJ204ijf8xs +r9JcJDrywkieGSliFKxBoxrXKmGlk+Yw5bx2KD5cAzSPBfGoXWW1mFRLvjweFJeJaEz 2ZNIcrjqjigWJeY4u+Zky6/gTk+/gPlE/P4yxt7QpQibt27b2cdF9U+1e7g/IgqmRBGt jGtZZOYb8X8QnWpsILWIlyKHyjY2jSQATgU399TDLnYnEiG6XiwawHaIaKO0vFe+4DKI XOFIicZMfJbqKgvEBOuSlyaziuqz55BoQkvEBZwbDR7le+PCls3cNHYGqrdQ3TkJYX3B SH5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IEQJxrgCftMX87O1fp0L99tkMioW1fIbf3pjaY0cgTs=; b=yu9IRzv899FGBFqlFSUHD9z7US+A6On3XTd7sg45cwULfGVtnL0ufWSVHT3QP4d0No fmGlTjGLB/AoS7CgVj9ZmiwR1A8Wj9WNgXvD3OIXaByDgq6dTK/2pFX5rgPQNLzomKHg djILBLaEgS9dYjMxru6AvDhL+JZjInZ6+dnm0oULJhmvYbS7wLH95NCNxbl9HJouLKaL v19fOlqvKBhzPY5ZvixlkFKZZBcdkeGGY2ycDyYqbksbwqkIu/GqXJsijvBIcIzAOvqj Gt46WJRagZO/HXR53pbtyj/2znmEAsOMlbMW8HNPY52DczhjtAzzwg1wRBZazKsm094e ggkg== X-Gm-Message-State: AOAM530xw9mkvPsTn+H7doqij4Ad2RkyranEVUrkinwnqW70D9Z8HQKX IXa8s+eHAFYbeP1v5HwdeQs= X-Google-Smtp-Source: ABdhPJzIZrT9MY4eUqmsIV6YiHCXdfO2TCNiGnPL7VdLwtgd0ryv0Lq/qrvjirtl8+LnkLEp/GAEBA== X-Received: by 2002:a17:906:7952:b0:6f8:91fa:cef8 with SMTP id l18-20020a170906795200b006f891facef8mr13988346ejo.373.1652191459539; Tue, 10 May 2022 07:04:19 -0700 (PDT) Received: from arch-thunder (a109-49-33-111.cpe.netcabo.pt. [109.49.33.111]) by smtp.gmail.com with ESMTPSA id qr48-20020a1709068cb000b006f3ef214e5csm6285742ejc.194.2022.05.10.07.04.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 May 2022 07:04:18 -0700 (PDT) Date: Tue, 10 May 2022 15:04:16 +0100 From: Rui Miguel Silva To: Laurent Pinchart Cc: linux-media@vger.kernel.org, Steve Longerbeam , Philipp Zabel , Jacopo Mondi , Martin Kepplinger , Alexander Stein , Dorota Czaplejewicz , kernel@pengutronix.de Subject: Re: [PATCH 00/50] staging: media: imx: Prepare destaging of imx7-media-csi Message-ID: <20220510140416.4klypvzok7ril7n7@arch-thunder> References: <20220510115859.19777-1-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220510115859.19777-1-laurent.pinchart@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Laurent, Thanks for this small change :). On Tue, May 10, 2022 at 02:58:09PM +0300, Laurent Pinchart wrote: > Hello, > > This patch series prepares the imx7-media-csi for destaging by > decoupling it from the helpers shared with the i.MX6 IPUv3. > > The strategy Paul and I have followed is to import copies of helper code > and, refactor it within the imx7-media-csi driver, and repeat until no > more shared helpers are used. There is still room for refactoring and > simplification of the imx7-media-csi driver, but I believe it is now in > a state clean enough to be moved out of staging. I agree. > > The series also includes a few fixes or improvements in supported > formats that are now made possible thanks to this refactoring. See > patches 45/50 and 46/50 for details. > > The code size has grown as a result. This is partly offset by code in > the shared helpers that can be removed or simplified, but I haven't > starting working on that. The helpers are now used for the i.MX6 IPUv3 > only, so I will leave this exercise to anyone who would be interested in > destaging that driver as well. > > Some of the items in the TODO file related to the imx7-media-csi driver > have been addressed. The two remaining items are frame interval monitor > support and restricting the list of supported formats to the SoC > version. The former isn't a destaging blocker in my opinion, as the > feature can be added later if desired (and frame interval monitoring > should then be moved to the V4L2 core). I believe the latter could also > be addressed after destaging the driver, but in any case, this is a > discussion for a future destaging series (which may come as soon as this > one is accepted). > > Alexander, this also could greatly simplify your "[PATCH v3 0/8] > imx7/imx8mm media / csi patches" series. I went over all patches and I have 2 small remarks: 1. Shouldn't we change the connection between imx-media objects and imx7-csi also in kconfig? Since at the end of this series they are completely independent. Yeah, it can be done in a follow up patch on the unstaging, for me that's fine also. 2. Something that caught my eye on patch 2/50. But nothing functional. Once again many thanks for continuing investing in this code. for the all series (except patch 2/50): Acked-by: Rui Miguel Silva Cheers, Rui > > Laurent Pinchart (48): > staging: media: imx: imx7-media-csi: Initialize locks early on > staging: media: imx: imx7-media-csi: Split imx_media_dev from probe() > staging: media: imx: imx7-media-csi: Import notifier helpers > staging: media: imx: imx7-media-csi: Drop duplicate link creation > staging: media: imx: imx7-media-csi: Drop the imx_media notifier > staging: media: imx: imx7-media-csi: Don't populate vdev lists > staging: media: imx: imx7-media-csi: Drop unused frame_interval > staging: media: imx: imx7-media-csi: Move format init to probe time > staging: media: imx: imx7-media-csi: Import video device helpers > staging: media: imx: imx7-media-csi: Drop legacy video device support > staging: media: imx: imx7-media-csi: Drop unused controls support > staging: media: imx: imx7-media-csi: Reorganize imx7_csi structure > staging: media: imx: imx7-media-csi: Fold capture_priv into imx7_csi > staging: media: imx: imx7-media-csi: Ensure consistent function prefix > staging: media: imx: imx7-media-csi: Don't set subdev group id > staging: media: imx: imx7-media-csi: Import imx_media_dev_init() > helper > staging: media: imx: imx7-media-csi: Embed imx_media_dev in imx7_csi > staging: media: imx: imx7-media-csi: Drop imx_media_add_video_device > call > staging: media: imx: imx7-media-csi: Don't initialize unused fields > staging: media: imx: imx7-media-csi: Inline imx_media_pipeline_pad() > staging: media: imx: imx7-media-csi: Import > imx_media_pipeline_set_stream() > staging: media: imx: imx7-media-csi: Avoid unnecessary casts > staging: media: imx: imx7-media-csi: Inline pipeline start/stop > staging: media: imx: imx7-media-csi: Fold imx_media_dev into imx7_csi > staging: media: imx: imx7-media-csi: Decouple from imx_media_buffer > staging: media: imx: imx7-media-csi: Fold imx_media_video_dev into > imx7_csi > staging: media: imx: imx7-media-csi: Store imx7_csi in drv data > staging: media: imx: imx7-media-csi: Decouple from imx_media_dma_buf > staging: media: imx: imx7-media-csi: Decouple from shared macros > staging: media: imx: imx7-media-csi: Drop error message on alloc > failure > staging: media: imx: imx7-media-csi: Import format helpers > staging: media: imx: imx7-media-csi: Replace ipu_color_space with bool > yuv field > staging: media: imx: imx7-media-csi: Drop IC support from > imx7_csi_try_colorimetry() > staging: media: imx: imx7-media-csi: Drop IPU-only formats > staging: media: imx: imx7-media-csi: Drop unsupported YUV and RGB > formats > staging: media: imx: imx7-media-csi: Make default formats consistent > staging: media: imx: imx7-media-csi: Define macro for default mbus > code > staging: media: imx: imx7-media-csi: Simplify default mbus code in > try_fmt > staging: media: imx: imx7-media-csi: Drop YUV/RGB/BAYER format > selectors > staging: media: imx: imx7-media-csi: Drop unneeded imx7_csi_pixfmt > fields > staging: media: imx: imx7-media-csi: Inline imx7_csi_init_mbus_fmt() > staging: media: imx: imx7-media-csi: Simplify default format in > try_fmt > staging: media: imx: imx7-media-csi: Fix list of supported formats > staging: media: imx: imx7-media-csi: Add V4L2_PIX_FMT_Y14 support > staging: media: imx: imx7-media-csi: Drop unneeded pixel format > validation > staging: media: imx: imx7-media-csi: Inline > imx7_csi_enum_pixel_formats() > staging: media: imx: imx7-media-csi: Drop V4L2 events support > staging: media: imx: imx7-media-csi: Drop usage of shared helpers > > Paul Elder (2): > staging: media: imx: imx7-media-csi: Move misc init out of probe() > staging: media: imx: imx7-media-csi: Remove imx_media_of_add_csi > > drivers/staging/media/imx/imx7-media-csi.c | 1370 +++++++++++++++++--- > 1 file changed, 1172 insertions(+), 198 deletions(-) > > > base-commit: c5eb0a61238dd6faf37f58c9ce61c9980aaffd7a > -- > Regards, > > Laurent Pinchart >