Re: [PATCH 3/3] Added Digiteq Automotive MGB4 driver

From: kernel test robot <lkp@intel.com>
To: martin.tuma@digiteqautomotive.com, linux-media@vger.kernel.org
Cc: kbuild-all@lists.01.org,
	"Martin Tůma" <martin.tuma@digiteqautomotive.com>
Subject: Re: [PATCH 3/3] Added Digiteq Automotive MGB4 driver
Date: Tue, 23 Aug 2022 05:02:15 +0800	[thread overview]
Message-ID: <202208230454.wUB5ighv-lkp@intel.com> (raw)
In-Reply-To: <20220822194721.1238-4-martin.tuma@digiteqautomotive.com>

Hi,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on media-tree/master]
[also build test WARNING on vkoul-dmaengine/next linus/master v6.0-rc2 next-20220822]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/martin-tuma-digiteqautomotive-com/Digiteq-Automotive-MGB4-driver/20220823-015724
base:   git://linuxtv.org/media_tree.git master
config: loongarch-allyesconfig (https://download.01.org/0day-ci/archive/20220823/202208230454.wUB5ighv-lkp@intel.com/config)
compiler: loongarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/54f06e839ff47e3223a38eb48ab44aee9866eb30
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review martin-tuma-digiteqautomotive-com/Digiteq-Automotive-MGB4-driver/20220823-015724
        git checkout 54f06e839ff47e3223a38eb48ab44aee9866eb30
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/media/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/media/pci/mgb4/mgb4_vout.c:202:5: warning: no previous prototype for 'vidioc_g_output' [-Wmissing-prototypes]
     202 | int vidioc_g_output(struct file *file, void *priv, unsigned int *i)
         |     ^~~~~~~~~~~~~~~
>> drivers/media/pci/mgb4/mgb4_vout.c:208:5: warning: no previous prototype for 'vidioc_s_output' [-Wmissing-prototypes]
     208 | int vidioc_s_output(struct file *file, void *priv, unsigned int i)
         |     ^~~~~~~~~~~~~~~
>> drivers/media/pci/mgb4/mgb4_vout.c:213:5: warning: no previous prototype for 'vidioc_enum_output' [-Wmissing-prototypes]
     213 | int vidioc_enum_output(struct file *file, void *priv, struct v4l2_output *out)
         |     ^~~~~~~~~~~~~~~~~~

vim +/vidioc_g_output +202 drivers/media/pci/mgb4/mgb4_vout.c

   201	
 > 202	int vidioc_g_output(struct file *file, void *priv, unsigned int *i)
   203	{
   204		*i = 0;
   205		return 0;
   206	}
   207	
 > 208	int vidioc_s_output(struct file *file, void *priv, unsigned int i)
   209	{
   210		return i ? -EINVAL : 0;
   211	}
   212	
 > 213	int vidioc_enum_output(struct file *file, void *priv, struct v4l2_output *out)
   214	{
   215		if (out->index != 0)
   216			return -EINVAL;
   217	
   218		out->type = V4L2_OUTPUT_TYPE_ANALOG;
   219		strscpy(out->name, "MGB4", sizeof(out->name));
   220	
   221		return 0;
   222	}
   223	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp