linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yunke Cao <yunkec@chromium.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Ricardo Ribalda <ribalda@chromium.org>,
	Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: Yunke Cao <yunkec@chromium.org>,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Ricardo Ribalda <ribalda@chromium.org>
Subject: [PATCH RFC 2/3] media: uvcvideo: remove entity privacy control in the uvc video node
Date: Wed, 11 Jan 2023 17:52:39 +0900	[thread overview]
Message-ID: <20230111-uvc_privacy_subdev-v1-2-f859ac9a01e3@chromium.org> (raw)
In-Reply-To: <20230111-uvc_privacy_subdev-v1-0-f859ac9a01e3@chromium.org>

For privacy_gpio, do not expose V4L2_CID_PRIVACY to userspace as a control
of the video node.

Signed-off-by: Yunke Cao <yunkec@chromium.org>
---
 drivers/media/usb/uvc/uvc_ctrl.c | 17 -----------------
 1 file changed, 17 deletions(-)

diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb/uvc/uvc_ctrl.c
index c95a2229f4fa..77c5ff19add8 100644
--- a/drivers/media/usb/uvc/uvc_ctrl.c
+++ b/drivers/media/usb/uvc/uvc_ctrl.c
@@ -348,14 +348,6 @@ static const struct uvc_control_info uvc_ctrls[] = {
 				| UVC_CTRL_FLAG_RESTORE
 				| UVC_CTRL_FLAG_AUTO_UPDATE,
 	},
-	{
-		.entity		= UVC_GUID_EXT_GPIO_CONTROLLER,
-		.selector	= UVC_CT_PRIVACY_CONTROL,
-		.index		= 0,
-		.size		= 1,
-		.flags		= UVC_CTRL_FLAG_GET_CUR
-				| UVC_CTRL_FLAG_AUTO_UPDATE,
-	},
 };
 
 static const u32 uvc_control_classes[] = {
@@ -710,15 +702,6 @@ static const struct uvc_control_mapping uvc_ctrl_mappings[] = {
 		.v4l2_type	= V4L2_CTRL_TYPE_BOOLEAN,
 		.data_type	= UVC_CTRL_DATA_TYPE_BOOLEAN,
 	},
-	{
-		.id		= V4L2_CID_PRIVACY,
-		.entity		= UVC_GUID_EXT_GPIO_CONTROLLER,
-		.selector	= UVC_CT_PRIVACY_CONTROL,
-		.size		= 1,
-		.offset		= 0,
-		.v4l2_type	= V4L2_CTRL_TYPE_BOOLEAN,
-		.data_type	= UVC_CTRL_DATA_TYPE_BOOLEAN,
-	},
 };
 
 static const struct uvc_control_mapping uvc_ctrl_mappings_uvc11[] = {

-- 
b4 0.11.0-dev-4d321

  parent reply	other threads:[~2023-01-11  8:52 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-11  8:52 [PATCH RFC 0/3] meida: uvcvideo: reimplement privacy gpio as a separate subdevice Yunke Cao
2023-01-11  8:52 ` [PATCH RFC 1/3] media: v4l2-ctrls: Expose v4l2_ctrl_fill_event() Yunke Cao
2023-01-11  8:52 ` Yunke Cao [this message]
2023-01-11 10:33   ` [PATCH RFC 2/3] media: uvcvideo: remove entity privacy control in the uvc video node Andrzej Pietrasiewicz
2023-01-12  1:40     ` Yunke Cao
2023-01-11  8:52 ` [PATCH RFC 3/3] media: uvcvideo: reimplement privacy GPIO as a separate subdevice Yunke Cao
2023-11-21 20:46   ` Hans Verkuil
2023-01-13  8:25 ` [PATCH RFC 0/3] meida: uvcvideo: reimplement privacy gpio " Ricardo Ribalda
2023-02-14  5:45   ` Yunke Cao
2023-03-08 22:57     ` Ricardo Ribalda
2023-11-21 20:05 ` Ricardo Ribalda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230111-uvc_privacy_subdev-v1-2-f859ac9a01e3@chromium.org \
    --to=yunkec@chromium.org \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ribalda@chromium.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).