From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A40F0C83005 for ; Mon, 12 Jun 2023 13:02:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235795AbjFLNCQ (ORCPT ); Mon, 12 Jun 2023 09:02:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234576AbjFLNCO (ORCPT ); Mon, 12 Jun 2023 09:02:14 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E8059DC; Mon, 12 Jun 2023 06:02:12 -0700 (PDT) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 55540C4C; Mon, 12 Jun 2023 15:01:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1686574901; bh=myI2OsDKPlAivJwq8XHEp21SionS1U4YLnRbxXj2LGM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nEvpQz3C+gVmmfjX1TWlXKZadMDfgm7VXB+hbeXpYCo/EwWR8ziagLTg7r1u2qAM7 eGV8lH3OnJtndQCZyYybiXS9leMtWb+SgKqU9fd0WU8NTKZatD5cwCE8oYOEH877Kn iS4L85ifZlV5qrB+6pQyzXNHIW2edRov0Y3Y3nJk= Date: Mon, 12 Jun 2023 16:02:10 +0300 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Biju Das , Krzysztof Kozlowski , Rob Herring , Wolfram Sang , Conor Dooley , Andrzej Hajda , Neil Armstrong , Robert Foss , David Airlie , Daniel Vetter , Kieran Bingham , Mauro Carvalho Chehab , Hans Verkuil , Alessandro Zummo , Alexandre Belloni , Jonas Karlman , Jernej Skrabec , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Corey Minyard , Marek =?utf-8?B?QmVow7pu?= , Jiasheng Jiang , Antonio Borneo , Abhinav Kumar , Ahmad Fatoum , "dri-devel@lists.freedesktop.org" , "linux-i2c@vger.kernel.org" , "linux-media@vger.kernel.org" , Fabrizio Castro , "linux-renesas-soc@vger.kernel.org" , Mark Brown Subject: Re: [PATCH v5 01/11] i2c: Enhance i2c_new_ancillary_device API Message-ID: <20230612130210.GB23921@pendragon.ideasonboard.com> References: <20230608103929.GO5058@pendragon.ideasonboard.com> <20230608125019.GD26742@pendragon.ideasonboard.com> <20230612122353.GA22391@pendragon.ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Mon, Jun 12, 2023 at 02:44:33PM +0200, Geert Uytterhoeven wrote: > On Mon, Jun 12, 2023 at 2:23 PM Laurent Pinchart wrote: > > On Mon, Jun 12, 2023 at 09:53:02AM +0000, Biju Das wrote: > > > Hi All, > > > > > > How do we proceed here between [1] and [2]? > > > > > > DT-Maintainers suggestion: > > > [1] > > > raa215300: pmic@12 { > > > compatible = "renesas,raa215300"; > > > reg = <0x12>, <0x6f>; > > > reg-names = "main", "rtc"; > > > > > > clocks = <&x2>; > > > clock-names = "xin"; > > > /* Add Optional shared IRQ resource and share it to child and handle it both in parent and child */ > > > }; > > > > > > Laurent/Wolfram suggestion to split it into two nodes and get rid of this patch: > > > [2] > > > raa215300: pmic @12 { > > > compatible = "renesas,raa215300"; > > > reg = <0x12>; > > > > > > /* Add Optional shared IRQ */ > > > renesas,raa215300-rtc = <&rtc_raa215300>; /* Parse the handle and Enable RTC , if present.*/ > > > }; > > > > > > rtc_raa215300: rtc@6f { > > > compatible = "renesas,raa215300-isl1208"; > > > > Make this > > > > compatible = "renesas,raa215300-isl1208", "isil,isl1208"; > > "renesas,raa215300-rtc", "isil,isl1208". > > However, that would suggest the RAA215300 RTC can be treated as > an ISL1208, which is not true for all revisions... It depends. If we add a renesas,invert-xtoscb DT property, then it becomes true for all revisions. > > Btw, it would be nice to convert > > Documentation/devicetree/bindings/rtc/isil,isl1208.txt to YAML. > > Hey, look at patch 2 in this series ;-) -- Regards, Laurent Pinchart