Re: [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588

From: amazingfate <liujianfeng1994@gmail.com>
To: nicolas@ndufresne.ca
Cc: conor+dt@kernel.org, devicetree@vger.kernel.org,
	elezegarcia@gmail.com, ezequiel@vanguardiasur.com.ar,
	heiko@sntech.de, knaerzche@gmail.com,
	krzysztof.kozlowski+dt@linaro.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	linux-rockchip@lists.infradead.org, liujianfeng1994@gmail.com,
	mchehab@kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org,
	sfr@canb.auug.org.au
Subject: Re: [PATCH v3 0/2] [v3]Add hantro g1 video decoder support for RK3588
Date: Thu, 18 Jan 2024 19:30:51 +0800	[thread overview]
Message-ID: <20240118113051.10773-1-liujianfeng1994@gmail.com> (raw)
In-Reply-To: <5490507acc121113e52a8cdddb155fddf6dbb374.camel@ndufresne.ca>

Hi Nicolas,

Wed, 17 Jan 2024 14:16:24 -0500, Nicolas Dufresne wrote:
>The only concern I have is that we rejected enabling this VPU on RK3399, since
>having two H.264 decoders was confusing userspace softwares at the time, causing
>the slow one to be picked sometimes. I know the selection is not fully
>implemented in GStreamer either, not sure for LibreELEC ffmpeg fork, Chromium or
>Cros-codec.

Only H264 decoder is disabled for RK3399 in driver code, and RK3399 does
have this VPU node in devicetree to support other codecs like MPEG or VP8.

>Of course, its not a problem now, but only when someone provides an rkvdec2
>driver that enables the much more capable HW decoder. Shall we hold on H.264
>mainline for now ?

RK356x also has the same situation. That is why this patch shares the same
compatible string with RK356X. Before rkvdec2 launching mainline, this
hantro g1 vpu is the only H264 decoder to use on these socs. We can keep
H.264 enabled, and disable it for RK356x and RK3588 just like what we did
to RK3399 when rkvdec2 launches.

Jianfeng