From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Zhi Mao <zhi.mao@mediatek.com>
Cc: mchehab@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, sakari.ailus@linux.intel.com,
shengnan.wang@mediatek.com, yaya.chang@mediatek.com,
10572168@qq.com,
Project_Global_Chrome_Upstream_Group@mediatek.com,
yunkec@chromium.org, conor+dt@kernel.org, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
jacopo.mondi@ideasonboard.com, hverkuil-cisco@xs4all.nl,
heiko@sntech.de, jernej.skrabec@gmail.com,
macromorgan@hotmail.com, linus.walleij@linaro.org,
hdegoede@redhat.com, tomi.valkeinen@ideasonboard.com,
gerald.loacker@wolfvision.net, andy.shevchenko@gmail.com,
bingbu.cao@intel.com, dan.scally@ideasonboard.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v4 1/2] media: dt-bindings: i2c: add GalaxyCore GC08A3 image sensor
Date: Sun, 4 Feb 2024 15:50:56 +0200 [thread overview]
Message-ID: <20240204135056.GA6804@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20240204061538.2105-2-zhi.mao@mediatek.com>
Hi Zhi,
Thank you for the patch.
On Sun, Feb 04, 2024 at 02:15:37PM +0800, Zhi Mao wrote:
> Add YAML device tree binding for GC08A3 CMOS image sensor,
> and the relevant MAINTAINERS entries.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: Zhi Mao <zhi.mao@mediatek.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> .../bindings/media/i2c/galaxycore,gc08a3.yaml | 112 ++++++++++++++++++
> 1 file changed, 112 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
> new file mode 100644
> index 000000000000..8c09e8c121e5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/galaxycore,gc08a3.yaml
> @@ -0,0 +1,112 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (c) 2023 MediaTek Inc.
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/galaxycore,gc08a3.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: GalaxyCore gc08a3 1/4" 8M Pixel MIPI CSI-2 sensor
> +
> +maintainers:
> + - Zhi Mao <zhi.mao@mediatek.com>
> +
> +description:
> + The gc08a3 is a raw image sensor with an MIPI CSI-2 image data
> + interface and CCI (I2C compatible) control bus. The output format
> + is raw Bayer.
> +
> +properties:
> + compatible:
> + const: galaxycore,gc08a3
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + dovdd-supply: true
> +
> + avdd-supply: true
> +
> + dvdd-supply: true
> +
> + reset-gpios:
> + description: Reference to the GPIO connected to the RESETB pin.
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/$defs/port-base
> + additionalProperties: false
> + description:
> + Output port node, single endpoint describing the CSI-2 transmitter.
> +
> + properties:
> + endpoint:
> + $ref: /schemas/media/video-interfaces.yaml#
> + unevaluatedProperties: false
> +
> + properties:
> + data-lanes:
> + oneOf:
> + - items:
> + - const: 1
> + - const: 2
> + - const: 3
> + - const: 4
> + - items:
> + - const: 1
> + - const: 2
> +
> + link-frequencies: true
> +
> + required:
> + - data-lanes
> + - link-frequencies
> +
> + required:
> + - endpoint
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - dovdd-supply
> + - avdd-supply
> + - dvdd-supply
> + - reset-gpios
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sensor@31 {
> + compatible = "galaxycore,gc08a3";
> + reg = <0x31>;
> +
> + clocks = <&gc08a3_clk>;
> +
> + reset-gpios = <&pio 19 GPIO_ACTIVE_HIGH>;
> +
> + avdd-supply = <&gc08a3_avdd>;
> + dovdd-supply = <&gc08a3_dovdd>;
> + dvdd-supply = <&gc08a3_dvdd>;
> +
> + port {
> + sensor_out: endpoint {
> + data-lanes = <1 2 3 4>;
> + link-frequencies = /bits/ 64 <336000000 207000000>;
> + remote-endpoint = <&seninf_csi_port_0_in>;
> + };
> + };
> + };
> + };
> +
> +...
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2024-02-04 13:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-04 6:15 [PATCH v4 0/2] media: i2c: Add support for GC08A3 sensor Zhi Mao
2024-02-04 6:15 ` [PATCH v4 1/2] media: dt-bindings: i2c: add GalaxyCore GC08A3 image sensor Zhi Mao
2024-02-04 13:50 ` Laurent Pinchart [this message]
2024-02-07 14:42 ` AngeloGioacchino Del Regno
2024-02-04 6:15 ` [PATCH v4 2/2] media: i2c: Add GC08A3 image sensor driver Zhi Mao
2024-02-06 18:45 ` Laurent Pinchart
2024-02-20 2:12 ` Zhi Mao (毛智)
2024-02-20 3:01 ` Laurent Pinchart
2024-02-20 5:45 ` Zhi Mao (毛智)
2024-02-20 7:25 ` sakari.ailus
2024-02-21 2:37 ` Zhi Mao (毛智)
2024-02-21 7:43 ` sakari.ailus
2024-02-27 1:36 ` Zhi Mao (毛智)
2024-02-07 14:42 ` AngeloGioacchino Del Regno
2024-02-20 2:21 ` Zhi Mao (毛智)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240204135056.GA6804@pendragon.ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=10572168@qq.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=andy.shevchenko@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bingbu.cao@intel.com \
--cc=conor+dt@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=gerald.loacker@wolfvision.net \
--cc=hdegoede@redhat.com \
--cc=heiko@sntech.de \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=jernej.skrabec@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=macromorgan@hotmail.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=tomi.valkeinen@ideasonboard.com \
--cc=yaya.chang@mediatek.com \
--cc=yunkec@chromium.org \
--cc=zhi.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).