From: Umang Jain <umang.jain@ideasonboard.com>
To: linux-media@vger.kernel.org
Cc: Alexander Shiyan <eagle.alexander923@gmail.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
open list <linux-kernel@vger.kernel.org>,
Umang Jain <umang.jain@ideasonboard.com>
Subject: [PATCH v3 2/6] media: imx335: Parse fwnode properties
Date: Thu, 21 Mar 2024 16:42:35 +0530 [thread overview]
Message-ID: <20240321111239.808735-3-umang.jain@ideasonboard.com> (raw)
In-Reply-To: <20240321111239.808735-1-umang.jain@ideasonboard.com>
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
Call the V4L2 fwnode device parser to handle controls that are
standardised by the framework.
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
drivers/media/i2c/imx335.c | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
index c633ea1380e7..b8cf85984127 100644
--- a/drivers/media/i2c/imx335.c
+++ b/drivers/media/i2c/imx335.c
@@ -1227,10 +1227,12 @@ static int imx335_init_controls(struct imx335 *imx335)
{
struct v4l2_ctrl_handler *ctrl_hdlr = &imx335->ctrl_handler;
const struct imx335_mode *mode = imx335->cur_mode;
+ struct v4l2_fwnode_device_properties props;
u32 lpfr;
int ret;
- ret = v4l2_ctrl_handler_init(ctrl_hdlr, 7);
+ /* v4l2_fwnode_device_properties can add two more controls */
+ ret = v4l2_ctrl_handler_init(ctrl_hdlr, 9);
if (ret)
return ret;
@@ -1296,15 +1298,27 @@ static int imx335_init_controls(struct imx335 *imx335)
imx335->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;
if (ctrl_hdlr->error) {
- dev_err(imx335->dev, "control init failed: %d\n",
- ctrl_hdlr->error);
- v4l2_ctrl_handler_free(ctrl_hdlr);
- return ctrl_hdlr->error;
+ ret = ctrl_hdlr->error;
+ dev_err(imx335->dev, "control init failed: %d\n", ret);
+ goto free_ctrl_hdlr;
}
+ ret = v4l2_fwnode_device_parse(imx335->dev, &props);
+ if (ret)
+ goto free_ctrl_hdlr;
+
+ ret = v4l2_ctrl_new_fwnode_properties(ctrl_hdlr, &imx335_ctrl_ops,
+ &props);
+ if (ret)
+ goto free_ctrl_hdlr;
+
imx335->sd.ctrl_handler = ctrl_hdlr;
return 0;
+
+free_ctrl_hdlr:
+ v4l2_ctrl_handler_free(ctrl_hdlr);
+ return ret;
}
/**
--
2.43.0
next prev parent reply other threads:[~2024-03-21 11:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 11:12 [PATCH v3 0/6] media: imx335: 2/4 lane ops and improvements Umang Jain
2024-03-21 11:12 ` [PATCH v3 1/6] media: imx335: Support 2 or 4 lane operation modes Umang Jain
2024-03-21 11:12 ` Umang Jain [this message]
2024-03-22 14:44 ` [PATCH v3 2/6] media: imx335: Parse fwnode properties Tommaso Merciai
2024-03-21 11:12 ` [PATCH v3 3/6] media: imx335: Use V4L2 CCI for accessing sensor registers Umang Jain
2024-03-21 11:12 ` [PATCH v3 4/6] media: imx335: Use integer values for size registers Umang Jain
2024-03-21 11:12 ` [PATCH v3 5/6] media: imx335: Fix active area height discrepency Umang Jain
2024-03-21 11:12 ` [PATCH v3 6/6] media: imx335: Limit analogue gain value Umang Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321111239.808735-3-umang.jain@ideasonboard.com \
--to=umang.jain@ideasonboard.com \
--cc=eagle.alexander923@gmail.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).