From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8000604AE; Thu, 21 Mar 2024 11:13:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711019603; cv=none; b=k1ooMABnztdtaJ1RMli2lXoEItD52pvTLio41rjO47mgvjmvBdg7YS7W+Obnqs3XcDOyEmDuIRffAzrk+/CyE9i11edSuYGDuTP0lBC0RFBhVACu9RxnlVJCsLy/NBcBto054v9yRRwV2mrkX9ApruYXZk+bciNXU7vPutugwcM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711019603; c=relaxed/simple; bh=xiE+4s/2bcGKpcSbUmB3pNcXJFGnXmhWhAmSMO4hU7o=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=kOHubuYACMbCopvZOV5Nd37I5LwKAz+eiW04G+7iS9w675PBz25CyNr44KWDwAu9SPutJlnBbBMPxVYYjCW0Tt/XarPsy8wxKZiN5u3/J6nGTi6e8nmZX7Q23m6bCqyFVfFVZtry0YLwDnKpRjrBeHVjLXNAhVMq/kbGlBfRoKA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=ZAJ348vF; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="ZAJ348vF" Received: from umang.jain (unknown [103.86.18.138]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D7498CC; Thu, 21 Mar 2024 12:12:48 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1711019572; bh=xiE+4s/2bcGKpcSbUmB3pNcXJFGnXmhWhAmSMO4hU7o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZAJ348vF0h+iybGwGHwUXE6JiAEn2RCEWxy+IJbx7LDgh5fmbWs+2SoWuLWM2hD+x rjMhOP2IwhE9PiSUR2P6YMTGKLcZrKG64yT7cdS5vUDHFLnqPc72oJ+SqCjjeAfam2 rReCIvUV4aAecUfo2IQs7XZbf6tkbyfPX1Ix6y9c= From: Umang Jain To: linux-media@vger.kernel.org Cc: Alexander Shiyan , Sakari Ailus , Kieran Bingham , open list , Umang Jain , Tommaso Merciai Subject: [PATCH v3 6/6] media: imx335: Limit analogue gain value Date: Thu, 21 Mar 2024 16:42:39 +0530 Message-ID: <20240321111239.808735-7-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240321111239.808735-1-umang.jain@ideasonboard.com> References: <20240321111239.808735-1-umang.jain@ideasonboard.com> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The sensor gain (both analog and digital) are controlled by a single gain value where: - 0dB to 30dB correspond to analog gain - 30.3dB to 72dB correspond to digital gain (with 0.3dB step) Hence, limit the analogue gain value to 100. For digital gain, support can be added later if needed. Signed-off-by: Umang Jain Reviewed-by: Kieran Bingham Reviewed-by: Tommaso Merciai --- drivers/media/i2c/imx335.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index 10a09830dbd6..9eb8f70836fd 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -52,7 +52,7 @@ /* Analog gain control */ #define IMX335_REG_AGAIN CCI_REG8(0x30e8) #define IMX335_AGAIN_MIN 0 -#define IMX335_AGAIN_MAX 240 +#define IMX335_AGAIN_MAX 100 #define IMX335_AGAIN_STEP 1 #define IMX335_AGAIN_DEFAULT 0 @@ -1175,6 +1175,14 @@ static int imx335_init_controls(struct imx335 *imx335) IMX335_EXPOSURE_STEP, IMX335_EXPOSURE_DEFAULT); + /* + * The sensor has an analog gain and a digital gain, both controlled + * through a single gain value, expressed in 0.3dB increments. Values + * from 0.0dB (0) to 30.0dB (100) apply analog gain only, higher values + * up to 72.0dB (240) add further digital gain. Limit the range to + * analog gain only, support for digital gain can be added separately + * if needed. + */ imx335->again_ctrl = v4l2_ctrl_new_std(ctrl_hdlr, &imx335_ctrl_ops, V4L2_CID_ANALOGUE_GAIN, -- 2.43.0