From: Dan Ziemba <zman0900@gmail.com>
To: Malcolm Priestley <tvboxspy@gmail.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
Antti Palosaari <crope@iki.fi>,
stable@vger.kernel.org
Subject: Re: [PATCH v3] [bug/urgent] dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER
Date: Sat, 05 Jan 2019 20:49:00 -0500 [thread overview]
Message-ID: <204ed67fafd1ecdc58158da9758a3b6b01ec5ada.camel@gmail.com> (raw)
In-Reply-To: <7dd3e986-d838-1210-922c-4f8793eea2e9@gmail.com>
On Mon, 2018-11-26 at 20:18 +0000, Malcolm Priestley wrote:
> In commit 1a0c10ed7b media: dvb-usb-v2: stop using coherent memory
> for URBs
> incorrectly adds URB_FREE_BUFFER after every urb transfer.
>
> It cannot use this flag because it reconfigures the URBs accordingly
> to suit connected devices. In doing a call to usb_free_urb is made
> and
> invertedly frees the buffers.
>
> The stream buffer should remain constant while driver is up.
>
> Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com>
> CC: stable@vger.kernel.org # v4.18+
> ---
> v3 change commit message to the actual cause
>
> drivers/media/usb/dvb-usb-v2/usb_urb.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/usb/dvb-usb-v2/usb_urb.c
> b/drivers/media/usb/dvb-usb-v2/usb_urb.c
> index 024c751eb165..2ad2ddeaff51 100644
> --- a/drivers/media/usb/dvb-usb-v2/usb_urb.c
> +++ b/drivers/media/usb/dvb-usb-v2/usb_urb.c
> @@ -155,7 +155,6 @@ static int usb_urb_alloc_bulk_urbs(struct
> usb_data_stream *stream)
> stream->props.u.bulk.buffersize,
> usb_urb_complete, stream);
>
> - stream->urb_list[i]->transfer_flags = URB_FREE_BUFFER;
> stream->urbs_initialized++;
> }
> return 0;
> @@ -186,7 +185,7 @@ static int usb_urb_alloc_isoc_urbs(struct
> usb_data_stream *stream)
> urb->complete = usb_urb_complete;
> urb->pipe = usb_rcvisocpipe(stream->udev,
> stream->props.endpoint);
> - urb->transfer_flags = URB_ISO_ASAP | URB_FREE_BUFFER;
> + urb->transfer_flags = URB_ISO_ASAP;
> urb->interval = stream->props.u.isoc.interval;
> urb->number_of_packets = stream-
> >props.u.isoc.framesperurb;
> urb->transfer_buffer_length = stream-
> >props.u.isoc.framesize *
> @@ -210,7 +209,7 @@ static int usb_free_stream_buffers(struct
> usb_data_stream *stream)
> if (stream->state & USB_STATE_URB_BUF) {
> while (stream->buf_num) {
> stream->buf_num--;
> - stream->buf_list[stream->buf_num] = NULL;
> + kfree(stream->buf_list[stream->buf_num]);
> }
> }
>
I have tested this against Arch Linux's kernel packages for both linux
4.20 and linux-lts 4.19.13. For both, the patch seems to fix the
crashes I reported here:
https://bugzilla.kernel.org/show_bug.cgi?id=201055
Thanks,
Dan Ziemba
next prev parent reply other threads:[~2019-01-06 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 20:18 [PATCH v3] [bug/urgent] dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER Malcolm Priestley
2019-01-06 1:49 ` Dan Ziemba [this message]
2019-01-07 14:32 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=204ed67fafd1ecdc58158da9758a3b6b01ec5ada.camel@gmail.com \
--to=zman0900@gmail.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).