From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A819DC04EB8 for ; Mon, 10 Dec 2018 20:16:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 646542084E for ; Mon, 10 Dec 2018 20:16:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="plsm1IAq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 646542084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-media-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729806AbeLJUQO (ORCPT ); Mon, 10 Dec 2018 15:16:14 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:37790 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726392AbeLJUQO (ORCPT ); Mon, 10 Dec 2018 15:16:14 -0500 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 589D254B; Mon, 10 Dec 2018 21:16:10 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1544472971; bh=9o+qzaISX+3BXfg7S/S/KtB+YWJoEpe9TO2d5vRCl0A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=plsm1IAq+R7SO8eniO2kRPtdfx7+CuGyTxVTPohIkZrY3AH/465KpjXFLDBP6szjj UzQO6Eak3iN5XVBPNQxs5CinmAyKauxyJ8DGMl4t4iW0E9AKuYoGPlSoxYR7EurIxP Ucx2vWGQtOdyjZCkyYTSizJwG4PcocVsZZCThBIQ= From: Laurent Pinchart To: Jacopo Mondi Cc: niklas.soderlund@ragnatech.se, kieran.bingham@ideasonboard.com, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] media: rcar-csi2: Fix PHTW table values for E3/V3M Date: Mon, 10 Dec 2018 22:16:52 +0200 Message-ID: <2063363.Wr8td8jMvS@avalon> Organization: Ideas on Board Oy In-Reply-To: <1544453635-16359-1-git-send-email-jacopo+renesas@jmondi.org> References: <1544453635-16359-1-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Jacopo, Thank you for the patch. On Monday, 10 December 2018 16:53:55 EET Jacopo Mondi wrote: > The PHTW selection algorithm implemented in rcsi2_phtw_write_mbps() checks > for lower bound of the interval used to match the desired bandwidth. Use > that in place of the currently used upport bound. The rcsi2_phtw_write_mbps() function performs the following (error handling removed): const struct rcsi2_mbps_reg *value; for (value = values; value->mbps; value++) if (value->mbps >= mbps) break; return rcsi2_phtw_write(priv, value->reg, code); With this patch, an mbps value of 85 will match the second entry in the phtw_mbps_v3m_e3 table: [0] { .mbps = 80, .reg = 0x00 }, [1] { .mbps = 90, .reg = 0x20 }, ... The datasheet however documents the range 80-89 to map to 0x00. What am I missing ? > Fixes: 10c08812fe60 ("media: rcar: rcar-csi2: Update V3M/E3 PHTW tables") > Signed-off-by: Jacopo Mondi > --- > drivers/media/platform/rcar-vin/rcar-csi2.c | 62 ++++++++++++------------- > 1 file changed, 31 insertions(+), 31 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c > b/drivers/media/platform/rcar-vin/rcar-csi2.c index > 80ad906d1136..7e9cb8bcfe70 100644 > --- a/drivers/media/platform/rcar-vin/rcar-csi2.c > +++ b/drivers/media/platform/rcar-vin/rcar-csi2.c > @@ -152,37 +152,37 @@ static const struct rcsi2_mbps_reg > phtw_mbps_h3_v3h_m3n[] = { }; > > static const struct rcsi2_mbps_reg phtw_mbps_v3m_e3[] = { > - { .mbps = 89, .reg = 0x00 }, > - { .mbps = 99, .reg = 0x20 }, > - { .mbps = 109, .reg = 0x40 }, > - { .mbps = 129, .reg = 0x02 }, > - { .mbps = 139, .reg = 0x22 }, > - { .mbps = 149, .reg = 0x42 }, > - { .mbps = 169, .reg = 0x04 }, > - { .mbps = 179, .reg = 0x24 }, > - { .mbps = 199, .reg = 0x44 }, > - { .mbps = 219, .reg = 0x06 }, > - { .mbps = 239, .reg = 0x26 }, > - { .mbps = 249, .reg = 0x46 }, > - { .mbps = 269, .reg = 0x08 }, > - { .mbps = 299, .reg = 0x28 }, > - { .mbps = 329, .reg = 0x0a }, > - { .mbps = 359, .reg = 0x2a }, > - { .mbps = 399, .reg = 0x4a }, > - { .mbps = 449, .reg = 0x0c }, > - { .mbps = 499, .reg = 0x2c }, > - { .mbps = 549, .reg = 0x0e }, > - { .mbps = 599, .reg = 0x2e }, > - { .mbps = 649, .reg = 0x10 }, > - { .mbps = 699, .reg = 0x30 }, > - { .mbps = 749, .reg = 0x12 }, > - { .mbps = 799, .reg = 0x32 }, > - { .mbps = 849, .reg = 0x52 }, > - { .mbps = 899, .reg = 0x72 }, > - { .mbps = 949, .reg = 0x14 }, > - { .mbps = 999, .reg = 0x34 }, > - { .mbps = 1049, .reg = 0x54 }, > - { .mbps = 1099, .reg = 0x74 }, > + { .mbps = 80, .reg = 0x00 }, > + { .mbps = 90, .reg = 0x20 }, > + { .mbps = 100, .reg = 0x40 }, > + { .mbps = 110, .reg = 0x02 }, > + { .mbps = 130, .reg = 0x22 }, > + { .mbps = 140, .reg = 0x42 }, > + { .mbps = 150, .reg = 0x04 }, > + { .mbps = 170, .reg = 0x24 }, > + { .mbps = 180, .reg = 0x44 }, > + { .mbps = 200, .reg = 0x06 }, > + { .mbps = 220, .reg = 0x26 }, > + { .mbps = 240, .reg = 0x46 }, > + { .mbps = 250, .reg = 0x08 }, > + { .mbps = 270, .reg = 0x28 }, > + { .mbps = 300, .reg = 0x0a }, > + { .mbps = 330, .reg = 0x2a }, > + { .mbps = 360, .reg = 0x4a }, > + { .mbps = 400, .reg = 0x0c }, > + { .mbps = 450, .reg = 0x2c }, > + { .mbps = 500, .reg = 0x0e }, > + { .mbps = 550, .reg = 0x2e }, > + { .mbps = 600, .reg = 0x10 }, > + { .mbps = 650, .reg = 0x30 }, > + { .mbps = 700, .reg = 0x12 }, > + { .mbps = 750, .reg = 0x32 }, > + { .mbps = 800, .reg = 0x52 }, > + { .mbps = 850, .reg = 0x72 }, > + { .mbps = 900, .reg = 0x14 }, > + { .mbps = 950, .reg = 0x34 }, > + { .mbps = 1000, .reg = 0x54 }, > + { .mbps = 1050, .reg = 0x74 }, > { .mbps = 1125, .reg = 0x16 }, > { /* sentinel */ }, > }; -- Regards, Laurent Pinchart