linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org,
	dri-devel@lists.freedesktop.org, netdev@vger.kernel.org,
	linux-media@vger.kernel.org, linux-mmc@vger.kernel.org,
	netfilter-devel@vger.kernel.org, linux-nfs@vger.kernel.org,
	linux-raid@vger.kernel.org, linux-spi@vger.kernel.org,
	linux-mtd@lists.infradead.org, linux-rdma@vger.kernel.org,
	fcoe-devel@open-fcoe.org, alsa-devel@alsa-project.org,
	linux-fbdev@vger.kernel.org, xen-devel@lists.xenproject.org,
	davem@davemloft.net, airlied@linux.ie,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] uapi: use wildcards to list files
Date: Tue, 03 Jan 2017 22:37:04 +0100	[thread overview]
Message-ID: <2108827.WpE3IvfEdH@wuerfel> (raw)
In-Reply-To: <1483454144-10519-1-git-send-email-nicolas.dichtel@6wind.com>

On Tuesday, January 3, 2017 3:35:44 PM CET Nicolas Dichtel wrote:
> Regularly, when a new header is created in include/uapi/, the developer
> forgets to add it in the corresponding Kbuild file. This error is usually
> detected after the release is out.
> 
> In fact, all headers under include/uapi/ should be exported, so let's
> use wildcards.

I think the idea makes a lot of sense: if a header is in uapi, we should
really export it. However, using a wildcard expression seems a bit
backwards here, I think we should make this implicit and not have the
Kbuild file at all.

The "header-y" syntax was originally added back when the uapi headers
were mixed with the internal headers in the same directory. After
David Howells introduced the separate directory for uapi, it has
become a bit redundant.

Can you try to modify scripts/Makefile.headersinst instead so we
can simply remove the Kbuild files entirely?

	Arnd

  parent reply	other threads:[~2017-01-03 21:38 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161203.192346.1198940437155108508.davem@davemloft.net>
2017-01-03 14:35 ` [PATCH] uapi: use wildcards to list files Nicolas Dichtel
2017-01-03 15:56   ` David Miller
2017-01-03 21:37   ` Arnd Bergmann [this message]
2017-01-04  9:03     ` Nicolas Dichtel
2017-01-06  9:43       ` [PATCH v2 0/7] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-06  9:43         ` [PATCH v2 1/7] arm: put types.h in uapi Nicolas Dichtel
2017-01-09 11:33           ` Arnd Bergmann
2017-01-09 12:00             ` Russell King - ARM Linux
2017-01-06  9:43         ` [PATCH v2 2/7] h8300: put bitsperlong.h " Nicolas Dichtel
2017-01-06  9:43         ` [PATCH v2 3/7] nios2: put setup.h " Nicolas Dichtel
2017-01-09 11:33           ` Arnd Bergmann
2017-01-06  9:43         ` [PATCH v2 4/7] x86: put msr-index.h " Nicolas Dichtel
2017-01-06 12:14           ` Borislav Petkov
2017-01-06 20:50           ` Andy Shevchenko
2017-01-06  9:43         ` [PATCH v2 5/7] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-01-06  9:43         ` [PATCH v2 6/7] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-01-06  9:43         ` [PATCH v2 7/7] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-09 10:01           ` Daniel Vetter
2017-01-09 12:01           ` Russell King - ARM Linux
2017-01-09 12:56           ` Christoph Hellwig
2017-01-12 15:52             ` Nicolas Dichtel
2017-01-12 16:28               ` Jan Engelhardt
2017-01-12 16:32                 ` Nicolas Dichtel
2017-01-13  1:04                   ` Jeff Epler
2017-01-11 18:14           ` [Linux-c6x-dev] " Mark Salter
2017-01-09 11:33         ` [PATCH v2 0/7] " Arnd Bergmann
2017-01-11 12:42           ` Jesper Nilsson
2017-01-13 10:46           ` [PATCH v3 0/8] " Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 1/8] arm: put types.h in uapi Nicolas Dichtel
2017-01-13 17:06               ` Russell King - ARM Linux
2017-01-13 10:46             ` [PATCH v3 2/8] h8300: put bitsperlong.h " Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 3/8] nios2: put setup.h " Nicolas Dichtel
2017-01-13 10:55               ` Tobias Klauser
2017-01-13 10:46             ` [PATCH v3 4/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 5/8] Makefile.headersinst: cleanup input files Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 6/8] Makefile.headersinst: remove destination-y option Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 7/8] uapi: export all headers under uapi directories Nicolas Dichtel
2017-01-13 10:46             ` [PATCH v3 8/8] uapi: export all arch specifics directories Nicolas Dichtel
2017-01-13 15:36             ` David Howells
2017-01-13 16:01               ` [PATCH v3 1/8] arm: put types.h in uapi Nicolas Dichtel
2017-01-13 16:19                 ` Russell King - ARM Linux
2017-01-13 15:43             ` David Howells
2017-01-13 16:08               ` [PATCH v3 4/8] x86: stop exporting msr-index.h to userland Nicolas Dichtel
2017-01-13 16:38                 ` Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2108827.WpE3IvfEdH@wuerfel \
    --to=arnd@arndb.de \
    --cc=airlied@linux.ie \
    --cc=alsa-devel@alsa-project.org \
    --cc=davem@davemloft.net \
    --cc=dhowells@redhat.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fcoe-devel@open-fcoe.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).