From: Luis de Oliveira <luis.oliveira@synopsys.com>
To: <Eugen.Hristev@microchip.com>, <luis.oliveira@synopsys.com>,
<linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <joao.pinto@synopsys.com>, <festevam@gmail.com>,
<mchehab@kernel.org>, <gregkh@linuxfoundation.org>,
<davem@davemloft.net>, <akpm@linux-foundation.org>,
<arnd@arndb.de>, <hans.verkuil@cisco.com>,
<laurent.pinchart@ideasonboard.com>, <geert@linux-m68k.org>,
<narmstrong@baylibre.com>, <p.zabel@pengutronix.de>,
<treding@nvidia.com>, <maxime.ripard@bootlin.com>,
<todor.tomov@linaro.org>
Subject: Re: [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver
Date: Thu, 10 Jan 2019 16:18:38 +0000 [thread overview]
Message-ID: <2407a3ca-1a83-5685-c26c-a922251b2943@synopsys.com> (raw)
In-Reply-To: <4db76eb2-460f-c644-6dbd-370b07b2def8@microchip.com>
On 09-Jan-19 13:07, Eugen.Hristev@microchip.com wrote:
>
>
> On 19.10.2018 15:52, Luis Oliveira wrote:
>> Add the Synopsys MIPI CSI-2 controller driver. This
>> controller driver is divided in platform dependent functions
>> and core functions. It also includes a platform for future
>> DesignWare drivers.
>>
>> Signed-off-by: Luis Oliveira <lolivei@synopsys.com>
>> ---
>> Changelog
>> v2-V3
>> - exposed IPI settings to userspace
>> - fixed headers
>>
>> MAINTAINERS | 11 +
>> drivers/media/platform/dwc/Kconfig | 30 +-
>> drivers/media/platform/dwc/Makefile | 2 +
>> drivers/media/platform/dwc/dw-csi-plat.c | 699 +++++++++++++++++++++++++++++++
>> drivers/media/platform/dwc/dw-csi-plat.h | 77 ++++
>> drivers/media/platform/dwc/dw-mipi-csi.c | 494 ++++++++++++++++++++++
>> drivers/media/platform/dwc/dw-mipi-csi.h | 202 +++++++++
>> include/media/dwc/dw-mipi-csi-pltfrm.h | 102 +++++
>> 8 files changed, 1616 insertions(+), 1 deletion(-)
>> create mode 100644 drivers/media/platform/dwc/dw-csi-plat.c
>> create mode 100644 drivers/media/platform/dwc/dw-csi-plat.h
>> create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.c
>> create mode 100644 drivers/media/platform/dwc/dw-mipi-csi.h
>> create mode 100644 include/media/dwc/dw-mipi-csi-pltfrm.h
>>
>
> [snip]
>
>> +/* Video formats supported by the MIPI CSI-2 */
>> +const struct mipi_fmt dw_mipi_csi_formats[] = {
>> + {
>> + /* RAW 8 */
>> + .code = MEDIA_BUS_FMT_SBGGR8_1X8,
>> + .depth = 8,
>> + },
>> + {
>> + /* RAW 10 */
>> + .code = MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE,
>> + .depth = 10,
>> + },
>
> Hi Luis,
>
> Any reason why RAW12 format is not handled here ?
>
> Here, namely MEDIA_BUS_FMT_SBGGR12_1X12 etc.
>
Hi Eugen,
My Hw testing setup currently does not support it, so I didn't add it.
>> + {
>> + /* RGB 565 */
>> + .code = MEDIA_BUS_FMT_RGB565_2X8_BE,
>> + .depth = 16,
>> + },
>> + {
>> + /* BGR 565 */
>> + .code = MEDIA_BUS_FMT_RGB565_2X8_LE,
>> + .depth = 16,
>> + },
>> + {
>> + /* RGB 888 */
>> + .code = MEDIA_BUS_FMT_RGB888_2X12_LE,
>> + .depth = 24,
>> + },
>> + {
>> + /* BGR 888 */
>> + .code = MEDIA_BUS_FMT_RGB888_2X12_BE,
>> + .depth = 24,
>> + },
>> +};
>
> [snip]
>
>> +
>> +void dw_mipi_csi_set_ipi_fmt(struct mipi_csi_dev *csi_dev)
>> +{
>> + struct device *dev = csi_dev->dev;
>> +
>> + if (csi_dev->ipi_dt)
>> + dw_mipi_csi_write(csi_dev, reg.IPI_DATA_TYPE, csi_dev->ipi_dt);
>> + else {
>> + switch (csi_dev->fmt->code) {
>> + case MEDIA_BUS_FMT_RGB565_2X8_BE:
>> + case MEDIA_BUS_FMT_RGB565_2X8_LE:
>> + dw_mipi_csi_write(csi_dev,
>> + reg.IPI_DATA_TYPE, CSI_2_RGB565);
>> + dev_dbg(dev, "DT: RGB 565");
>> + break;
>> +
>> + case MEDIA_BUS_FMT_RGB888_2X12_LE:
>> + case MEDIA_BUS_FMT_RGB888_2X12_BE:
>> + dw_mipi_csi_write(csi_dev,
>> + reg.IPI_DATA_TYPE, CSI_2_RGB888);
>> + dev_dbg(dev, "DT: RGB 888");
>> + break;
>> + case MEDIA_BUS_FMT_SBGGR10_2X8_PADHI_BE:
>> + dw_mipi_csi_write(csi_dev,
>> + reg.IPI_DATA_TYPE, CSI_2_RAW10);
>> + dev_dbg(dev, "DT: RAW 10");
>> + break;
>> + case MEDIA_BUS_FMT_SBGGR8_1X8:
>> + dw_mipi_csi_write(csi_dev,
>> + reg.IPI_DATA_TYPE, CSI_2_RAW8);
>> + dev_dbg(dev, "DT: RAW 8");
>> + break;
>
> Same here, in CSI_2_RAW12 case it will default to a RGB565 case.
>
> Thanks,
>
> Eugen
>
>
I will try to add the support for this data type in my next patchset if not I
will flag it as unsupported for now in the commit message and code.
Thanks for your review,
Luis
>
>> + default:
>> + dw_mipi_csi_write(csi_dev,
>> + reg.IPI_DATA_TYPE, CSI_2_RGB565);
>> + dev_dbg(dev, "Error");
>> + break;
>> + }
>> + }
>> +}
>> +
>
> [snip]
>
next prev parent reply other threads:[~2019-01-10 16:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-19 12:52 [V3, 0/4] platform: dwc: Add of DesignWare MIPI CSI-2 Host Luis Oliveira
2018-10-19 12:52 ` [V3, 1/4] Documentation: dt-bindings: phy: Document the Synopsys MIPI DPHY Rx bindings Luis Oliveira
2018-10-24 17:36 ` Rob Herring
2018-11-13 8:58 ` Luis Oliveira
2018-11-13 9:30 ` Luis de Oliveira
2018-11-14 20:08 ` Laurent Pinchart
2018-10-19 12:52 ` [V3, 2/4] media: platform: dwc: Add DW MIPI DPHY Rx platform Luis Oliveira
2019-01-07 11:58 ` Sakari Ailus
2019-01-08 9:17 ` Luis de Oliveira
2018-10-19 12:52 ` [V3, 3/4] Documentation: dt-bindings: media: Document bindings for DW MIPI CSI-2 Host Luis Oliveira
2018-10-24 17:40 ` Rob Herring
2018-11-13 10:00 ` Luis de Oliveira
2018-11-14 20:16 ` Laurent Pinchart
2018-10-24 17:41 ` Rob Herring
2018-11-13 10:00 ` Luis de Oliveira
2019-01-11 15:29 ` Eugen.Hristev
2018-10-19 12:52 ` [V3, 4/4] media: platform: dwc: Add MIPI CSI-2 controller driver Luis Oliveira
2018-11-14 20:22 ` Laurent Pinchart
2019-01-10 17:00 ` Luis de Oliveira
2018-12-10 12:39 ` Eugen.Hristev
2019-01-10 16:11 ` Luis de Oliveira
2019-01-09 13:07 ` Eugen.Hristev
2019-01-10 16:18 ` Luis de Oliveira [this message]
2019-01-11 7:25 ` Eugen.Hristev
2019-01-11 8:11 ` Luis de Oliveira
2019-01-11 9:49 ` Eugen.Hristev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2407a3ca-1a83-5685-c26c-a922251b2943@synopsys.com \
--to=luis.oliveira@synopsys.com \
--cc=Eugen.Hristev@microchip.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=festevam@gmail.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=joao.pinto@synopsys.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=todor.tomov@linaro.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).