From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3AB1C433DF for ; Wed, 14 Oct 2020 16:52:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75AE72222E for ; Wed, 14 Oct 2020 16:52:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731323AbgJNQwv (ORCPT ); Wed, 14 Oct 2020 12:52:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53704 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726459AbgJNQwu (ORCPT ); Wed, 14 Oct 2020 12:52:50 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE463C061755; Wed, 14 Oct 2020 09:52:50 -0700 (PDT) Received: from [IPv6:2804:14c:483:7f66::1004] (unknown [IPv6:2804:14c:483:7f66::1004]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: koike) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 6B07F1F44C76; Wed, 14 Oct 2020 17:52:44 +0100 (BST) Subject: Re: [PATCH v5 8/9] arm64: dts: rockchip: add isp0 node for rk3399 To: Tomasz Figa Cc: linux-devicetree , Linux Media Mailing List , "open list:ARM/Rockchip SoC..." , Linux Kernel Mailing List , devel@driverdev.osuosl.org, Rob Herring , =?UTF-8?Q?Heiko_St=c3=bcbner?= , Hans Verkuil , kernel@collabora.com, Dafna Hirschfeld , Ezequiel Garcia , Mark Rutland , karthik.poduval@gmail.com, jbx6244@gmail.com, Eddie Cai , Shunqian Zheng , Robin Murphy References: <20200722155533.252844-1-helen.koike@collabora.com> <20200722155533.252844-9-helen.koike@collabora.com> <20200926130005.GC3781977@chromium.org> <905118dd-f108-6bc0-4cf0-9544fab51690@collabora.com> From: Helen Koike Message-ID: <243b5257-0f94-a43d-e623-70ca54d0e9d9@collabora.com> Date: Wed, 14 Oct 2020 13:52:39 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Thank you Tomasz and Robin for your comments, On 10/14/20 1:43 PM, Tomasz Figa wrote: > On Wed, Oct 14, 2020 at 6:27 PM Helen Koike wrote: >> >> Hi Tomasz, >> >> On 9/26/20 10:00 AM, Tomasz Figa wrote: >>> Hi Helen, >>> >>> On Wed, Jul 22, 2020 at 12:55:32PM -0300, Helen Koike wrote: >>>> From: Shunqian Zheng >>>> >>>> RK3399 has two ISPs, but only isp0 was tested. >>>> Add isp0 node in rk3399 dtsi >>>> >>>> Verified with: >>>> make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml >>>> >>>> Signed-off-by: Shunqian Zheng >>>> Signed-off-by: Jacob Chen >>>> Signed-off-by: Helen Koike >>>> >>>> --- >>>> >>>> V4: >>>> - update clock names >>>> >>>> V3: >>>> - clean up clocks >>>> >>>> V2: >>>> - re-order power-domains property >>>> >>>> V1: >>>> This patch was originally part of this patchset: >>>> >>>> https://patchwork.kernel.org/patch/10267431/ >>>> >>>> The only difference is: >>>> - add phy properties >>>> - add ports >>>> --- >>>> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 25 ++++++++++++++++++++++++ >>>> 1 file changed, 25 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >>>> index dba9641947a3a..ed8ba75dbbce8 100644 >>>> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >>>> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >>>> @@ -1721,6 +1721,31 @@ vopb_mmu: iommu@ff903f00 { >>>> status = "disabled"; >>>> }; >>>> >>>> + isp0: isp0@ff910000 { >>>> + compatible = "rockchip,rk3399-cif-isp"; >>>> + reg = <0x0 0xff910000 0x0 0x4000>; >>>> + interrupts = ; >>>> + clocks = <&cru SCLK_ISP0>, >>>> + <&cru ACLK_ISP0_WRAPPER>, >>>> + <&cru HCLK_ISP0_WRAPPER>; >>>> + clock-names = "isp", "aclk", "hclk"; >>>> + iommus = <&isp0_mmu>; >>>> + phys = <&mipi_dphy_rx0>; >>>> + phy-names = "dphy"; >>>> + power-domains = <&power RK3399_PD_ISP0>; >>> >>> Should this have status = "disabled" too? The mipi_dphy_rx0 node is >>> disabled by default too, so in the default configuration the driver >>> would always fail to probe. >> >> I'm thinking what is the overall guideline here. >> Since isp and mipi_dphy are always present in the rk3399, shouldn't they always be enabled? >> Or since they are only useful if a sensor is present, we should let the dts of the board to >> enable it? > > I don't have a strong opinion. I'm fine with enabling both by default > as well, as it shouldn't hurt. > > That said, I recall some alternative CIF IP block being present on > this SoC as well (and patches posted recently), which AFAIR can't be > activated at the same time as the ISP, so perhaps both of the > alternatives should be disabled by default? > > Best regards, > Tomasz > Based on these two last emails, I think it make sense to disable them by default. I'll just wait for feedback on patch 5/9 to submit an updated version. Thanks Helen