From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FA5BC4320A for ; Tue, 3 Aug 2021 08:00:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 23D9560EC0 for ; Tue, 3 Aug 2021 08:00:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234323AbhHCIAx (ORCPT ); Tue, 3 Aug 2021 04:00:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234284AbhHCIAx (ORCPT ); Tue, 3 Aug 2021 04:00:53 -0400 Received: from mail-wm1-x332.google.com (mail-wm1-x332.google.com [IPv6:2a00:1450:4864:20::332]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6FB7DC0613D5 for ; Tue, 3 Aug 2021 01:00:42 -0700 (PDT) Received: by mail-wm1-x332.google.com with SMTP id n28-20020a05600c3b9cb02902552e60df56so1558402wms.0 for ; Tue, 03 Aug 2021 01:00:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xQ4m8nY0R0gdaQ2/t/epPl2Yst37jmddCHkepiSD0C4=; b=Bw+xkG5sbehOUYrGhW3vuHjC0TodTkMZrfcQqx90U7cza0bBBP+1vYns95ZaSdpsaW 0ZejcJ4Vl0vp8xDbgM1uk3tTQkuD460xHm+MTBNVbOZuHGVyBCs0HFLhFINqMWGLY9sZ SuEMjTiYAkai4RKewsDrHd/xSHe5J+lQ8yvBTh5H+nE7akdFJjAkbHi7B16zwMAeN7nP it2zDi+0Jk2xm2q0urRgOdPZvXffKHfpiR2EPrBLK4pGR0givWjer6Bn3dI4vIi/DPQy 4ZDz/FGRU0R2IAyPvMMKAPoruwFrejYoxePAxZzNVUQDAvVgohV1+P4U56gUqpqZV7me FB0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xQ4m8nY0R0gdaQ2/t/epPl2Yst37jmddCHkepiSD0C4=; b=hoVlou6C+W6s3i65gpecjC9iwoZGk8RpU0YVqioqt/ntlQMmAUodiUuXONzf2z+KmU euvnI+qPhWXjXVyttL0fuD/q1Zh5XgRPDDDZqP/eEg1FinVASL110lxsQhfgOetol7IX UOffCfn7XAVnCvl7xtcJ2xVbrQg1u9IWM6sGgguRQ7r3m590TMA4Zd45lHOntZyXNSCq /JWbfJewIE0OfEmTp3zpwZRF4HTQKgbIBFuJtEuGUL6Agpy7qQQBtuhhyGKVewVbxnqh Fk29xGpZ3voT0we0BxN4dwWrAfT3rrSeeHK+vP3RWH/aXjOVKHoHNbfX2QvtHqxhH5Ui 31kQ== X-Gm-Message-State: AOAM532O3z4I/e917PUEOKT3t0DAWGBdFiRz0fMeuMfkHQkhfvFotu9B LQAxO+0wGzfIGVyBAqAo3S9VrxDKG1Gt5A== X-Google-Smtp-Source: ABdhPJwel4nkglJAenKOcjYpcxSacPWxMq2xkHmEmS8ycsumGKjElVh8s/Y1jXHSsXVTWplDeiJwSA== X-Received: by 2002:a1c:2314:: with SMTP id j20mr2951400wmj.30.1627977636036; Tue, 03 Aug 2021 01:00:36 -0700 (PDT) Received: from [192.168.1.11] (hst-221-68.medicom.bg. [84.238.221.68]) by smtp.googlemail.com with ESMTPSA id m9sm13534055wrz.75.2021.08.03.01.00.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 03 Aug 2021 01:00:34 -0700 (PDT) Subject: Re: [PATCH v3 7/7] media: venus: Set buffer to FW based on FW min count requirement. To: dikshita@codeaurora.org Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, vgarodia@codeaurora.org References: <1626246068-21023-1-git-send-email-dikshita@codeaurora.org> <1626246068-21023-8-git-send-email-dikshita@codeaurora.org> <6c8f0d013be8ba6d276afe04d6e0c840@codeaurora.org> From: Stanimir Varbanov Message-ID: <253417f1-579a-0a57-388b-7fb07fd83d9c@linaro.org> Date: Tue, 3 Aug 2021 11:00:32 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <6c8f0d013be8ba6d276afe04d6e0c840@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 8/2/21 10:50 AM, dikshita@codeaurora.org wrote: >>> req->count_min = inst->fw_min_cnt; >>> + >>> +    ret = hfi_plat->bufreq(¶ms, inst->session_type, buftype, req); >>> +    if (buftype == HFI_BUFFER_OUTPUT || buftype == HFI_BUFFER_OUTPUT2) >> >> ^^^^ >> >>> +        if (inst->fw_min_cnt != req->count_min) >>> +            inst->fw_min_cnt = req->count_min; >>> +    return ret; >>>  } >> >> Also in regards to inst->fw_min_cnt, can we pass fw_min_cnt as input to >> get_bufreq via 'req' structure, i.e. >> >> req.count_min = inst->fw_min_cnt; >> >> ret = venus_helper_get_bufreq(inst, type, &req); >> >> inst->fw_min_cnt = req.count_min >> >> ? >> > Sorry, I didn't get it, How is this different from the current > implementation? The difference is that platform_get_bufreq() will not modify any of 'struct venus_inst' members, i.e. platform_get_bufreq() is not supposed to change anything from input 'inst' argument. -- regards, Stan