From: Heiko Stuebner <heiko@sntech.de>
To: linux-media@vger.kernel.org, Helen Koike <helen.koike@collabora.com>
Cc: devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org,
linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
robh+dt@kernel.org, kernel@collabora.com,
hverkuil-cisco@xs4all.nl, dafna.hirschfeld@collabora.com,
mark.rutland@arm.com, karthik.poduval@gmail.com,
eddie.cai.linux@gmail.com, jbx6244@gmail.com,
zhengsq@rock-chips.com, robin.murphy@arm.com
Subject: Re: [PATCH v6 8/9] arm64: dts: rockchip: add isp0 node for rk3399
Date: Sun, 01 Nov 2020 11:54:36 +0100 [thread overview]
Message-ID: <25468331.GQUMHoxoIT@phil> (raw)
In-Reply-To: <20201020193850.1460644-9-helen.koike@collabora.com>
Am Dienstag, 20. Oktober 2020, 21:38:49 CET schrieb Helen Koike:
> From: Shunqian Zheng <zhengsq@rock-chips.com>
>
> RK3399 has two ISPs, but only isp0 was tested.
> Add isp0 node in rk3399 dtsi
>
> Verified with:
> make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
>
> Signed-off-by: Shunqian Zheng <zhengsq@rock-chips.com>
> Signed-off-by: Jacob Chen <jacob2.chen@rock-chips.com>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
looks good, and I'd like to apply this one after the drivers/media-patches
of this series got applied.
Thanks
Heiko
>
> ---
>
> Changes in v6:
> - Add status = "disabled" in the isp0 node
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 26 ++++++++++++++++++++++++
> 1 file changed, 26 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index ada724b12f014..af5f8e2c5e64d 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1723,6 +1723,32 @@ vopb_mmu: iommu@ff903f00 {
> status = "disabled";
> };
>
> + isp0: isp0@ff910000 {
> + compatible = "rockchip,rk3399-cif-isp";
> + reg = <0x0 0xff910000 0x0 0x4000>;
> + interrupts = <GIC_SPI 43 IRQ_TYPE_LEVEL_HIGH 0>;
> + clocks = <&cru SCLK_ISP0>,
> + <&cru ACLK_ISP0_WRAPPER>,
> + <&cru HCLK_ISP0_WRAPPER>;
> + clock-names = "isp", "aclk", "hclk";
> + iommus = <&isp0_mmu>;
> + phys = <&mipi_dphy_rx0>;
> + phy-names = "dphy";
> + power-domains = <&power RK3399_PD_ISP0>;
> + status = "disabled";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + };
> + };
> + };
> +
> isp0_mmu: iommu@ff914000 {
> compatible = "rockchip,iommu";
> reg = <0x0 0xff914000 0x0 0x100>, <0x0 0xff915000 0x0 0x100>;
>
next prev parent reply other threads:[~2020-11-01 10:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 19:38 [PATCH v6 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 Helen Koike
2020-10-20 19:38 ` [PATCH v6 1/9] media: staging: dt-bindings: rkisp1: add missing required nodes Helen Koike
2020-10-20 19:38 ` [PATCH v6 2/9] media: staging: dt-bindings: rkisp1: drop i2c unit address Helen Koike
2020-10-20 19:38 ` [PATCH v6 3/9] media: staging: dt-bindings: rkisp1: re-order properties Helen Koike
2020-10-20 19:38 ` [PATCH v6 4/9] media: staging: dt-bindings: rkisp1: drop parent unit address Helen Koike
2020-10-20 19:38 ` [PATCH v6 5/9] media: staging: rkisp1: remove unecessary clocks Helen Koike
2020-10-29 20:04 ` Rob Herring
2020-10-20 19:38 ` [PATCH v6 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging Helen Koike
2020-10-20 19:38 ` [PATCH v6 7/9] media: MAINTAINERS: rkisp1: add path to dt-bindings Helen Koike
2020-10-20 19:38 ` [PATCH v6 8/9] arm64: dts: rockchip: add isp0 node for rk3399 Helen Koike
2020-11-01 10:54 ` Heiko Stuebner [this message]
2020-10-20 19:38 ` [PATCH v6 9/9] arm64: dts: rockchip: add isp and sensors for Scarlet Helen Koike
2020-11-01 10:55 ` Heiko Stuebner
2020-11-30 16:28 ` (subset) [PATCH v6 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25468331.GQUMHoxoIT@phil \
--to=heiko@sntech.de \
--cc=dafna.hirschfeld@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=jbx6244@gmail.com \
--cc=karthik.poduval@gmail.com \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=zhengsq@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).