From: Steve Longerbeam <slongerbeam@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org
Cc: Gael PORTAY <gael.portay@collabora.com>,
Peter Seiderer <ps.report@gmx.net>
Subject: Re: [PATCH v4 0/3] media: imx: Stop stream before disabling IDMA channels
Date: Sun, 27 Jan 2019 14:41:32 -0800 [thread overview]
Message-ID: <258bd8ee-7a9a-3cb6-80e5-8eca1df17958@gmail.com> (raw)
In-Reply-To: <cfa25b62-0e2e-07df-11d2-811993682246@xs4all.nl>
Hi Hans,
On 1/21/19 11:34 PM, Hans Verkuil wrote:
> Hi Steve,
>
> On 01/22/2019 12:35 AM, Steve Longerbeam wrote:
>> Repeatedly sending a stream off immediately followed by stream on can
>> eventually cause a complete system hard lockup on the SabreAuto when
>> streaming from the ADV7180:
>>
>> while true; do v4l2-ctl -d4 --stream-mmap --stream-count=3; done
>>
>> Eventually this either causes the system lockup or EOF timeouts at all
>> subsequent stream on, until a system reset.
>>
>> The lockup occurs when disabling the IDMA channels at stream off. Stopping
>> the video data stream entering the IDMA channel before disabling the
>> channel itself appears to be a reliable fix for the hard lockup.
>>
>> In the CSI subdevice, this can be done by disabling the CSI before
>> disabling the CSI IDMA channel, instead of after. In the IC-PRPENVVF
>> subdevice, this can be done by stopping upstream before disabling the
>> PRPENC/VF IDMA channel.
> Please let me know when you are satisfied with this patch series and I
> can make a pull request for this.
I'm satisfied with it now, it addresses Philipp's concerns from v3.
Also Gael reported successful testing.
Steve
>
> Thanks!
>
> Hans
>
>> History:
>> v4:
>> - Disabling SMFC will have no effect if both CSI's are streaming. So
>> go back to disabling CSI before channel as in v2, but split up
>> csi_idmac_stop such that ipu_csi_disable can still be called within
>> csi_stop.
>>
>> v3:
>> - Switch to disabling the SMFC before the channel, instead of the CSI
>> before the channel.
>>
>> v2:
>> - Whitespace fixes
>> - Add Fixes: and Cc: stable@vger.kernel.org
>> - No functional changes.
>>
>>
>> Steve Longerbeam (3):
>> media: imx: csi: Disable CSI immediately after last EOF
>> media: imx: csi: Stop upstream before disabling IDMA channel
>> media: imx: prpencvf: Stop upstream before disabling IDMA channel
>>
>> drivers/staging/media/imx/imx-ic-prpencvf.c | 26 ++++++++-----
>> drivers/staging/media/imx/imx-media-csi.c | 42 +++++++++++++--------
>> 2 files changed, 44 insertions(+), 24 deletions(-)
>>
next prev parent reply other threads:[~2019-01-27 22:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 23:35 [PATCH v4 0/3] media: imx: Stop stream before disabling IDMA channels Steve Longerbeam
2019-01-21 23:35 ` [PATCH v4 1/3] media: imx: csi: Disable CSI immediately after last EOF Steve Longerbeam
2019-01-21 23:35 ` [PATCH v4 2/3] media: imx: csi: Stop upstream before disabling IDMA channel Steve Longerbeam
2019-01-21 23:35 ` [PATCH v4 3/3] media: imx: prpencvf: " Steve Longerbeam
2019-01-22 7:34 ` [PATCH v4 0/3] media: imx: Stop stream before disabling IDMA channels Hans Verkuil
2019-01-27 22:41 ` Steve Longerbeam [this message]
2019-01-22 14:45 ` Gaël PORTAY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=258bd8ee-7a9a-3cb6-80e5-8eca1df17958@gmail.com \
--to=slongerbeam@gmail.com \
--cc=gael.portay@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=ps.report@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).