linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Naresh Kamboju <naresh.kamboju@linaro.org>
Cc: linux-media@vger.kernel.org,
	open list <linux-kernel@vger.kernel.org>,
	Sami Tolvanen <samitolvanen@google.com>,
	paul.kocialkowski@bootlin.com, ezequiel@collabora.com,
	treding@nvidia.com, niklas.soderlund+renesas@ragnatech.se,
	sakari.ailus@linux.intel.com,
	Hans Verkuil <hans.verkuil@cisco.com>,
	mchehab@kernel.org, lkft-triage@lists.linaro.org
Subject: Re: test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4
Date: Tue, 28 May 2019 13:57:19 +0200	[thread overview]
Message-ID: <29b08b95-ae5b-2989-8f09-93fe702aef29@xs4all.nl> (raw)
In-Reply-To: <CA+G9fYu-guJaWDrEp5=KeJsje6Teo-V=_AhFStf0gnLk-QNfzA@mail.gmail.com>

On 5/28/19 12:16 PM, Naresh Kamboju wrote:
> Hi Hans,
> 
> On Mon, 20 May 2019 at 19:26, Naresh Kamboju <naresh.kamboju@linaro.org> wrote:
>>
>> Hi Hans,
>>
>> On Mon, 13 May 2019 at 19:08, Hans Verkuil <hverkuil-cisco@xs4all.nl> wrote:
>>>
>>> On 5/13/19 3:32 PM, Naresh Kamboju wrote:
>>>> Do you see test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4
>>>> kernel branches ?
>>>
>>> Probably related to commit 8a7c5594c0202 (media: v4l2-ioctl: clear fields in s_parm).
>>
>> I have cherry-picked on stable rc 4.9 branch and tested and test got
>> PASS on x86_64.
> 
> I have cherry-picked for stable -rc 4.14 and 4.9 and test got PASS.

Just to be clear: you cherry-picked commit 8a7c5594c0202 (media: v4l2-ioctl: clear
fields in s_parm) for both 4.9 and 4.14, right?

If so, feel free to post that patch to the stable mailinglist for those kernels.
Make sure you CC me when you do that.

> 
> do you want to queue this for stable rc 4.14 and 4.9 ?
> 
> I have tested for 4.4 with patch applied but failed with below error.
> 
> test VIDIOC_ENUM_FMT/FRAMESIZES/FRAMEINTERVALS: OK
>  warn: ../../../v4l-utils-1.16.0/utils/v4l2-compliance/v4l2-test-formats.cpp(1237):
> S_PARM is supported but doesn't report V4L2_CAP_TIMEPERFRAME
>  fail: ../../../v4l-utils-1.16.0/utils/v4l2-compliance/v4l2-test-formats.cpp(1139):
> node->has_frmintervals && !cap->capability
> test VIDIOC_G/S_PARM: FAIL

You probably need commit f63998331935 ([media] vivid: set V4L2_CAP_TIMEPERFRAME)
and possibly commit 3f122df4a2ba (media: vivid: do not implement VIDIOC_S_PARM for output streams).

Regards,

	Hans

> 
> 4.4 - failed log
> https://lkft.validation.linaro.org/scheduler/job/746548#L1678
> 
> ref:
> 4.14 pass log,
> https://lkft.validation.linaro.org/scheduler/job/739126#L1843
> 
> 4.9 pass log,
> https://lkft.validation.linaro.org/scheduler/job/736243#L1744
> 
> - Naresh
> 


  reply	other threads:[~2019-05-28 11:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-13 13:32 test VIDIOC_G/S_PARM: FAIL on stable 4.14, 4.9 and 4.4 Naresh Kamboju
2019-05-13 13:38 ` Hans Verkuil
2019-05-20 13:56   ` Naresh Kamboju
2019-05-28 10:16     ` Naresh Kamboju
2019-05-28 11:57       ` Hans Verkuil [this message]
2019-05-28 12:23         ` Naresh Kamboju

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=29b08b95-ae5b-2989-8f09-93fe702aef29@xs4all.nl \
    --to=hverkuil-cisco@xs4all.nl \
    --cc=ezequiel@collabora.com \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkft-triage@lists.linaro.org \
    --cc=mchehab@kernel.org \
    --cc=naresh.kamboju@linaro.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=samitolvanen@google.com \
    --cc=treding@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).