From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDFB0C433DB for ; Thu, 24 Dec 2020 14:15:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 822782246B for ; Thu, 24 Dec 2020 14:15:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728043AbgLXOOz (ORCPT ); Thu, 24 Dec 2020 09:14:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55356 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726609AbgLXOOz (ORCPT ); Thu, 24 Dec 2020 09:14:55 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B0BB8C06179C; Thu, 24 Dec 2020 06:14:14 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id i9so2302261wrc.4; Thu, 24 Dec 2020 06:14:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=5IQf/4MAsKE+WTlNyQCuo6jepc1CwhVN6xmkcDb3fIU=; b=nf8307rNrKyayWyufbV1EUOx8jMRH6o3Gm83koiFlra3TmbAw2CLkRj6RU3AR4BWe0 W4IhyHFn7uM0YyUBigTpmrl8TN5GgU6EUhQ8PkBjYuPEtHLbvz5zxtPl6flbqlh6Yqsq cJKrFj5QGtpVtDbhQe0JMYOw3LnkTxsuImQW65vtTB/aFvNqvjKnX42SEI6eIN4dE+s+ 67ZuUGW9ndnOM4vjHoZBa2kUw92bJ1EdeLDLyZ23rW+YFeoeHfSmWikPf7CHvon16JK4 vzqw+q7eF42PVLxAGdvfuE6wk9UWjRwmK9tgmifeh0WAJdlw/sYqqXmQ2ZSNzUg29Rx1 Jksg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=5IQf/4MAsKE+WTlNyQCuo6jepc1CwhVN6xmkcDb3fIU=; b=tyxFljXOn5LVvo69phxmdHT59i+m5rRLJ/djfSh3uGj+4EDqHnP5QiEN5KNfnHs2Yd ifcuG5D83cL2KtQW3hOItNlsPJaoAW+V+be/3+OoMNzkpPhcZnWiWPC1hI1Z7g+RCuY4 bFlTwFHj5HVKkv8hkFey05owh2U42jRh/6iicAGgJlPUHHDbqAKzboJjdUIR5XVgw2wc Jq455gqQHviLIRgDu/Xvpio1Dt2GB8NvLv9hzEP8OfeC4e9TyRD1oiHbUdiBLWtUCfqd jMzlUp+4yR/7uC/bIQy77fJUkmLV+VQpG2toG3U/07qkGzXaN0y7iQ4H8Ur8Ao6ubM48 6YWQ== X-Gm-Message-State: AOAM530wvwu2BQt2hreTSq3Uka82YeeXlzX39wEDp5cTLiypCYlWGSes 8/afmonquKmFfvDvrw4xC/c= X-Google-Smtp-Source: ABdhPJxGYjXpOyykLaMQVjAfA6eADmsUdE3HMzSHLW25ZR9l3/ybTlPCveS+Hf2tvWrIkS5u+eLs3Q== X-Received: by 2002:adf:dc8b:: with SMTP id r11mr34994434wrj.131.1608819253334; Thu, 24 Dec 2020 06:14:13 -0800 (PST) Received: from [192.168.1.211] ([2.31.224.116]) by smtp.gmail.com with ESMTPSA id z22sm3506603wml.1.2020.12.24.06.14.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Dec 2020 06:14:12 -0800 (PST) Subject: Re: [PATCH v3 05/14] software_node: unregister software_nodes in reverse order To: Andy Shevchenko Cc: Linux Kernel Mailing List , ACPI Devel Maling List , Linux Media Mailing List , devel@acpica.org, "Rafael J. Wysocki" , Len Brown , Greg Kroah-Hartman , Yong Zhi , Sakari Ailus , Bingbu Cao , Tian Shu Qiu , Mauro Carvalho Chehab , Robert Moore , Erik Kaneda , Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Laurent Pinchart , Jacopo Mondi , kieran.bingham+renesas@ideasonboard.com, Hans Verkuil , Marco Felsch , niklas.soderlund+renesas@ragnatech.se, Steve Longerbeam , "Krogerus, Heikki" , Linus Walleij , kernel test robot , Dan Carpenter , Laurent Pinchart References: <20201224010907.263125-1-djrscally@gmail.com> <20201224010907.263125-6-djrscally@gmail.com> From: Daniel Scally Message-ID: <2b415312-fe30-c73b-0077-4ec2a07116df@gmail.com> Date: Thu, 24 Dec 2020 14:14:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On 24/12/2020 14:12, Andy Shevchenko wrote: > On Thu, Dec 24, 2020 at 4:00 PM Daniel Scally wrote: >> On 24/12/2020 12:13, Andy Shevchenko wrote: >>> On Thu, Dec 24, 2020 at 3:12 AM Daniel Scally wrote: > ... > >>>> + * Unregister multiple software nodes at once. The array will be unwound in >>>> + * reverse order (i.e. last entry first) and thus if any member of the array >>>> + * has its .parent member set then they should appear later in the array such >>>> + * that they are unregistered first. >>> I'm, as being not a native speaker, a bit confused by this comment. >>> The idea is that children are unregistered first. Can you try to make >>> it more clear maybe? >> Sure, how about: >> >> The array will be unwound in reverse order (i.e. last entry first). If >> any member of the array is a child of another member then the child must > children ? Yes, you are right of course. > >> appear later in the array than their parent, so that they are >> unregistered first. > I think with the above change it will be better, yes. > Ok, done.