From: Johan Jonker <jbx6244@gmail.com>
To: Helen Koike <helen.koike@collabora.com>,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org,
robh+dt@kernel.org, heiko@sntech.de, hverkuil-cisco@xs4all.nl,
kernel@collabora.com, dafna.hirschfeld@collabora.com,
ezequiel@collabora.com, mark.rutland@arm.com,
karthik.poduval@gmail.com, kishon@ti.com
Subject: Re: [PATCH v2 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 bindings out of staging
Date: Thu, 23 Apr 2020 15:33:41 +0200 [thread overview]
Message-ID: <32115405-8a29-29ee-69e2-7c662689ecfd@gmail.com> (raw)
In-Reply-To: <20200403161538.1375908-7-helen.koike@collabora.com>
Hi Helen,
> clocks:
> items:
> - description: ISP clock
> - description: ISP AXI clock clock
> - description: ISP AXI clock wrapper clock
> - description: ISP AHB clock clock
Too many clocks here ^
Too many spaces here ^
> - description: ISP AHB wrapper clock
We can expect 4 to 5 clocks.
With 5 clocks and a different description this layout is maybe not so handy.
As first change:
clocks:
maxItems: 5
description:
rk3399 clocks
ISP clock
ISP AXI clock
ISP AXI wrapper clock
ISP AHB clock
ISP AHB wrapper clock
And then later:
clocks:
maxItems: 5
description:
rk3288 clocks
ISP clock
ISP AXI clock
ISP AHB clock
ISP Pixel clock
ISP JPEG source clock
rk3399 clocks
ISP clock
ISP AXI clock
ISP AXI wrapper clock
ISP AHB clock
ISP AHB wrapper clock
With 4 clocks:
clocks:
minItems: 4
maxItems: 5
description:
rk1808 clocks
rk3288 clocks
rk3326 clocks
rk3368 clocks
rk3399 clocks
[..]
>
> clock-names:
> items:
> - const: clk_isp
> - const: aclk_isp
> - const: aclk_isp_wrap
> - const: hclk_isp
> - const: hclk_isp_wrap
On 4/3/20 6:15 PM, Helen Koike wrote:
> Move rkisp1 bindings to Documentation/devicetree/bindings/media
>
> Verified with:
> make ARCH=arm64 dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/media/rockchip-isp1.yaml
>
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
> ---
>
> V2:
> - no changes
>
> .../devicetree/bindings/media/rockchip-isp1.yaml | 0
> 1 file changed, 0 insertions(+), 0 deletions(-)
> rename {drivers/staging/media/rkisp1/Documentation => Documentation}/devicetree/bindings/media/rockchip-isp1.yaml (100%)
>
> diff --git a/drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml b/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> similarity index 100%
> rename from drivers/staging/media/rkisp1/Documentation/devicetree/bindings/media/rockchip-isp1.yaml
> rename to Documentation/devicetree/bindings/media/rockchip-isp1.yaml
>
next prev parent reply other threads:[~2020-04-23 13:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 16:15 [PATCH v2 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 Helen Koike
2020-04-03 16:15 ` [PATCH v2 1/9] media: staging: dt-bindings: rkisp1: add missing required nodes Helen Koike
2020-04-03 16:15 ` [PATCH v2 2/9] media: staging: dt-bindings: rkisp1: add required items in i2c example Helen Koike
2020-04-03 16:15 ` [PATCH v2 3/9] media: staging: dt-bindings: rkisp1: re-order properties Helen Koike
2020-04-03 16:15 ` [PATCH v2 4/9] media: staging: dt-bindings: phy-rockchip-dphy-rx0: remove non-used reg property Helen Koike
2020-04-03 16:15 ` [PATCH v2 5/9] dt-bindings: phy: phy-rockchip-dphy-rx0: move rockchip dphy rx0 bindings out of staging Helen Koike
2020-04-14 18:08 ` Rob Herring
2020-04-03 16:15 ` [PATCH v2 6/9] dt-bindings: media: rkisp1: move rockchip-isp1 " Helen Koike
2020-04-14 18:08 ` Rob Herring
2020-04-23 12:36 ` Johan Jonker
2020-04-23 13:33 ` Johan Jonker [this message]
2020-04-03 16:15 ` [PATCH v2 7/9] media: MAINTAINERS: rkisp1: add path to dt-bindings Helen Koike
2020-04-17 7:18 ` Hans Verkuil
2020-04-17 7:30 ` Joe Perches
2020-05-09 12:51 ` Ezequiel Garcia
2020-04-23 12:48 ` Johan Jonker
2020-04-03 16:15 ` [PATCH v2 8/9] arm64: dts: rockchip: add rx0 mipi-phy for rk3399 Helen Koike
2020-05-09 12:53 ` Ezequiel Garcia
2020-04-03 16:15 ` [PATCH v2 9/9] arm64: dts: rockchip: add isp0 node " Helen Koike
2020-07-01 12:31 ` [PATCH v2 0/9] move Rockchip ISP bindings out of staging / add ISP DT nodes for RK3399 Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32115405-8a29-29ee-69e2-7c662689ecfd@gmail.com \
--to=jbx6244@gmail.com \
--cc=dafna.hirschfeld@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=helen.koike@collabora.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=karthik.poduval@gmail.com \
--cc=kernel@collabora.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).