Re: adv7280: Scrolling images on imx6

From: Frieder Schrempf <frieder.schrempf@kontron.de>
To: Fabio Estevam <festevam@gmail.com>
Cc: "Tim Harvey" <tharvey@gateworks.com>,
	"Steve Longerbeam" <slongerbeam@gmail.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	linux-media <linux-media@vger.kernel.org>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
	"Hans Verkuil" <hverkuil-cisco@xs4all.nl>,
	"Nicolas Dufresne" <nicolas@ndufresne.ca>
Subject: Re: adv7280: Scrolling images on imx6
Date: Tue, 27 Apr 2021 16:32:59 +0200	[thread overview]
Message-ID: <3c661333-4b92-67a8-54ee-2eee14fb0849@kontron.de> (raw)
In-Reply-To: <CAOMZO5BiYAMvVawZRAR9tbdf9XxicfdoX=V8HpYQNq5U4YZvfg@mail.gmail.com>

On 27.04.21 16:28, Fabio Estevam wrote:
> Hi Frieder,
> 
> On Tue, Apr 27, 2021 at 11:15 AM Frieder Schrempf
> <frieder.schrempf@kontron.de> wrote:
> 
>> You're welcome!
>>
>> Just a question: What issue do you see without Steve's patch?
> 
> Without Steve's patch, I see the captured image slowly scrolling
> vertically, like an old tube TV.
> 
> Once I apply it, the image becomes stable. The board I am currently
> using is based on an imx6dl and the ADV7180 is connected to the
> parallel CSI bus.
> 
>> I'm asking because with my setup with the imx7 CSI driver I'm getting a
>> stable image, but it has a vertical and horizontal offset that seems to
>> vary each time I enable the camera. I was wondering if this is maybe
>> caused by the missing frame skipping.
> 
> Yes, maybe the imx7 CSI driver needs this initial frame skipping mechanism too.
> 
>> But still I'm not really sure if we can compare this as I needed another
>> patch for the adv7180 driver to get it working with the i.MX8MM in the
>> first place:
>> https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.kontron-electronics.de%2Flinux%2Flinux%2F-%2Fcommit%2F0d90331a44d0f718b7327a94fc72612ddcb4ac0f&amp;data=04%7C01%7Cfrieder.schrempf%40kontron.de%7Ce015a3d00b6f4c26745b08d90988c0e2%7C8c9d3c973fd941c8a2b1646f3942daf1%7C0%7C0%7C637551305224798164%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=c2W1OlaTvbjBDxkbVvJJtgPCRnsi7sCIA1QgiF9nZEM%3D&amp;reserved=0.
> 
> Thanks for sharing your git tree.
> 
> In the next days, I will work on a different imx6dl board, with the
> adv7180 connected to the MIPI CSI2.
> 
> I see your tree contains some adv7180-m related patches. I will give
> it a try and report.
> 

Ah, I forgot that your setup uses the CSI interface and not MIPI CSI2. 
So it's indeed somewhat difficult to compare on that level.