From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
To: Mirela Rabulea <mirela.rabulea@nxp.com>,
"G.n. Zhou" <guoniu.zhou@nxp.com>,
"Mirela Rabulea (OSS)" <mirela.rabulea@oss.nxp.com>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"mchehab@kernel.org" <mchehab@kernel.org>,
Aisheng Dong <aisheng.dong@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Robert Chiras <robert.chiras@nxp.com>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
Peng Fan <peng.fan@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
"paul.kocialkowski@bootlin.com" <paul.kocialkowski@bootlin.com>,
Laurentiu Palcu <laurentiu.palcu@nxp.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"ezequiel@collabora.com" <ezequiel@collabora.com>
Subject: Re: [EXT] Re: [PATCH v14 2/2] arm64: dts: imx8: Add jpeg encoder/decoder nodes
Date: Tue, 14 Sep 2021 12:44:42 +0200 [thread overview]
Message-ID: <3d63d65d-c230-d3a8-56c2-5d2b08400497@xs4all.nl> (raw)
In-Reply-To: <71a3c9b7d13a60614b80fbaaa701a65fea91b404.camel@nxp.com>
On 14/09/2021 12:42, Mirela Rabulea wrote:
> Hi Hans,
>
> On Tue, 2021-09-14 at 09:11 +0200, Hans Verkuil wrote:
>> Caution: EXT Email
>>
>> Hi Mirela,
>>
>> On 19/06/2021 16:36, Mirela Rabulea (OSS) wrote:
>>> From: Mirela Rabulea <mirela.rabulea@nxp.com>
>>>
>>> Add dts for imaging subsytem, include jpeg nodes here.
>>> Tested on imx8qxp/qm.
>>
>> I've posted a pull request for the first bindings patch for v5.16, so
>> this dts patch can be merged
>> through whatever tree takes such dts patches.
>
> Thanks for the notice. I see the patch is already in linux-next. Any
> more action required from my behalf?
No, that's it.
Regards,
Hans
>
> Regards,
> Mirela
>
>>
>> Regards,
>>
>> Hans
>>
>>> Signed-off-by: Mirela Rabulea <mirela.rabulea@nxp.com>
>>> ---
>>> Changes in v14:
>>> Address feedback from Aisheng Dong and Ezequiel Garcia:
>>> - use imx8 instead of imx in patch subject
>>> - keep jpeg and LPCGs used by jpeg enabled by default in
>>> platform dts (no change here)
>>>
>>> .../arm64/boot/dts/freescale/imx8-ss-img.dtsi | 80
>>> +++++++++++++++++++
>>> .../boot/dts/freescale/imx8qm-ss-img.dtsi | 12 +++
>>> arch/arm64/boot/dts/freescale/imx8qm.dtsi | 2 +
>>> .../boot/dts/freescale/imx8qxp-ss-img.dtsi | 13 +++
>>> arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 2 +
>>> 5 files changed, 109 insertions(+)
>>> create mode 100644 arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
>>> create mode 100644 arch/arm64/boot/dts/freescale/imx8qm-ss-
>>> img.dtsi
>>> create mode 100644 arch/arm64/boot/dts/freescale/imx8qxp-ss-
>>> img.dtsi
>>>
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
>>> b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
>>> new file mode 100644
>>> index 000000000000..a90654155a88
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/freescale/imx8-ss-img.dtsi
>>> @@ -0,0 +1,80 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Copyright 2019-2021 NXP
>>> + * Zhou Guoniu <guoniu.zhou@nxp.com>
>>> + */
>>> +img_subsys: bus@58000000 {
>>> + compatible = "simple-bus";
>>> + #address-cells = <1>;
>>> + #size-cells = <1>;
>>> + ranges = <0x58000000 0x0 0x58000000 0x1000000>;
>>> +
>>> + img_ipg_clk: clock-img-ipg {
>>> + compatible = "fixed-clock";
>>> + #clock-cells = <0>;
>>> + clock-frequency = <200000000>;
>>> + clock-output-names = "img_ipg_clk";
>>> + };
>>> +
>>> + jpegdec: jpegdec@58400000 {
>>> + reg = <0x58400000 0x00050000>;
>>> + interrupts = <GIC_SPI 309 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 310 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 311 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 312 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&img_jpeg_dec_lpcg IMX_LPCG_CLK_0>,
>>> + <&img_jpeg_dec_lpcg IMX_LPCG_CLK_4>;
>>> + clock-names = "per", "ipg";
>>> + assigned-clocks = <&img_jpeg_dec_lpcg
>>> IMX_LPCG_CLK_0>,
>>> + <&img_jpeg_dec_lpcg
>>> IMX_LPCG_CLK_4>;
>>> + assigned-clock-rates = <200000000>, <200000000>;
>>> + power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>,
>>> + <&pd IMX_SC_R_MJPEG_DEC_S0>,
>>> + <&pd IMX_SC_R_MJPEG_DEC_S1>,
>>> + <&pd IMX_SC_R_MJPEG_DEC_S2>,
>>> + <&pd IMX_SC_R_MJPEG_DEC_S3>;
>>> + };
>>> +
>>> + jpegenc: jpegenc@58450000 {
>>> + reg = <0x58450000 0x00050000>;
>>> + interrupts = <GIC_SPI 305 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 306 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 307 IRQ_TYPE_LEVEL_HIGH>,
>>> + <GIC_SPI 308 IRQ_TYPE_LEVEL_HIGH>;
>>> + clocks = <&img_jpeg_enc_lpcg IMX_LPC[GIT PULL FOR
>>> v5.16]G_CLK_0>,
>>> + <&img_jpeg_enc_lpcg IMX_LPCG_CLK_4>;
>>> + clock-names = "per", "ipg";
>>> + assigned-clocks = <&img_jpeg_enc_lpcg
>>> IMX_LPCG_CLK_0>,
>>> + <&img_jpeg_enc_lpcg
>>> IMX_LPCG_CLK_4>;
>>> + assigned-clock-rates = <200000000>, <200000000>;
>>> + power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>,
>>> + <&pd IMX_SC_R_MJPEG_ENC_S0>,
>>> + <&pd IMX_SC_R_MJPEG_ENC_S1>,
>>> + <&pd IMX_SC_R_MJPEG_ENC_S2>,
>>> + <&pd IMX_SC_R_MJPEG_ENC_S3>;
>>> + };
>>> +
>>> + img_jpeg_dec_lpcg: clock-controller@585d0000 {
>>> + compatible = "fsl,imx8qxp-lpcg";
>>> + reg = <0x585d0000 0x10000>;
>>> + #clock-cells = <1>;
>>> + clocks = <&img_ipg_clk>, <&img_ipg_clk>;
>>> + clock-indices = <IMX_LPCG_CLK_0>,
>>> + <IMX_LPCG_CLK_4>;
>>> + clock-output-names = "img_jpeg_dec_lpcg_clk",
>>> + "img_jpeg_dec_lpcg_ipg_clk";
>>> + power-domains = <&pd IMX_SC_R_MJPEG_DEC_MP>;
>>> + };
>>> +
>>> + img_jpeg_enc_lpcg: clock-controller@585f0000 {
>>> + compatible = "fsl,imx8qxp-lpcg";
>>> + reg = <0x585f0000 0x10000>;
>>> + #clock-cells = <1>;
>>> + clocks = <&img_ipg_clk>, <&img_ipg_clk>;
>>> + clock-indices = <IMX_LPCG_CLK_0>,
>>> + <IMX_LPCG_CLK_4>;
>>> + clock-output-names = "img_jpeg_enc_lpcg_clk",
>>> + "img_jpeg_enc_lpcg_ipg_clk";
>>> + power-domains = <&pd IMX_SC_R_MJPEG_ENC_MP>;
>>> + };
>>> +};
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi
>>> b/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi
>>> new file mode 100644
>>> index 000000000000..7764b4146e0a
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-img.dtsi
>>> @@ -0,0 +1,12 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Copyright 2021 NXP
>>> + */
>>> +
>>> +&jpegdec {
>>> + compatible = "nxp,imx8qm-jpgdec", "nxp,imx8qxp-jpgdec";
>>> +};
>>> +
>>> +&jpegenc {
>>> + compatible = "nxp,imx8qm-jpgdec", "nxp,imx8qxp-jpgenc";
>>> +};
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> index 12cd059b339b..aebbe2b84aa1 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8qm.dtsi
>>> @@ -166,11 +166,13 @@
>>> };
>>>
>>> /* sorted in register address */
>>> + #include "imx8-ss-img.dtsi"
>>> #include "imx8-ss-dma.dtsi"
>>> #include "imx8-ss-conn.dtsi"
>>> #include "imx8-ss-lsio.dtsi"
>>> };
>>>
>>> +#include "imx8qm-ss-img.dtsi"
>>> #include "imx8qm-ss-dma.dtsi"
>>> #include "imx8qm-ss-conn.dtsi"
>>> #include "imx8qm-ss-lsio.dtsi"
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi
>>> b/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi
>>> new file mode 100644
>>> index 000000000000..3a087317591d
>>> --- /dev/null
>>> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-ss-img.dtsi
>>> @@ -0,0 +1,13 @@
>>> +// SPDX-License-Identifier: GPL-2.0+
>>> +/*
>>> + * Copyright 2021 NXP
>>> + * Dong Aisheng <aisheng.dong@nxp.com>
>>> + */
>>> +
>>> +&jpegdec {
>>> + compatible = "nxp,imx8qxp-jpgdec";
>>> +};
>>> +
>>> +&jpegenc {
>>> + compatible = "nxp,imx8qxp-jpgenc";
>>> +};
>>> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>>> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>>> index 1e6b4995091e..a625fb6bdc62 100644
>>> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>>> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
>>> @@ -258,12 +258,14 @@
>>> };
>>>
>>> /* sorted in register address */
>>> + #include "imx8-ss-img.dtsi"
>>> #include "imx8-ss-adma.dtsi"
>>> #include "imx8-ss-conn.dtsi"
>>> #include "imx8-ss-ddr.dtsi"
>>> #include "imx8-ss-lsio.dtsi"
>>> };
>>>
>>> +#include "imx8qxp-ss-img.dtsi"
>>> #include "imx8qxp-ss-adma.dtsi"
>>> #include "imx8qxp-ss-conn.dtsi"
>>> #include "imx8qxp-ss-lsio.dtsi"
>>>
next prev parent reply other threads:[~2021-09-14 10:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-19 14:36 [PATCH v14 0/2] Add dts and bindings update for i.MX8QM/QXP JPEG codec Mirela Rabulea (OSS)
2021-06-19 14:36 ` [PATCH v14 1/2] media: dt-bindings: imx-jpeg: Add compatible for i.MX8QM " Mirela Rabulea (OSS)
2021-06-21 3:46 ` Aisheng Dong
2021-07-12 20:13 ` Rob Herring
2021-06-19 14:36 ` [PATCH v14 2/2] arm64: dts: imx8: Add jpeg encoder/decoder nodes Mirela Rabulea (OSS)
2021-06-21 3:50 ` Aisheng Dong
2021-09-14 7:11 ` Hans Verkuil
2021-09-14 10:42 ` [EXT] " Mirela Rabulea
2021-09-14 10:44 ` Hans Verkuil [this message]
2021-07-14 7:45 ` [PATCH v14 0/2] Add dts and bindings update for i.MX8QM/QXP JPEG codec Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d63d65d-c230-d3a8-56c2-5d2b08400497@xs4all.nl \
--to=hverkuil-cisco@xs4all.nl \
--cc=aisheng.dong@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=guoniu.zhou@nxp.com \
--cc=kernel@pengutronix.de \
--cc=laurentiu.palcu@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=mirela.rabulea@nxp.com \
--cc=mirela.rabulea@oss.nxp.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=peng.fan@nxp.com \
--cc=robert.chiras@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).