From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Subject: [PATCH 4/4] media: Kconfig: don't use visible for device type select
Date: Wed, 25 Mar 2020 17:03:57 +0100 [thread overview]
Message-ID: <3e077a758967e059705a214246ab49194a796b8b.1585151701.git.mchehab+huawei@kernel.org> (raw)
In-Reply-To: <cover.1585151701.git.mchehab+huawei@kernel.org>
While making the menu invisible seemed a good idea, there's
a drawback: when the menu is not visible, it is not parsing
the "default" dependency.
So, instead, let's just avoid the items at the menu to be
prompted, by using the "prompt ... if" construction.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
---
drivers/media/Kconfig | 25 ++++++++++++++++---------
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 787a8b8f288a..e880c7fae664 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -57,13 +57,13 @@ config MEDIA_SUBDRV_AUTOSELECT
If unsure say Y.
menu "Media device types"
- visible if MEDIA_SUPPORT_FILTER
#
# Multimedia support - automatically enable V4L2 and DVB core
#
config MEDIA_CAMERA_SUPPORT
- bool "Cameras and video grabbers"
+ bool
+ prompt "Cameras and video grabbers" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable support for webcams and video grabbers.
@@ -71,7 +71,8 @@ config MEDIA_CAMERA_SUPPORT
Say Y when you have a webcam or a video capture grabber board.
config MEDIA_ANALOG_TV_SUPPORT
- bool "Analog TV"
+ bool
+ prompt "Analog TV" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable analog TV support.
@@ -79,7 +80,8 @@ config MEDIA_ANALOG_TV_SUPPORT
Say Y when you have a board with analog TV support.
config MEDIA_DIGITAL_TV_SUPPORT
- bool "Digital TV"
+ bool
+ prompt "Digital TV" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable digital TV support.
@@ -87,7 +89,8 @@ config MEDIA_DIGITAL_TV_SUPPORT
Say Y when you have a board with digital TV support.
config MEDIA_RADIO_SUPPORT
- bool "AM/FM radio receivers/transmitters"
+ bool
+ prompt "AM/FM radio receivers/transmitters" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable AM/FM radio support.
@@ -98,7 +101,8 @@ config MEDIA_RADIO_SUPPORT
Say Y when you have a board with radio support.
config MEDIA_SDR_SUPPORT
- bool "Software defined radio"
+ bool
+ prompt "Software defined radio" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable software defined radio support.
@@ -106,7 +110,8 @@ config MEDIA_SDR_SUPPORT
Say Y when you have a software defined radio device.
config MEDIA_CEC_SUPPORT
- bool "HDMI CEC support"
+ bool
+ prompt "HDMI CEC support" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable support for HDMI CEC (Consumer Electronics Control),
@@ -116,7 +121,8 @@ config MEDIA_CEC_SUPPORT
adapter that supports HDMI CEC.
config MEDIA_PLATFORM_SUPPORT
- bool "Platform-specific devices"
+ bool
+ prompt "Platform-specific devices" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Enable support for complex cameras, codecs, and other hardware
@@ -129,7 +135,8 @@ config MEDIA_PLATFORM_SUPPORT
Say Y when you want to be able so see such devices.
config MEDIA_TEST_SUPPORT
- bool "Test drivers"
+ bool
+ prompt "Test drivers" if MEDIA_SUPPORT_FILTER
default y if !MEDIA_SUPPORT_FILTER
help
Those drivers should not be used on production Kernels, but
--
2.25.1
next prev parent reply other threads:[~2020-03-25 16:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 16:03 [PATCH 0/4] media Kconfig reorg - part 2 Mauro Carvalho Chehab
2020-03-25 16:03 ` [PATCH 1/4] media: dvb-core: Kconfig: default to use dynamic minors Mauro Carvalho Chehab
2020-03-25 16:03 ` [PATCH 2/4] media: Kconfig files: use select for V4L2 subdevs and MC Mauro Carvalho Chehab
2020-03-25 16:03 ` [PATCH 3/4] media: i2c/Kconfig: reorganize items there Mauro Carvalho Chehab
2020-03-25 16:03 ` Mauro Carvalho Chehab [this message]
2020-03-25 19:36 ` [PATCH 0/4] media Kconfig reorg - part 2 Helen Koike
2020-03-25 21:38 ` Mauro Carvalho Chehab
2020-03-25 22:13 ` Laurent Pinchart
2020-03-26 8:28 ` Mauro Carvalho Chehab
2020-03-26 10:13 ` Laurent Pinchart
2020-03-26 12:51 ` Mauro Carvalho Chehab
2020-03-26 16:07 ` Mauro Carvalho Chehab
2020-04-01 10:59 ` Dan Carpenter
2020-04-02 9:27 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e077a758967e059705a214246ab49194a796b8b.1585151701.git.mchehab+huawei@kernel.org \
--to=mchehab+huawei@kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).