From: Hans Verkuil <hverkuil@xs4all.nl>
To: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>,
Steve Longerbeam <slongerbeam@gmail.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel@puri.sm,
phone-devel@vger.kernel.org
Subject: Re: [PATCHv3 4/4] media: imx: Use dedicated format handler for i.MX7/8
Date: Fri, 28 Jan 2022 11:57:00 +0100 [thread overview]
Message-ID: <3f5a10aa-fda8-ea3d-9ca2-eba77c720338@xs4all.nl> (raw)
In-Reply-To: <20211019120047.827915-4-dorota.czaplejewicz@puri.sm>
Hi Dorota,
Since I marked "media: Add 16-bit Bayer formats" as 'Changes Requested', and since
this patch appears to depend on that patch based on a comment in the first patch,
I decided to mark this series as 'Changes Requested' (except for patch 1 which has
already been accepted).
Please post a v4 if you want this in, and add the "media: Add 16-bit Bayer formats"
patch as well to that v4 series.
Thanks!
Hans
On 19/10/2021 14:14, Dorota Czaplejewicz wrote:
> This splits out a format handler which takes into account
> the capabilities of the i.MX7/8 video device,
> as opposed to the default handler compatible with both i.MX5/6 and i.MX7/8.
>
> Signed-off-by: Dorota Czaplejewicz <dorota.czaplejewicz@puri.sm>
> ---
> drivers/staging/media/imx/imx-media-utils.c | 56 +++++++++++++++++++--
> 1 file changed, 52 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/imx/imx-media-utils.c b/drivers/staging/media/imx/imx-media-utils.c
> index 8b5c6bcfd4fa..1ff7ec4c877a 100644
> --- a/drivers/staging/media/imx/imx-media-utils.c
> +++ b/drivers/staging/media/imx/imx-media-utils.c
> @@ -516,10 +516,9 @@ void imx_media_try_colorimetry(struct v4l2_mbus_framefmt *tryfmt,
> }
> EXPORT_SYMBOL_GPL(imx_media_try_colorimetry);
>
> -int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
> - const struct v4l2_mbus_framefmt *mbus,
> - const struct imx_media_pixfmt *cc,
> - enum imx_media_device_type type)
> +static int imx56_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
> + const struct v4l2_mbus_framefmt *mbus,
> + const struct imx_media_pixfmt *cc)
> {
> u32 width;
> u32 stride;
> @@ -568,6 +567,55 @@ int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
>
> return 0;
> }
> +
> +static int imx78_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
> + const struct v4l2_mbus_framefmt *mbus,
> + const struct imx_media_pixfmt *cc)
> +{
> + int ret;
> +
> + if (!cc)
> + cc = imx_media_find_mbus_format(mbus->code, PIXFMT_SEL_ANY);
> +
> + /*
> + * The hardware can handle line lengths divisible by 4 pixels
> + * as long as the whole buffer size ends up divisible by 8 bytes.
> + * If not, use the value of 8 pixels recommended in the datasheet.
> + */
> + ret = v4l2_fill_pixfmt(pix, cc->fourcc,
> + round_up(mbus->width, 4), mbus->height);
> + if (ret)
> + return ret;
> +
> + /* Only 8bits-per-pixel formats may need to get aligned to 8 pixels,
> + * because both 10-bit and 16-bit pixels occupy 2 bytes.
> + * In those, 4-pixel aligmnent is equal to 8-byte alignment.
> + */
> + if (pix->sizeimage % 8 != 0)
> + ret = v4l2_fill_pixfmt(pix, cc->fourcc,
> + round_up(mbus->width, 8), mbus->height);
> +
> + pix->colorspace = mbus->colorspace;
> + pix->xfer_func = mbus->xfer_func;
> + pix->ycbcr_enc = mbus->ycbcr_enc;
> + pix->quantization = mbus->quantization;
> + pix->field = mbus->field;
> +
> + return ret;
> +}
> +
> +int imx_media_mbus_fmt_to_pix_fmt(struct v4l2_pix_format *pix,
> + const struct v4l2_mbus_framefmt *mbus,
> + const struct imx_media_pixfmt *cc,
> + enum imx_media_device_type type) {
> + switch (type) {
> + case DEVICE_TYPE_IMX56:
> + return imx56_media_mbus_fmt_to_pix_fmt(pix, mbus, cc);
> + case DEVICE_TYPE_IMX78:
> + return imx78_media_mbus_fmt_to_pix_fmt(pix, mbus, cc);
> + }
> + return -EINVAL;
> +}
> EXPORT_SYMBOL_GPL(imx_media_mbus_fmt_to_pix_fmt);
>
> void imx_media_free_dma_buf(struct device *dev,
next prev parent reply other threads:[~2022-01-28 10:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 12:13 [PATCHv3 1/4] media: imx: Remove unused functions Dorota Czaplejewicz
2021-10-19 12:13 ` [PATCHv3 2/4] media: imx: Store the type of hardware implementation Dorota Czaplejewicz
2021-10-19 12:14 ` [PATCHv3 3/4] media: imx: Forward " Dorota Czaplejewicz
2021-10-19 12:14 ` [PATCHv3 4/4] media: imx: Use dedicated format handler for i.MX7/8 Dorota Czaplejewicz
2021-11-03 12:32 ` Philipp Zabel
2021-11-04 9:54 ` Rui Miguel Silva
2022-01-28 10:57 ` Hans Verkuil [this message]
2021-11-03 12:32 ` [PATCHv3 1/4] media: imx: Remove unused functions Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f5a10aa-fda8-ea3d-9ca2-eba77c720338@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=dorota.czaplejewicz@puri.sm \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=kernel@puri.sm \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=phone-devel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=slongerbeam@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).