From: Kishon Vijay Abraham I <kishon@ti.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Rafal Ciepiela <rafalc@cadence.com>,
Krzysztof Witos <kwitos@cadence.com>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
Chen-Yu Tsai <wens@csie.org>, Sean Paul <seanpaul@chromium.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-media@vger.kernel.org>
Subject: Re: [PATCH v5 0/9] phy: Add configuration interface for MIPI D-PHY devices
Date: Wed, 6 Feb 2019 17:43:12 +0530 [thread overview]
Message-ID: <4177fba5-279d-3283-88f0-c681f72e5951@ti.com> (raw)
In-Reply-To: <20190205084620.GW3271@phenom.ffwll.local>
Hi,
On 05/02/19 2:16 PM, Daniel Vetter wrote:
> On Mon, Feb 04, 2019 at 03:33:31PM +0530, Kishon Vijay Abraham I wrote:
>>
>>
>> On 21/01/19 9:15 PM, Maxime Ripard wrote:
>>> Hi,
>>>
>>> Here is a set of patches to allow the phy framework consumers to test and
>>> apply runtime configurations.
>>>
>>> This is needed to support more phy classes that require tuning based on
>>> parameters depending on the current use case of the device, in addition to
>>> the power state management already provided by the current functions.
>>>
>>> A first test bed for that API are the MIPI D-PHY devices. There's a number
>>> of solutions that have been used so far to support these phy, most of the
>>> time being an ad-hoc driver in the consumer.
>>>
>>> That approach has a big shortcoming though, which is that this is quite
>>> difficult to deal with consumers integrated with multiple variants of phy,
>>> of multiple consumers integrated with the same phy.
>>>
>>> The latter case can be found in the Cadence DSI bridge, and the CSI
>>> transceiver and receivers. All of them are integrated with the same phy, or
>>> can be integrated with different phy, depending on the implementation.
>>>
>>> I've looked at all the MIPI DSI drivers I could find, and gathered all the
>>> parameters I could find. The interface should be complete, and most of the
>>> drivers can be converted in the future. The current set converts two of
>>> them: the above mentionned Cadence DSI driver so that the v4l2 drivers can
>>> use them, and the Allwinner MIPI-DSI driver.
>>
>> Can the PHY changes go independently of the consumer drivers? or else I'll need
>> ACKs from the GPU MAINTAINER.
>
> Maxime is a gpu maintainer, so you're all good :-)
cool.. I've merged all the patches except drm/bridge.
Please see if everything looks okay once it shows up in phy -next (give a day)
Thanks
Kishon
> -Daniel
>
>>
>> Thanks
>> Kishon
>>
>>>
>>> Let me know what you think,
>>> Maxime
>>>
>>> Changes from v4:
>>> - Removed regression on the variable calculation
>>> - Fixed the wakeup unit
>>> - Collected Sean Acked-by on the last patch
>>> - Collected Sakari Reviewed-by on the first patch
>>>
>>> Changes from v3
>>> - Rebased on 5.0-rc1
>>> - Added the fixes suggested by Sakari
>>>
>>> Changes from v2:
>>> - Rebased on next
>>> - Changed the interface to accomodate for the new submodes
>>> - Changed the timings units from nanoseconds to picoseconds
>>> - Added minimum and maximum boundaries to the documentation
>>> - Moved the clock enabling to phy_power_on in the Cadence DPHY driver
>>> - Exported the phy_configure and phy_validate symbols
>>> - Rework the phy pll divider computation in the cadence dphy driver
>>>
>>> Changes from v1:
>>> - Rebased on top of 4.20-rc1
>>> - Removed the bus mode and timings parameters from the MIPI D-PHY
>>> parameters, since that shouldn't have any impact on the PHY itself.
>>> - Reworked the Cadence DSI and D-PHY drivers to take this into account.
>>> - Remove the mode parameter from phy_configure
>>> - Added phy_configure and phy_validate stubs
>>> - Return -EOPNOTSUPP in phy_configure and phy_validate when the operation
>>> is not implemented
>>>
>>> Maxime Ripard (9):
>>> phy: dphy: Remove unused header
>>> phy: dphy: Change units of wakeup and init parameters
>>> phy: dphy: Clarify lanes parameter documentation
>>> sun6i: dsi: Convert to generic phy handling
>>> phy: Move Allwinner A31 D-PHY driver to drivers/phy/
>>> drm/bridge: cdns: Separate DSI and D-PHY configuration
>>> dt-bindings: phy: Move the Cadence D-PHY bindings
>>> phy: Add Cadence D-PHY support
>>> drm/bridge: cdns: Convert to phy framework
>>>
>>> Documentation/devicetree/bindings/display/bridge/cdns,dsi.txt | 21 +-
>>> Documentation/devicetree/bindings/phy/cdns,dphy.txt | 20 +-
>>> drivers/gpu/drm/bridge/Kconfig | 1 +-
>>> drivers/gpu/drm/bridge/cdns-dsi.c | 538 +------
>>> drivers/gpu/drm/sun4i/Kconfig | 3 +-
>>> drivers/gpu/drm/sun4i/Makefile | 5 +-
>>> drivers/gpu/drm/sun4i/sun6i_mipi_dphy.c | 292 +----
>>> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 31 +-
>>> drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 17 +-
>>> drivers/phy/allwinner/Kconfig | 12 +-
>>> drivers/phy/allwinner/Makefile | 1 +-
>>> drivers/phy/allwinner/phy-sun6i-mipi-dphy.c | 318 ++++-
>>> drivers/phy/cadence/Kconfig | 13 +-
>>> drivers/phy/cadence/Makefile | 1 +-
>>> drivers/phy/cadence/cdns-dphy.c | 389 +++++-
>>> drivers/phy/phy-core-mipi-dphy.c | 8 +-
>>> include/linux/phy/phy-mipi-dphy.h | 13 +-
>>> 17 files changed, 894 insertions(+), 789 deletions(-)
>>> create mode 100644 Documentation/devicetree/bindings/phy/cdns,dphy.txt
>>> delete mode 100644 drivers/gpu/drm/sun4i/sun6i_mipi_dphy.c
>>> create mode 100644 drivers/phy/allwinner/phy-sun6i-mipi-dphy.c
>>> create mode 100644 drivers/phy/cadence/cdns-dphy.c
>>>
>>> base-commit: bfeffd155283772bbe78c6a05dec7c0128ee500c
>>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
next prev parent reply other threads:[~2019-02-06 12:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 15:45 [PATCH v5 0/9] phy: Add configuration interface for MIPI D-PHY devices Maxime Ripard
2019-01-21 15:45 ` [PATCH v5 1/9] phy: dphy: Remove unused header Maxime Ripard
2019-01-21 15:45 ` [PATCH v5 2/9] phy: dphy: Change units of wakeup and init parameters Maxime Ripard
2019-01-21 15:45 ` [PATCH v5 3/9] phy: dphy: Clarify lanes parameter documentation Maxime Ripard
2019-01-21 15:45 ` [PATCH v5 4/9] sun6i: dsi: Convert to generic phy handling Maxime Ripard
2019-02-07 8:15 ` Paul Kocialkowski
2019-01-21 15:45 ` [PATCH v5 5/9] phy: Move Allwinner A31 D-PHY driver to drivers/phy/ Maxime Ripard
2019-02-07 8:19 ` Paul Kocialkowski
2019-01-21 15:45 ` [PATCH v5 6/9] drm/bridge: cdns: Separate DSI and D-PHY configuration Maxime Ripard
2019-02-07 8:44 ` Paul Kocialkowski
2019-02-07 9:16 ` Maxime Ripard
2019-01-21 15:45 ` [PATCH v5 7/9] dt-bindings: phy: Move the Cadence D-PHY bindings Maxime Ripard
2019-01-21 15:45 ` [PATCH v5 8/9] phy: Add Cadence D-PHY support Maxime Ripard
2019-01-21 15:45 ` [PATCH v5 9/9] drm/bridge: cdns: Convert to phy framework Maxime Ripard
2019-02-04 10:03 ` [PATCH v5 0/9] phy: Add configuration interface for MIPI D-PHY devices Kishon Vijay Abraham I
2019-02-04 13:51 ` Maxime Ripard
2019-02-05 8:46 ` Daniel Vetter
2019-02-06 12:13 ` Kishon Vijay Abraham I [this message]
2019-02-06 12:25 ` Maxime Ripard
2019-02-06 12:30 ` Kishon Vijay Abraham I
2019-02-07 9:17 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4177fba5-279d-3283-88f0-c681f72e5951@ti.com \
--to=kishon@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kwitos@cadence.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=rafalc@cadence.com \
--cc=seanpaul@chromium.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).