From: Rajendra Nayak <rnayak@codeaurora.org>
To: Rob Herring <robh@kernel.org>
Cc: stanimir.varbanov@linaro.org, agross@kernel.org,
bjorn.andersson@linaro.org, linux-arm-msm@vger.kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, mka@chromium.org
Subject: Re: [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting
Date: Thu, 9 Jul 2020 16:39:17 +0530 [thread overview]
Message-ID: <43b6f7ee-503c-1036-3f00-9fbb4d531ea0@codeaurora.org> (raw)
In-Reply-To: <1e8c07c8-0954-462a-cfe6-a1ccde1bedea@codeaurora.org>
On 7/1/2020 4:50 PM, Rajendra Nayak wrote:
>
> On 6/1/2020 11:26 AM, Rajendra Nayak wrote:
>>
>> On 5/28/2020 1:06 AM, Rob Herring wrote:
>>> On Wed, May 13, 2020 at 11:33:27AM +0530, Rajendra Nayak wrote:
>>>> Add an optional power domain which when specified can be used for
>>>> setting the performance state of Venus.
>>>>
>>>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>>>> ---
>>>> Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml | 6 +++++-
>>>> Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 6 +++++-
>>>> 2 files changed, 10 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>>> index 764affa..ac1ed64 100644
>>>> --- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>>> +++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
>>>> @@ -25,12 +25,16 @@ properties:
>>>> maxItems: 1
>>>> power-domains:
>>>> - maxItems: 2
>>>> + minItems: 2
>>>> + maxItems: 3
>>>> power-domain-names:
>>>> + minItems: 2
>>>> + maxItems: 3
>>>> items:
>>>> - const: venus
>>>> - const: vcodec0
>>>> + - const: opp-pd
>>>
>>> Humm, looks suspicious. This is a phyical power island in this block?
>>
>> yes, this is used to represent the physical 'cx' power island in the SoC
>> (Its a shared power island, not a power island specific to this block)
>> that can be scaled to different 'performance levels' based on the frequency
>> the codec is expected to run at.
>
> Rob, Did you have any other concerns here? Should I be re-posting this?
Rob, ping.
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
prev parent reply other threads:[~2020-07-09 11:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 6:03 [PATCH v2] dt-bindings: media: venus: Add an optional power domain for perf voting Rajendra Nayak
2020-05-27 19:36 ` Rob Herring
2020-06-01 5:56 ` Rajendra Nayak
2020-07-01 11:20 ` Rajendra Nayak
2020-07-09 11:09 ` Rajendra Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43b6f7ee-503c-1036-3f00-9fbb4d531ea0@codeaurora.org \
--to=rnayak@codeaurora.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh@kernel.org \
--cc=stanimir.varbanov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).