From: Hans Verkuil <hverkuil@xs4all.nl>
To: Philipp Zabel <p.zabel@pengutronix.de>, linux-media@vger.kernel.org
Cc: Tomasz Figa <tfiga@chromium.org>,
Paul Kocialkowski <paul.kocialkowski@bootlin.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 2/2] media: uapi: h264: clarify pic_order_cnt_bit_size field
Date: Thu, 26 Sep 2019 15:23:43 +0200 [thread overview]
Message-ID: <457642c2-7d77-5eab-4537-01151b474aa9@xs4all.nl> (raw)
In-Reply-To: <20190905131255.10150-2-p.zabel@pengutronix.de>
On 9/5/19 3:12 PM, Philipp Zabel wrote:
> Since pic_order_cnt_bit_size is not a syntax element itself, explicitly
> state that it is the total size in bits of the pic_order_cnt_lsb,
> delta_pic_order_cnt_bottom, delta_pic_order_cnt[0], and
> delta_pic_order_cnt[1] syntax elements contained in the slice.
>
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> Documentation/media/uapi/v4l/ext-ctrls-codec.rst | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> index c281bc7ed1b3..08b49b2bbfa8 100644
> --- a/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> +++ b/Documentation/media/uapi/v4l/ext-ctrls-codec.rst
> @@ -1799,7 +1799,8 @@ enum v4l2_mpeg_video_h264_hierarchical_coding_type -
> - Size in bits of the dec_ref_pic_marking() syntax element.
> * - __u32
> - ``pic_order_cnt_bit_size``
> - -
> + - Size in bits of the pic_order_cnt_lsb, delta_pic_order_cnt_bottom,
> + delta_pic_order_cnt[0], and delta_pic_order_cnt[1] syntax elements.
It's a little bit ambiguous: this field contains the size in bits of all these
fields combined, right? Not the size in bits of each field separately.
I.e. if these fields are all 8 bits, then pic_order_cnt_bit_size is 4*8 and
not just 8.
I think this should be rephrased.
Regards,
Hans
> * - __u8
> - ``cabac_init_idc``
> -
>
next prev parent reply other threads:[~2019-09-26 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 13:12 [PATCH 1/2] media: uapi: h264: clarify dec_ref_pic_marking_bit_size fields Philipp Zabel
2019-09-05 13:12 ` [PATCH 2/2] media: uapi: h264: clarify pic_order_cnt_bit_size field Philipp Zabel
2019-09-26 13:23 ` Hans Verkuil [this message]
2019-09-26 14:09 ` Philipp Zabel
2019-09-26 14:16 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457642c2-7d77-5eab-4537-01151b474aa9@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=boris.brezillon@collabora.com \
--cc=ezequiel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-media@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).