From: shuah <shuah@kernel.org>
To: Sean Young <sean@mess.org>, Patrick Lerda <patrick9876@free.fr>,
linux-media@vger.kernel.org, shuah <shuah@kernel.org>
Subject: Re: [PATCH 1/2] selftests: Use lirc.h from kernel tree, not from system
Date: Tue, 22 Jan 2019 08:51:01 -0700 [thread overview]
Message-ID: <46b12148-23d5-94a6-3c63-606636300bf4@kernel.org> (raw)
In-Reply-To: <dad2fab452d98aaadea210807f9e0545a7814b32.1547738495.git.sean@mess.org>
On 1/17/19 8:29 AM, Sean Young wrote:
> When the system lirc.h is older than v4.16, you will get errors like:
>
> ir_loopback.c:32:16: error: field ‘proto’ has incomplete type
> enum rc_proto proto;
>
> Cc: Shuah Khan <shuah@kernel.org>
> Signed-off-by: Sean Young <sean@mess.org>
> ---
> tools/testing/selftests/ir/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/ir/Makefile b/tools/testing/selftests/ir/Makefile
> index f4ba8eb84b95..ad06489c22a5 100644
> --- a/tools/testing/selftests/ir/Makefile
> +++ b/tools/testing/selftests/ir/Makefile
> @@ -1,5 +1,7 @@
> # SPDX-License-Identifier: GPL-2.0
> TEST_PROGS := ir_loopback.sh
> TEST_GEN_PROGS_EXTENDED := ir_loopback
> +APIDIR := ../../../include/uapi
> +CFLAGS += -Wall -O2 -I$(APIDIR)
>
> include ../lib.mk
>
Thanks for the fix. I can take this through kselftest tree if
there are no dependencies on any media patches. It looks that
way, just confirming. It will be very likely for rc5.
thanks,
-- Shuah
next prev parent reply other threads:[~2019-01-22 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:29 [PATCH 0/2] rcmm with minor tweaks and selftest Sean Young
2019-01-17 15:29 ` [PATCH 1/2] selftests: Use lirc.h from kernel tree, not from system Sean Young
2019-01-22 15:51 ` shuah [this message]
2019-01-22 16:47 ` Sean Young
2019-01-17 15:29 ` [PATCH 2/2] media: rc: rcmm decoder and encoder Sean Young
2019-01-17 19:30 ` [PATCH 0/1] description update Patrick Lerda
2019-01-17 19:32 ` [PATCH 1/1] " Patrick Lerda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46b12148-23d5-94a6-3c63-606636300bf4@kernel.org \
--to=shuah@kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=patrick9876@free.fr \
--cc=sean@mess.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).