From: Simon Arlott <simon@fire.lp0.eu>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-media@vger.kernel.org
Subject: Re: 2.6.39 "tuner-core: remove usage of DIGITAL_TV" breaks saa7134 with mt2050
Date: Thu, 14 Jul 2011 00:15:09 +0100 [thread overview]
Message-ID: <4E1E26FD.7020503@simon.arlott.org.uk> (raw)
In-Reply-To: <4E1D1DAF.4060900@redhat.com>
On 13/07/11 05:23, Mauro Carvalho Chehab wrote:
> Em 12-07-2011 18:21, Simon Arlott escreveu:
>> commit ad020dc2fe9039628cf6cef42cd1b76531ee8411
>> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
>> Date: Tue Feb 15 09:30:50 2011 -0200
>>
>> [media] tuner-core: remove usage of DIGITAL_TV
>>
>> This breaks my Pinnacle PCTV 300i DVB-T cards as they can no longer tune
>> DVB-T.
>>
>> [ 540.010030] tuner 3-0043: Tuner doesn't support mode 3. Putting tuner to sleep
>> [ 540.011017] tuner 2-0043: Tuner doesn't support mode 3. Putting tuner to sleep
>> [ 540.012012] tuner 3-0060: Tuner doesn't support mode 3. Putting tuner to sleep
>> [ 540.013029] tuner 2-0060: Tuner doesn't support mode 3. Putting tuner to sleep
>>
>> saa7134 needs to indicate digital TV tuning to mt20xx but it looks like
>> tuner-core no longer has any way to allow a tuner to indicate support
>> for this?
>>
>> (mt2050_set_tv_freq in mt20xx.c uses V4L2_TUNER_DIGITAL_TV)
>
> Could you please try the enclosed patch? It should fix the issue.
> I should probably rename T_ANALOG_TV to just T_TV, but I'll do it on
> a next patch if this one works ok, as we don't want to send a renaming
> patch to -stable.
This fixes it. Tuner error messages could do with being error level - I
didn't see the message initially as I have the debugging turned off.
The -EINVAL never gets passed up to userspace.
> ---
> [media] Fix Digital TV breakage with mt20xx tuner
>
> The mt20xx tuner passes V4L2_TUNER_DIGITAL_TV to tuner core. However, the
> check_mode code now doesn't handle it well. Change the logic there to
> avoid the breakage, and fix a test for analog-only at g_tuner.
Thanks,
--
Simon Arlott
prev parent reply other threads:[~2011-07-13 23:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-12 21:21 2.6.39 "tuner-core: remove usage of DIGITAL_TV" breaks saa7134 with mt2050 Simon Arlott
2011-07-13 4:23 ` Mauro Carvalho Chehab
2011-07-13 23:15 ` Simon Arlott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E1E26FD.7020503@simon.arlott.org.uk \
--to=simon@fire.lp0.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).