From: Antti Palosaari <crope@iki.fi>
To: Jose Alberto Reguero <jareguero@telefonica.net>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>,
linux-media@vger.kernel.org,
Michael Krufky <mkrufky@kernellabs.com>
Subject: Re: [PATCH] add support for the dvb-t part of CT-3650 v3
Date: Fri, 22 Jul 2011 14:32:53 +0300 [thread overview]
Message-ID: <4E295FE5.7040905@iki.fi> (raw)
In-Reply-To: <4E260E4A.2020707@iki.fi>
Have you had to time test these?
And about I2C adapter, I don't see why changes are needed. As far as I
understand it is already working with TDA10023 and you have done changes
for TDA10048 support. I compared TDA10048 and TDA10023 I2C functions and
those are ~similar. Both uses most typical access, for reg write {u8
REG, u8 VAL} and for reg read {u8 REG}/{u8 VAL}.
regards
Antti
On 07/20/2011 02:07 AM, Antti Palosaari wrote:
> On 07/19/2011 11:25 AM, Jose Alberto Reguero wrote:
>> On Martes, 19 de Julio de 2011 01:44:54 Antti Palosaari escribió:
>>> On 07/19/2011 02:00 AM, Jose Alberto Reguero wrote:
>>>> On Lunes, 18 de Julio de 2011 22:28:41 Antti Palosaari escribió:
>
>>>> There are two problems:
>>>>
>>>> First, the two frontends (tda10048 and tda10023) use tda10023 i2c gate
>>>> to talk with the tuner.
>>>
>>> Very easy to implement correctly. Attach tda10023 first and after that
>>> tda10048. Override tda10048 .i2c_gate_ctrl() with tda10023
>>> .i2c_gate_ctrl() immediately after tda10048 attach inside ttusb2.c. Now
>>> you have both demods (FEs) .i2c_gate_ctrl() which will control
>>> physically tda10023 I2C-gate as tuner is behind it.
>>>
>>
>> I try that, but don't work. I get an oops. Because the i2c gate
>> function of
>> the tda10023 driver use:
>>
>> struct tda10023_state* state = fe->demodulator_priv;
>>
>> to get the i2c adress. When called from tda10048, don't work.
>>
>> Jose Alberto
>>
>>>> The second is that with dvb-usb, there is only one frontend, and if you
>>>> wake up the second frontend, the adapter is not wake up. That can be
>>>> avoided the way I do in the patch, or mantaining the adapter alwais on.
>>>
>>> I think that could be also avoided similarly overriding demod callbacks
>>> and adding some more logic inside ttusb2.c.
>>>
>>> Proper fix that later problem is surely correct MFE support for
>>> DVB-USB-framework. I am now looking for it, lets see how difficult it
>>> will be.
>
>
> Signed-off-by: Antti Palosaari <crope@iki.fi>
>
> Test attached patches and try to fix if they are not working. Most
> likely not working since I don't have HW to test... I tested MFE parts
> using Anysee, so it should be working. I changed rather much your ttusb2
> and tda10048 patches, size reduced something like 50% or more. Still
> ttusb2 I2C-adapter changes made looks rather complex. Try to double
> check if those can be done easier. There is many drivers to look example
> from.
>
> DVB USB MFE is something like RFC. I know FE exclusive lock is missing,
> no need to mention that :) But other comments are welcome! I left three
> old "unneeded" pointers to struct dvb_usb_adapter to reduce changing all
> the drivers.
>
>
> regards
> Antti
>
--
http://palosaari.fi/
next prev parent reply other threads:[~2011-07-22 11:32 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201106070205.08118.jareguero@telefonica.net>
[not found] ` <201107070057.06317.jareguero@telefonica.net>
2011-07-13 12:41 ` [PATCH] add support for the dvb-t part of CT-3650 v2 Mauro Carvalho Chehab
2011-07-14 20:00 ` [PATCH] add support for the dvb-t part of CT-3650 v3 Jose Alberto Reguero
2011-07-18 20:28 ` Antti Palosaari
2011-07-18 21:31 ` Michael Krufky
[not found] ` <201107190100.16802.jareguero@telefonica.net>
2011-07-18 23:44 ` Antti Palosaari
2011-07-19 8:25 ` Jose Alberto Reguero
2011-07-19 23:07 ` Antti Palosaari
2011-07-22 11:32 ` Antti Palosaari [this message]
2011-07-22 16:02 ` Jose Alberto Reguero
2011-07-22 16:08 ` Antti Palosaari
2011-07-22 16:25 ` Jose Alberto Reguero
2011-07-22 16:46 ` Antti Palosaari
[not found] ` <201107222012.20711.jareguero@telefonica.net>
2011-07-22 21:49 ` Jose Alberto Reguero
2011-07-22 22:23 ` Antti Palosaari
2011-07-23 8:26 ` Jose Alberto Reguero
2011-07-23 9:42 ` Antti Palosaari
2011-07-23 10:21 ` Jose Alberto Reguero
2011-07-23 10:37 ` Antti Palosaari
2011-07-23 15:41 ` Jose Alberto Reguero
2011-07-23 17:47 ` Antti Palosaari
2011-07-23 21:45 ` Jose Alberto Reguero
2011-07-27 19:22 ` Antti Palosaari
2011-07-28 19:25 ` Jose Alberto Reguero
2011-08-02 19:21 ` Jose Alberto Reguero
2011-08-08 10:35 ` Jose Alberto Reguero
2011-08-08 21:44 ` Antti Palosaari
2011-08-09 19:45 ` Jose Alberto Reguero
2011-07-16 11:38 ` [PATCH] improve recection with limits frecuenies and tda827x Jose Alberto Reguero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E295FE5.7040905@iki.fi \
--to=crope@iki.fi \
--cc=jareguero@telefonica.net \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=mkrufky@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).