From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5155DC282C4 for ; Tue, 12 Feb 2019 21:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 26EFD222BE for ; Tue, 12 Feb 2019 21:22:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730278AbfBLVWb (ORCPT ); Tue, 12 Feb 2019 16:22:31 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:43704 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729512AbfBLVWb (ORCPT ); Tue, 12 Feb 2019 16:22:31 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 35D8327FB65 Message-ID: <4a1346315224850faf31345b577ce3a29c069f3a.camel@collabora.com> Subject: Re: [PATCH v3 0/2] media: cedrus: Add H264 decoding support From: Ezequiel Garcia To: Tomasz Figa , Maxime Ripard Cc: Hans Verkuil , Alexandre Courbot , Sakari Ailus , Laurent Pinchart , Pawel Osciak , Paul Kocialkowski , Chen-Yu Tsai , Linux Kernel Mailing List , "list@263.net:IOMMU DRIVERS , Joerg " "Roedel ," , Linux Media Mailing List , Nicolas Dufresne , jenskuske@gmail.com, Jernej Skrabec , Jonas Karlman , linux-sunxi@googlegroups.com, Thomas Petazzoni Date: Tue, 12 Feb 2019 18:22:17 -0300 In-Reply-To: References: Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hey Tomasz, On Tue, 2019-02-12 at 21:50 +0900, Tomasz Figa wrote: > Hi Maxime, > > On Mon, Feb 11, 2019 at 11:39 PM Maxime Ripard > wrote: > > Hi, > > > > Here is a new version of the H264 decoding support in the cedrus > > driver. > > Thanks for working on this. Please see my comments below. > > > As you might already know, the cedrus driver relies on the Request > > API, and is a reverse engineered driver for the video decoding engine > > found on the Allwinner SoCs. > > > > This work has been possible thanks to the work done by the people > > behind libvdpau-sunxi found here: > > https://github.com/linux-sunxi/libvdpau-sunxi/ > > > > I've tested the various ABI using this gdb script: > > http://code.bulix.org/jl4se4-505620?raw > > > > And this test script: > > http://code.bulix.org/8zle4s-505623?raw > > > > The application compiled is quite trivial: > > http://code.bulix.org/e34zp8-505624?raw > > > > The output is: > > arm: builds/arm-test-v4l2-h264-structures > > SHA1: 88cbf7485ba81831fc3b93772b215599b3b38318 > > x86: builds/x86-test-v4l2-h264-structures > > SHA1: 88cbf7485ba81831fc3b93772b215599b3b38318 > > x64: builds/x64-test-v4l2-h264-structures > > SHA1: 88cbf7485ba81831fc3b93772b215599b3b38318 > > arm64: builds/arm64-test-v4l2-h264-structures > > SHA1: 88cbf7485ba81831fc3b93772b215599b3b38318 > > > > Let me know if there's any flaw using that test setup, or if you have > > any comments on the patches. > > > > Maxime > > > > Changes from v2: > > - Simplified _cedrus_write_ref_list as suggested by Jernej > > - Set whether the frame is used as reference using nal_ref_idc > > - Respect chroma_format_idc > > - Fixes for the scaling list and prediction tables > > - Wrote the documentation for the flags > > - Added a bunch of defines to the driver bit fields > > - Reworded the controls and data format descriptions as suggested > > by Hans > > - Reworked the controls' structure field size to avoid padding > > - Removed the long term reference flag > > This and... > Maxime has dropped this because of Ayaka's mail about long term references not making much sense in stateless decoders. I noticed that RK3399 TRM has a field to specify long term refs and so was wondering about this item as well. > > - Reintroduced the neighbor info buffer > > - Removed the ref_pic_list_p0/b0/b1 arrays that are redundant with the > > one in the DPB > > these are used in our Rockchip VDEC driver. > > Could you elaborate on the reasons why they got removed? > If I understood correctly, there are two reference picture lists. P-frames will populate ref_pic_list0 and B-frames will populate both. According to this, v4l2_ctrl_h264_slice_param.ref_pic_list0 and .ref_pic_list1 should be enough and ref_pic_list_p0/b0/b1 are not needed. What do you think? Regards, Ezequiel