* [PATCH 3/8] drivers: (video|gpu): fix warning same module names
@ 2019-06-06 9:47 Anders Roxell
2019-06-07 7:57 ` Daniel Vetter
0 siblings, 1 reply; 3+ messages in thread
From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw)
To: marex, stefan, airlied, daniel, shawnguo, s.hauer, b.zolnierkie
Cc: andrew, vivien.didelot, f.fainelli, a.hajda, mchehab, p.zabel,
hkallweit1, lee.jones, lgirdwood, broonie, davem, netdev,
linux-kernel, dri-devel, linux-arm-kernel, linux-fbdev,
linux-media, Anders Roxell
When building with CONFIG_DRM_MXSFB and CONFIG_FB_MXS enabled as
loadable modules, we see the following warning:
warning: same module names found:
drivers/video/fbdev/mxsfb.ko
drivers/gpu/drm/mxsfb/mxsfb.ko
Rework so the names matches the config fragment.
Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
---
drivers/gpu/drm/mxsfb/Makefile | 4 ++--
drivers/video/fbdev/Makefile | 3 ++-
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/mxsfb/Makefile b/drivers/gpu/drm/mxsfb/Makefile
index ff6e358088fa..5d49d7548e66 100644
--- a/drivers/gpu/drm/mxsfb/Makefile
+++ b/drivers/gpu/drm/mxsfb/Makefile
@@ -1,3 +1,3 @@
# SPDX-License-Identifier: GPL-2.0-only
-mxsfb-y := mxsfb_drv.o mxsfb_crtc.o mxsfb_out.o
-obj-$(CONFIG_DRM_MXSFB) += mxsfb.o
+drm-mxsfb-y := mxsfb_drv.o mxsfb_crtc.o mxsfb_out.o
+obj-$(CONFIG_DRM_MXSFB) += drm-mxsfb.o
diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
index 655f2537cac1..7ee967525af2 100644
--- a/drivers/video/fbdev/Makefile
+++ b/drivers/video/fbdev/Makefile
@@ -131,7 +131,8 @@ obj-$(CONFIG_FB_VGA16) += vga16fb.o
obj-$(CONFIG_FB_OF) += offb.o
obj-$(CONFIG_FB_MX3) += mx3fb.o
obj-$(CONFIG_FB_DA8XX) += da8xx-fb.o
-obj-$(CONFIG_FB_MXS) += mxsfb.o
+obj-$(CONFIG_FB_MXS) += fb-mxs.o
+fb-mxs-objs := mxsfb.o
obj-$(CONFIG_FB_SSD1307) += ssd1307fb.o
obj-$(CONFIG_FB_SIMPLE) += simplefb.o
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 3/8] drivers: (video|gpu): fix warning same module names
2019-06-06 9:47 [PATCH 3/8] drivers: (video|gpu): fix warning same module names Anders Roxell
@ 2019-06-07 7:57 ` Daniel Vetter
2019-06-07 12:05 ` Bartlomiej Zolnierkiewicz
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Vetter @ 2019-06-07 7:57 UTC (permalink / raw)
To: Anders Roxell
Cc: marex, stefan, airlied, daniel, shawnguo, s.hauer, b.zolnierkie,
andrew, vivien.didelot, f.fainelli, a.hajda, mchehab, p.zabel,
hkallweit1, lee.jones, lgirdwood, broonie, davem, netdev,
linux-kernel, dri-devel, linux-arm-kernel, linux-fbdev,
linux-media
On Thu, Jun 06, 2019 at 11:47:12AM +0200, Anders Roxell wrote:
> When building with CONFIG_DRM_MXSFB and CONFIG_FB_MXS enabled as
> loadable modules, we see the following warning:
>
> warning: same module names found:
> drivers/video/fbdev/mxsfb.ko
> drivers/gpu/drm/mxsfb/mxsfb.ko
>
> Rework so the names matches the config fragment.
>
> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
I'm assuming Bart will pick this one up for fbdev.
-Daniel
> ---
> drivers/gpu/drm/mxsfb/Makefile | 4 ++--
> drivers/video/fbdev/Makefile | 3 ++-
> 2 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/mxsfb/Makefile b/drivers/gpu/drm/mxsfb/Makefile
> index ff6e358088fa..5d49d7548e66 100644
> --- a/drivers/gpu/drm/mxsfb/Makefile
> +++ b/drivers/gpu/drm/mxsfb/Makefile
> @@ -1,3 +1,3 @@
> # SPDX-License-Identifier: GPL-2.0-only
> -mxsfb-y := mxsfb_drv.o mxsfb_crtc.o mxsfb_out.o
> -obj-$(CONFIG_DRM_MXSFB) += mxsfb.o
> +drm-mxsfb-y := mxsfb_drv.o mxsfb_crtc.o mxsfb_out.o
> +obj-$(CONFIG_DRM_MXSFB) += drm-mxsfb.o
> diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
> index 655f2537cac1..7ee967525af2 100644
> --- a/drivers/video/fbdev/Makefile
> +++ b/drivers/video/fbdev/Makefile
> @@ -131,7 +131,8 @@ obj-$(CONFIG_FB_VGA16) += vga16fb.o
> obj-$(CONFIG_FB_OF) += offb.o
> obj-$(CONFIG_FB_MX3) += mx3fb.o
> obj-$(CONFIG_FB_DA8XX) += da8xx-fb.o
> -obj-$(CONFIG_FB_MXS) += mxsfb.o
> +obj-$(CONFIG_FB_MXS) += fb-mxs.o
> +fb-mxs-objs := mxsfb.o
> obj-$(CONFIG_FB_SSD1307) += ssd1307fb.o
> obj-$(CONFIG_FB_SIMPLE) += simplefb.o
>
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 3/8] drivers: (video|gpu): fix warning same module names
2019-06-07 7:57 ` Daniel Vetter
@ 2019-06-07 12:05 ` Bartlomiej Zolnierkiewicz
0 siblings, 0 replies; 3+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2019-06-07 12:05 UTC (permalink / raw)
To: Daniel Vetter, Anders Roxell
Cc: marex, stefan, airlied, shawnguo, s.hauer, andrew,
vivien.didelot, f.fainelli, a.hajda, mchehab, p.zabel,
hkallweit1, lee.jones, lgirdwood, broonie, davem, netdev,
linux-kernel, dri-devel, linux-arm-kernel, linux-fbdev,
linux-media
On 6/7/19 9:57 AM, Daniel Vetter wrote:
> On Thu, Jun 06, 2019 at 11:47:12AM +0200, Anders Roxell wrote:
>> When building with CONFIG_DRM_MXSFB and CONFIG_FB_MXS enabled as
>> loadable modules, we see the following warning:
>>
>> warning: same module names found:
>> drivers/video/fbdev/mxsfb.ko
>> drivers/gpu/drm/mxsfb/mxsfb.ko
>>
>> Rework so the names matches the config fragment.
>>
>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
>
> I'm assuming Bart will pick this one up for fbdev.
The DRM mxsfb has been a default for almost a year (since July
2018) and I've just applied "[PATCH] video: fbdev: mxsfb: Remove
driver" (https://marc.info/?l=dri-devel&m=155835758115686&w=2)
so it seems that this patch is not needed any longer (sorry!).
> -Daniel
>
>> ---
>> drivers/gpu/drm/mxsfb/Makefile | 4 ++--
>> drivers/video/fbdev/Makefile | 3 ++-
>> 2 files changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/mxsfb/Makefile b/drivers/gpu/drm/mxsfb/Makefile
>> index ff6e358088fa..5d49d7548e66 100644
>> --- a/drivers/gpu/drm/mxsfb/Makefile
>> +++ b/drivers/gpu/drm/mxsfb/Makefile
>> @@ -1,3 +1,3 @@
>> # SPDX-License-Identifier: GPL-2.0-only
>> -mxsfb-y := mxsfb_drv.o mxsfb_crtc.o mxsfb_out.o
>> -obj-$(CONFIG_DRM_MXSFB) += mxsfb.o
>> +drm-mxsfb-y := mxsfb_drv.o mxsfb_crtc.o mxsfb_out.o
>> +obj-$(CONFIG_DRM_MXSFB) += drm-mxsfb.o
>> diff --git a/drivers/video/fbdev/Makefile b/drivers/video/fbdev/Makefile
>> index 655f2537cac1..7ee967525af2 100644
>> --- a/drivers/video/fbdev/Makefile
>> +++ b/drivers/video/fbdev/Makefile
>> @@ -131,7 +131,8 @@ obj-$(CONFIG_FB_VGA16) += vga16fb.o
>> obj-$(CONFIG_FB_OF) += offb.o
>> obj-$(CONFIG_FB_MX3) += mx3fb.o
>> obj-$(CONFIG_FB_DA8XX) += da8xx-fb.o
>> -obj-$(CONFIG_FB_MXS) += mxsfb.o
>> +obj-$(CONFIG_FB_MXS) += fb-mxs.o
>> +fb-mxs-objs := mxsfb.o
>> obj-$(CONFIG_FB_SSD1307) += ssd1307fb.o
>> obj-$(CONFIG_FB_SIMPLE) += simplefb.o
>>
>> --
>> 2.20.1
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-07 12:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 9:47 [PATCH 3/8] drivers: (video|gpu): fix warning same module names Anders Roxell
2019-06-07 7:57 ` Daniel Vetter
2019-06-07 12:05 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).