Re: [RFC PATCH 01/13] staging: mmal-vchiq: Avoid use of bool in structures

From: Andrzej Pietrasiewicz <andrzej.p@collabora.com>
To: Maarten Vanraes <maarten@rmail.be>,
	Raspberry Pi Kernel Maintenance <kernel-list@raspberrypi.com>,
	linux-media@vger.kernel.org
Cc: Kieran Bingham <kbingham@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Umang Jain <umang.jain@ideasonboard.com>,
	Dave Stevenson <dave.stevenson@raspberrypi.org>
Subject: Re: [RFC PATCH 01/13] staging: mmal-vchiq: Avoid use of bool in structures
Date: Mon, 4 Mar 2024 08:30:38 +0100	[thread overview]
Message-ID: <4d24fc4c-5e55-48c7-874c-a5138b5d284f@collabora.com> (raw)
In-Reply-To: <20240303152635.2762696-2-maarten@rmail.be>

Hi Maarten,

W dniu 3.03.2024 o 16:09, Maarten Vanraes pisze:
> From: Dave Stevenson <dave.stevenson@raspberrypi.org>
> 
> Fixes up a checkpatch error "Avoid using bool structure members
> because of possible alignment issues".
> 

This commit message might be confusing, because...

> Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.org>
> Signed-off-by: Maarten Vanraes <maarten@rmail.be>
> ---
>   drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> index 890669f874d9..2e616604943d 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> @@ -1983,7 +1983,7 @@ int vchiq_mmal_component_enable(struct vchiq_mmal_instance *instance,
>   
>   	ret = enable_component(instance, component);
>   	if (ret == 0)
> -		component->enabled = true;
> +		component->enabled = 1;

... what the patch changes is not a structure member, it is the value assigned 
(with a potential implicit cast) to a structure member.

Regards,

Andrzej

>   
>   	mutex_unlock(&instance->vchiq_mutex);
>   