From: Bingbu Cao <bingbu.cao@linux.intel.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>, linux-i2c@vger.kernel.org
Cc: Wolfram Sang <wsa@the-dreams.de>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
rajmohan.mani@intel.com, Tomasz Figa <tfiga@chromium.org>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Bingbu Cao <bingbu.cao@intel.com>,
Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com>,
Hyungwoo Yang <hyungwoo.yang@intel.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 3/6] Documentation: ACPI: Document _DSC object usage for enum power state
Date: Mon, 25 Oct 2021 19:01:41 +0800 [thread overview]
Message-ID: <4da84e63-0e3d-155f-f3db-5d3a9efe3aa7@linux.intel.com> (raw)
In-Reply-To: <20211018121729.6357-4-sakari.ailus@linux.intel.com>
Sakari,
On 10/18/21 8:17 PM, Sakari Ailus wrote:
> Document the use of the _DSC object for setting desirable power state
> during probe.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
> ---
> Documentation/firmware-guide/acpi/index.rst | 1 +
> .../firmware-guide/acpi/non-d0-probe.rst | 78 +++++++++++++++++++
> 2 files changed, 79 insertions(+)
> create mode 100644 Documentation/firmware-guide/acpi/non-d0-probe.rst
>
> diff --git a/Documentation/firmware-guide/acpi/index.rst b/Documentation/firmware-guide/acpi/index.rst
> index a99ee402b212b..b053b0c3d6969 100644
> --- a/Documentation/firmware-guide/acpi/index.rst
> +++ b/Documentation/firmware-guide/acpi/index.rst
> @@ -26,5 +26,6 @@ ACPI Support
> acpi-lid
> lpit
> video_extension
> + non-d0-probe
> extcon-intel-int3496
> intel-pmc-mux
> diff --git a/Documentation/firmware-guide/acpi/non-d0-probe.rst b/Documentation/firmware-guide/acpi/non-d0-probe.rst
> new file mode 100644
> index 0000000000000..78781e1ab6a3d
> --- /dev/null
> +++ b/Documentation/firmware-guide/acpi/non-d0-probe.rst
> @@ -0,0 +1,78 @@
> +.. SPDX-License-Identifier: GPL-2.0
> +
> +========================================
> +Probing devices in other D states than 0
> +========================================
> +
> +Introduction
> +============
> +
> +In some cases it may be preferred to leave certain devices powered off for the
> +entire system bootup if powering on these devices has adverse side effects,
> +beyond just powering on the said device.
> +
> +How it works
> +============
> +
> +The _DSC (Device State for Configuration) object that evaluates to an integer
> +may be used to tell Linux the highest allowed D state for a device during
> +probe. The support for _DSC requires support from the kernel bus type if the
> +bus driver normally sets the device in D0 state for probe.
> +
> +The downside of using _DSC is that as the device is not powered on, even if
> +there's a problem with the device, the driver likely probes just fine but the
> +first user will find out the device doesn't work, instead of a failure at probe
> +time. This feature should thus be used sparingly.
> +
> +I²C
> +---
> +
> +If an I²C driver indicates its support for this by setting the
> +I2C_DRV_ACPI_WAIVE_D0_PROBE flag in struct i2c_driver.flags field and the
> +_DSC object evaluates to integer higher than the D state of the device,
> +the device will not be powered on (put in D0 state) for probe.
> +
> +D states
> +--------
> +
> +The D states and thus also the allowed values for _DSC are listed below. Refer
> +to [1] for more information on device power states.
> +
> +.. code-block:: text
> +
> + Number State Description
> + 0 D0 Device fully powered on
> + 1 D1
> + 2 D2
> + 3 D3hot
> + 4 D3cold Off
> +
> +References
> +==========
> +
> +[1] https://uefi.org/specifications/ACPI/6.4/02_Definition_of_Terms/Definition_of_Terms.html#device-power-state-definitions
> +
> +Example
> +=======
> +
> +An ASL example describing an ACPI device using _DSC object to tell Operating
> +System the device should remain powered off during probe looks like this. Some
> +objects not relevant from the example point of view have been omitted.
> +
> +.. code-block:: text
> +
> + Device (CAM0)
> + {
> + Name (_HID, "SONY319A")
> + Name (_UID, Zero)
> + Name (_CRS, ResourceTemplate ()
> + {
> + I2cSerialBus(0x0020, ControllerInitiated, 0x00061A80,
> + AddressingMode7Bit, "\\_SB.PCI0.I2C0",
> + 0x00, ResourceConsumer)
> + })
> + Name (_DSC, 0, NotSerialized)
> + {
> + Return (0x4)
> + }
One question here:
Is the value of _DSC object evaluated from 'Method' or 'Name' ?
> + }
>
--
Best regards,
Bingbu Cao
next prev parent reply other threads:[~2021-10-25 11:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-18 12:17 [PATCH v11 0/6] Support running driver's probe for a device powered off Sakari Ailus
2021-10-18 12:17 ` [PATCH 1/6] ACPI: scan: Obtain device's desired enumeration power state Sakari Ailus
2021-10-18 12:17 ` [PATCH 2/6] i2c: Allow an ACPI driver to manage the device's power state during probe Sakari Ailus
2021-10-18 12:17 ` [PATCH 3/6] Documentation: ACPI: Document _DSC object usage for enum power state Sakari Ailus
2021-10-25 11:01 ` Bingbu Cao [this message]
2021-10-25 11:25 ` Sakari Ailus
2021-10-18 12:17 ` [PATCH 4/6] ACPI: Add a convenience function to tell a device is in D0 state Sakari Ailus
2021-10-18 12:17 ` [PATCH 5/6] media: i2c: imx319: Support device probe in non-zero ACPI D state Sakari Ailus
2021-10-18 12:17 ` [PATCH 6/6] at24: Support probing while " Sakari Ailus
2021-11-03 18:10 ` [PATCH v11 0/6] Support running driver's probe for a device powered off Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4da84e63-0e3d-155f-f3db-5d3a9efe3aa7@linux.intel.com \
--to=bingbu.cao@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=chiranjeevi.rapolu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=hyungwoo.yang@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rajmohan.mani@intel.com \
--cc=sakari.ailus@linux.intel.com \
--cc=tfiga@chromium.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).